From 03da1bcf644a55a6a74aa7c2918c50e468a46f67 Mon Sep 17 00:00:00 2001 From: wangyuting2 <851424971@qq.com> Date: Mon, 26 Sep 2022 03:05:28 +0000 Subject: [PATCH 1/4] * Optimize code for review code. --- module/project/model.php | 10 +++++----- module/user/model.php | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/module/project/model.php b/module/project/model.php index 116239aebc..97eef3965b 100644 --- a/module/project/model.php +++ b/module/project/model.php @@ -2503,7 +2503,7 @@ class projectModel extends model if($project->type == 'project') { - $modal = $project->model; + $model = $project->model; $projectID = $project->id; $executionID = $this->dao->select('id')->from(TABLE_EXECUTION) ->where('project')->eq($projectID) @@ -2514,7 +2514,7 @@ class projectModel extends model } else { - $modal = $project->type == 'kanban' ? 'kanban' : 'scrum'; + $model = $project->type == 'kanban' ? 'kanban' : 'scrum'; $executionID = $project->id; $projectID = $project->project; } @@ -2527,9 +2527,9 @@ class projectModel extends model $_COOKIE['tab'] = 'project'; $navGroup = zget($this->lang->navGroup, $moduleName); - $this->lang->$navGroup->menu = $this->lang->noSprint->{$modal}->menu; - $this->lang->$navGroup->menuOrder = $this->lang->noSprint->{$modal}->menuOrder; - $this->lang->$navGroup->dividerMenu = $this->lang->noSprint->{$modal}->dividerMenu; + $this->lang->$navGroup->menu = $this->lang->noSprint->{$model}->menu; + $this->lang->$navGroup->menuOrder = $this->lang->noSprint->{$model}->menuOrder; + $this->lang->$navGroup->dividerMenu = $this->lang->noSprint->{$model}->dividerMenu; foreach($this->lang->$navGroup->menu as $label => $menu) { diff --git a/module/user/model.php b/module/user/model.php index 53187d0488..e7ca37c431 100644 --- a/module/user/model.php +++ b/module/user/model.php @@ -2975,7 +2975,7 @@ class userModel extends model */ public function processAccountSort($users = array()) { - if(isset($this->app->user->account) && isset($users[$this->app->user->account])) + if(isset($this->app->user->account) and isset($users[$this->app->user->account])) { $currentUser = array(); $currentUser[$this->app->user->account] = $users[$this->app->user->account]; From f1d51e5a0dcdb8fcdcdc20343090b3e3042dbffc Mon Sep 17 00:00:00 2001 From: wangyuting2 <851424971@qq.com> Date: Mon, 26 Sep 2022 06:02:47 +0000 Subject: [PATCH 2/4] * Finish task #70191. --- module/upgrade/css/to18guide.css | 3 +- module/upgrade/view/to18guide.html.php | 198 +++++++++++++------------ 2 files changed, 102 insertions(+), 99 deletions(-) diff --git a/module/upgrade/css/to18guide.css b/module/upgrade/css/to18guide.css index 56221c51cc..9e206b7d42 100644 --- a/module/upgrade/css/to18guide.css +++ b/module/upgrade/css/to18guide.css @@ -1,4 +1,5 @@ -.panel {width: 1200px; margin: auto; padding: 0px 40px 40px 40px;} +.modal-dialog {width: 1200px;} +.panel {padding: 0px 40px 40px 40px;} .panel h1 {margin-top: 20px; margin-bottom: 20px;} .panel .icon {font-size: 20px;} diff --git a/module/upgrade/view/to18guide.html.php b/module/upgrade/view/to18guide.html.php index f1e316b327..53bead6f5f 100644 --- a/module/upgrade/view/to18guide.html.php +++ b/module/upgrade/view/to18guide.html.php @@ -12,105 +12,107 @@ ?>