From 6e74ffd2ed8a566fbbc5627adf0ca05d08319cdc Mon Sep 17 00:00:00 2001 From: dingguodong Date: Mon, 29 May 2023 13:19:48 +0800 Subject: [PATCH] * Immediately return this expression instead of assigning it to the temporary variable. --- module/product/tao.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/module/product/tao.php b/module/product/tao.php index dec32d306b..be5ec9f97e 100644 --- a/module/product/tao.php +++ b/module/product/tao.php @@ -142,14 +142,12 @@ class productTao extends productModel */ protected function getPagerProductsWithProgramIn(array $productIDs, object|null $pager) :array { - $products = $this->dao->select('t1.*')->from(TABLE_PRODUCT)->alias('t1') + return $this->dao->select('t1.*')->from(TABLE_PRODUCT)->alias('t1') ->leftJoin(TABLE_PROGRAM)->alias('t2')->on('t1.program = t2.id') ->where('t1.id')->in($productIDs) ->orderBy('t2.order_asc, t1.line_desc, t1.order_asc') ->page($pager) ->fetchAll('id'); - - return $products; } /**