From 67c49bc1630abb4e38e504c21c6c6547e6b0eb86 Mon Sep 17 00:00:00 2001
From: liugang <liugang@chandao.com>
Date: Tue, 23 Sep 2025 10:26:09 +0800
Subject: [PATCH] * [misc] Enhance unit tests for
 repoModel::getCommitsByObject() method
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 module/repo/test/lib/repo.unittest.class.php  | 16 ++++++++
 module/repo/test/model/getcommitsbyobject.php | 41 ++++++++++++-------
 2 files changed, 42 insertions(+), 15 deletions(-)

diff --git a/module/repo/test/lib/repo.unittest.class.php b/module/repo/test/lib/repo.unittest.class.php
index bef381cd5a..da189de7e1 100755
--- a/module/repo/test/lib/repo.unittest.class.php
+++ b/module/repo/test/lib/repo.unittest.class.php
@@ -36,6 +36,22 @@ class repoTest
         return $this->objectModel->session->repoID;
     }
 
+    /**
+     * Test getCommitsByObject method.
+     *
+     * @param  int    $objectID
+     * @param  string $objectType
+     * @access public
+     * @return mixed
+     */
+    public function getCommitsByObjectTest(int $objectID, string $objectType)
+    {
+        $result = $this->objectModel->getCommitsByObject($objectID, $objectType);
+        if(dao::isError()) return dao::getError();
+
+        return $result;
+    }
+
     /**
      * Get switcher test.
      *
diff --git a/module/repo/test/model/getcommitsbyobject.php b/module/repo/test/model/getcommitsbyobject.php
index 26fb8fc3d7..75d6ca9aee 100755
--- a/module/repo/test/model/getcommitsbyobject.php
+++ b/module/repo/test/model/getcommitsbyobject.php
@@ -1,21 +1,27 @@
 #!/usr/bin/env php
 <?php
-include dirname(__FILE__, 5) . '/test/lib/init.php';
-include dirname(__FILE__, 2) . '/lib/repo.unittest.class.php';
-su('admin');
 
 /**
 
-title=测试 repoModel->getCommitsByObject();
+title=测试 repoModel::getCommitsByObject();
 timeout=0
-cid=8
+cid=0
 
-- 获取任务关联信息第0条的id属性 @1
-- 获取bug关联信息第0条的revision属性 @c808480afe22d3a55d94e91c59a8f3170212ade0
-- 获取需求关联信息第0条的comment属性 @代码注释
+- 步骤1：获取任务关联提交信息第0条的id属性 @1
+- 步骤2：获取bug关联提交信息第0条的revision属性 @c808480afe22d3a55d94e91c59a8f3170212ade0
+- 步骤3：获取需求关联提交信息第0条的comment属性 @代码注释
+- 步骤4：测试不存在对象ID @0
+- 步骤5：测试无效对象类型 @0
+- 步骤6：测试边界值ID为0 @0
+- 步骤7：测试负数ID @0
 
 */
 
+// 1. 导入依赖
+include dirname(__FILE__, 5) . '/test/lib/init.php';
+include dirname(__FILE__, 2) . '/lib/repo.unittest.class.php';
+
+// 2. zendata数据准备
 zenData('task')->gen(10);
 zenData('bug')->gen(10);
 zenData('story')->gen(10);
@@ -23,12 +29,17 @@ zenData('relation')->loadYaml('relation')->gen(3);
 zenData('repo')->loadYaml('repo')->gen(4);
 zenData('repohistory')->loadYaml('repohistory')->gen(1);
 
-$repo = $tester->loadModel('repo');
+// 3. 用户登录
+su('admin');
 
-$taskID  = 8;
-$bugID   = 4;
-$storyID = 10;
+// 4. 创建测试实例
+$repoTest = new repoTest();
 
-r($repo->getCommitsByObject($taskID, 'task'))   && p('0:id')       && e('1'); //获取任务关联信息
-r($repo->getCommitsByObject($bugID, 'bug'))     && p('0:revision') && e('c808480afe22d3a55d94e91c59a8f3170212ade0'); //获取bug关联信息
-r($repo->getCommitsByObject($storyID, 'story')) && p('0:comment')  && e('代码注释'); //获取需求关联信息
\ No newline at end of file
+// 5. 执行测试步骤（至少5个）
+r($repoTest->getCommitsByObjectTest(8, 'task'))    && p('0:id')       && e('1');                  // 步骤1：获取任务关联提交信息
+r($repoTest->getCommitsByObjectTest(4, 'bug'))     && p('0:revision') && e('c808480afe22d3a55d94e91c59a8f3170212ade0'); // 步骤2：获取bug关联提交信息
+r($repoTest->getCommitsByObjectTest(10, 'story'))  && p('0:comment')  && e('代码注释');             // 步骤3：获取需求关联提交信息
+r($repoTest->getCommitsByObjectTest(999, 'task'))  && p()             && e('0');                   // 步骤4：测试不存在对象ID
+r($repoTest->getCommitsByObjectTest(1, 'invalid')) && p()             && e('0');                   // 步骤5：测试无效对象类型
+r($repoTest->getCommitsByObjectTest(0, 'task'))    && p()             && e('0');                   // 步骤6：测试边界值ID为0
+r($repoTest->getCommitsByObjectTest(-1, 'bug'))    && p()             && e('0');                   // 步骤7：测试负数ID
\ No newline at end of file