From 62e9b5aa4471b985ffe57d3d649664ee06a75445 Mon Sep 17 00:00:00 2001 From: xieqiyu Date: Fri, 2 Sep 2022 09:44:14 +0800 Subject: [PATCH] * Code for task#66955. --- module/story/model.php | 21 +++++++++------------ module/task/config.php | 2 +- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/module/story/model.php b/module/story/model.php index 3f0060323c..38df6235dd 100644 --- a/module/story/model.php +++ b/module/story/model.php @@ -449,18 +449,6 @@ class storyModel extends model { $forceReview = $this->checkForceReview(); - $reviewers = ''; - foreach($_POST['title'] as $index => $value) - { - if($_POST['title'][$index] and isset($_POST['reviewer'][$index]) and empty($_POST['reviewDitto'][$index])) $reviewers = $_POST['reviewer'][$index] = array_filter($_POST['reviewer'][$index]); - if($_POST['title'][$index] and isset($_POST['reviewer'][$index]) and !empty($_POST['reviewDitto'][$index])) $_POST['reviewer'][$index] = $reviewers; - if($_POST['title'][$index] and empty($_POST['reviewer'][$index]) and $forceReview) - { - dao::$errors[] = $this->lang->story->errorEmptyReviewedBy; - return false; - } - } - $this->loadModel('action'); $branch = (int)$branch; $productID = (int)$productID; @@ -499,6 +487,7 @@ class storyModel extends model $extendFields = $this->getFlowExtendFields(); $data = array(); + $reviewers = ''; foreach($stories->title as $i => $title) { if(empty($title)) @@ -513,6 +502,14 @@ class storyModel extends model } if(empty($stories->reviewer[$i]) and empty($stories->reviewerDitto[$i])) $stories->reviewer[$i] = array(); + $reviewers = (isset($stories->reviewDitto[$i])) ? $reviewers : $stories->reviewer[$i]; + $stories->reviewer[$i] = $reviewers; + $_POST['reviewer'][$i] = $reviewers; + if(empty($stories->reviewer[$i]) and $forceReview) + { + dao::$errors[] = $this->lang->story->errorEmptyReviewedBy; + return false; + } $story = new stdclass(); $story->type = $type; diff --git a/module/task/config.php b/module/task/config.php index b45b5d0f00..116412e098 100644 --- a/module/task/config.php +++ b/module/task/config.php @@ -48,7 +48,7 @@ $config->task->custom->createFields = $config->task->customCreateFields; $config->task->custom->batchCreateFields = 'module,story,assignedTo,estimate,desc,pri'; $config->task->custom->batchEditFields = 'module,assignedTo,status,pri,estimate,record,left'; -$config->task->excludeCheckFileds = ',pri,estStartedDitto,deadlineDitto,'; +$config->task->excludeCheckFileds = ',pri,estStartedDitto,deadlineDitto,parent,'; $config->task->datatable = new stdclass(); $config->task->datatable->defaultField = array('id', 'pri', 'name', 'status', 'assignedTo', 'finishedBy', 'estimate', 'consumed', 'left', 'progress', 'deadline', 'actions');