From 5ae8c308317c8292dd135e78392007894491831e Mon Sep 17 00:00:00 2001 From: liugang Date: Tue, 15 Aug 2023 16:37:08 +0800 Subject: [PATCH] * testcaseModel: fix error of batch change module of cases. --- module/testcase/model.php | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/module/testcase/model.php b/module/testcase/model.php index a241662de5..32757a0d50 100644 --- a/module/testcase/model.php +++ b/module/testcase/model.php @@ -1395,17 +1395,18 @@ class testcaseModel extends model { if(!$caseIDList) return false; - $oldCases = $this->getByList($caseIDList, "module != {$moduleID}"); - $this->dao->update(TABLE_CASE)->set('module')->eq($moduleID)->where('module')->ne($moduleID)->andWhere('id')->in($caseIDList)->exec(); - if(dao::isError()) return false; - - $this->loadModel('action'); + $oldCases = $this->getByList($caseIDList, "module != '{$moduleID}'"); $case = new stdclass(); $case->module = $moduleID; $case->lastEditedBy = $this->app->user->account; $case->lastEditedDate = helper::now(); + $this->dao->update(TABLE_CASE)->data($case)->where('module')->ne($moduleID)->andWhere('id')->in($caseIDList)->exec(); + if(dao::isError()) return false; + + $this->loadModel('action'); + foreach($oldCases as $oldCase) { $changes = common::createChanges($oldCase, $case);