From 57b20f59d81c09389f54219ad535b5cf745afed4 Mon Sep 17 00:00:00 2001 From: songchenxuan Date: Thu, 3 Aug 2023 10:44:14 +0800 Subject: [PATCH] * Fix code review. --- module/pivot/js/preview.js | 1 - module/pivot/model.php | 6 +++++- module/product/model.php | 1 + module/program/model.php | 1 + 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/module/pivot/js/preview.js b/module/pivot/js/preview.js index b4373f1e43..69a83de0b5 100644 --- a/module/pivot/js/preview.js +++ b/module/pivot/js/preview.js @@ -129,7 +129,6 @@ function refreshPivot(pivotInfo, isOrigin = false) }); } - function calcPreviewGrowFilter() { if(pivot.filters.length <= 0) return; diff --git a/module/pivot/model.php b/module/pivot/model.php index 65384db443..c3a9ac9880 100644 --- a/module/pivot/model.php +++ b/module/pivot/model.php @@ -2259,9 +2259,13 @@ class pivotModel extends model } /** - * replace defined table names. + * Gen sheet by origin sql. * + * @param array $fields + * @param array $settings * @param string $sql + * @param array $filters + * @param array $langs * @access public * @return string */ diff --git a/module/product/model.php b/module/product/model.php index 2238ba1f0d..1ecdfcf0ab 100755 --- a/module/product/model.php +++ b/module/product/model.php @@ -1775,6 +1775,7 @@ class productModel extends model /** * Refresh stats info of products. * + * @param bool $refreshAll * @access public * @return void */ diff --git a/module/program/model.php b/module/program/model.php index cf2ca47f2a..45ac9e7706 100644 --- a/module/program/model.php +++ b/module/program/model.php @@ -1298,6 +1298,7 @@ class programModel extends model /** * Refresh stats fields(estimate,consumed,left,progress) of program, project, execution. * + * @param bool $refreshAll * @access public * @return void */