From 9aa6a9e7e9345296102a7fb5e806a0ff7cae9b47 Mon Sep 17 00:00:00 2001
From: xia0ta0 <xia0ta0@outlook.com>
Date: Mon, 24 Mar 2014 10:55:53 +0800
Subject: [PATCH 1/3]  * change str_replace to nl2br.

---
 module/bug/model.php           | 2 +-
 module/mail/view/test.html.php | 2 +-
 module/story/model.php         | 2 +-
 module/task/model.php          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/module/bug/model.php b/module/bug/model.php
index 100ff52e7f..fec11d38a3 100644
--- a/module/bug/model.php
+++ b/module/bug/model.php
@@ -93,7 +93,7 @@ class bugModel extends model
             $bug->project     = $data->projects[$i] ? $data->projects[$i] : 0;
             $bug->openedBuild = implode(',', $data->openedBuilds[$i]);
             $bug->title       = $data->titles[$i];
-            $bug->steps       = str_replace(array("\r\n", "\n"), '<br />', htmlspecialchars($data->stepses[$i]));
+            $bug->steps       = nl2br(htmlspecialchars($data->stepses[$i]));
             $bug->type        = $data->types[$i];
             $bug->severity    = $data->severities[$i];
             $bug->os          = $data->oses[$i];
diff --git a/module/mail/view/test.html.php b/module/mail/view/test.html.php
index 710bf0dd17..d32ce8b2fd 100755
--- a/module/mail/view/test.html.php
+++ b/module/mail/view/test.html.php
@@ -12,7 +12,7 @@
 if(isset($error))
 {
     include '../../common/view/header.lite.html.php';
-    die("<br />" . str_replace('\n', "<br />", join('', $error)));
+    die("<br />" . nl2br(join('', $error)));
 }
 ?>
 
diff --git a/module/story/model.php b/module/story/model.php
index 12c0284685..0d8ed7f9d7 100644
--- a/module/story/model.php
+++ b/module/story/model.php
@@ -227,7 +227,7 @@ class storyModel extends model
                 $specData[$i]->story   = $storyID;
                 $specData[$i]->version = 1;
                 $specData[$i]->title   = htmlspecialchars($stories->title[$i]);
-                if($stories->spec[$i] != '') $specData[$i]->spec = str_replace(array("\r\n", "\n"), '<br />', htmlspecialchars($stories->spec[$i]));
+                if($stories->spec[$i] != '') $specData[$i]->spec = nl2br(htmlspecialchars($stories->spec[$i]));
                 $this->dao->insert(TABLE_STORYSPEC)->data($specData[$i])->exec();
 
                 $this->loadModel('action');
diff --git a/module/task/model.php b/module/task/model.php
index 08041f40c2..08c973ca59 100644
--- a/module/task/model.php
+++ b/module/task/model.php
@@ -112,7 +112,7 @@ class taskModel extends model
             $data[$i]->module       = $tasks->module[$i]     == 'ditto' ? (isset($data[$i-1]) ? $data[$i-1]->module     : 0) : $tasks->module[$i];
             $data[$i]->assignedTo   = $tasks->assignedTo[$i] == 'ditto' ? (isset($data[$i-1]) ? $data[$i-1]->assignedTo : 0) : $tasks->assignedTo[$i];
             $data[$i]->name         = htmlspecialchars($tasks->name[$i]);
-            $data[$i]->desc         = str_replace(array("\r\n", "\n"), '<br />', htmlspecialchars($tasks->desc[$i]));
+            $data[$i]->desc         = nl2br(htmlspecialchars($tasks->desc[$i]));
             $data[$i]->pri          = $tasks->pri[$i];
             $data[$i]->estimate     = $tasks->estimate[$i];
             $data[$i]->left         = $tasks->estimate[$i];

From 4f6181ef3fcee420fbc43928d00c43ede46bbe36 Mon Sep 17 00:00:00 2001
From: xia0ta0 <xia0ta0@outlook.com>
Date: Mon, 24 Mar 2014 14:24:09 +0800
Subject: [PATCH 2/3]  * adjust batchcreate of task.

---
 module/project/css/managemembers.css  | 1 +
 module/task/css/batchcreate.css       | 3 ++-
 module/task/view/batchcreate.html.php | 6 +++---
 3 files changed, 6 insertions(+), 4 deletions(-)
 create mode 100644 module/project/css/managemembers.css

diff --git a/module/project/css/managemembers.css b/module/project/css/managemembers.css
new file mode 100644
index 0000000000..3f8b0d18f9
--- /dev/null
+++ b/module/project/css/managemembers.css
@@ -0,0 +1 @@
+.active-result, .chzn-single{text-align:left;}
diff --git a/module/task/css/batchcreate.css b/module/task/css/batchcreate.css
index dd8985f71b..6d9120961a 100644
--- a/module/task/css/batchcreate.css
+++ b/module/task/css/batchcreate.css
@@ -1,3 +1,4 @@
 textarea {height:16px}
-.icon-green-same:before {content: "\f105";}
+#icon-same {margin:4px 0;}
+.icon-green-same:before {content: "\f0c5"; font-size:small; color:grey;}
 .sameAsStory{float:right;}
diff --git a/module/task/view/batchcreate.html.php b/module/task/view/batchcreate.html.php
index 7e7203a7e5..4ee222be4c 100644
--- a/module/task/view/batchcreate.html.php
+++ b/module/task/view/batchcreate.html.php
@@ -18,10 +18,10 @@
     <caption><?php echo $lang->task->project . $lang->colon . $lang->task->batchCreate;?></caption>
     <tr>
       <th class='w-20px'><?php echo $lang->idAB;?></th> 
+      <th class='w-200px'><?php echo $lang->task->module?></th>
       <th><?php echo $lang->task->story;?></th>
       <th class='red'><?php echo $lang->task->name;?></th>
       <th class='w-60px red'><?php echo $lang->typeAB;?></th>
-      <th class='w-80px'><?php echo $lang->task->module?></th>
       <th class='w-80px'><?php echo $lang->task->assignedTo;?></th>
       <th class='w-50px'><?php echo $lang->task->estimateAB;?></th>
       <th class='w-200px'><?php echo $lang->task->desc;?></th>
@@ -51,15 +51,15 @@
     <?php $pri = 3;?>
     <tr class='a-center'>
       <td><?php echo $i + 1;?></td>
+      <td><?php echo html::select("module[$i]", $modules, $module, "class='select-1' onchange='setStories(this.value, $project->id, $i)'")?></td>
       <td class='a-left' style='overflow:visible'>
         <?php 
         echo html::select("story[$i]", $stories, $currentStory, "class='select-1' onchange='setStoryRelated($i)'");
-        echo html::a("javascript:copyStoryTitle($i)", "<i class='icon-green-same'></i>", '', "class='sameAsStory' title='{$lang->task->copyStoryTitle}'");
+        echo html::a("javascript:copyStoryTitle($i)", "<i class='icon-green-same' id='icon-same'></i>", '', "class='sameAsStory' title='{$lang->task->copyStoryTitle}'");
         ?>
       </td>
       <td><?php echo html::input("name[$i]", '', 'class=text-1');?></td>
       <td><?php echo html::select("type[$i]", $lang->task->typeList, $type, 'class=select-1');?></td>
-      <td><?php echo html::select("module[$i]", $modules, $module, "class='select-1' onchange='setStories(this.value, $project->id, $i)'")?></td>
       <td><?php echo html::select("assignedTo[$i]", $members, $member, 'class=select-1');?></td>
       <td><?php echo html::input("estimate[$i]", '', 'class=text-1');?></td>
       <td><?php echo html::textarea("desc[$i]", '', "rows='1' class=text-1");?></td>

From 689c758bdb344d80473fdbf215f8d4ad66556461 Mon Sep 17 00:00:00 2001
From: xia0ta0 <xia0ta0@outlook.com>
Date: Mon, 24 Mar 2014 14:49:36 +0800
Subject: [PATCH 3/3]  * merge desc and goal.

---
 module/upgrade/model.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/upgrade/model.php b/module/upgrade/model.php
index 31dfd47daa..0d5eb9ec22 100644
--- a/module/upgrade/model.php
+++ b/module/upgrade/model.php
@@ -771,7 +771,7 @@ class upgradeModel extends model
         foreach($projects as $id => $project)
         {
             $this->dao->update(TABLE_PROJECT)
-                ->set('`desc`')->eq($project->goal . '<br />' . $project->desc)
+                ->set('`desc`')->eq($project->desc . '<br />' . $project->goal)
                 ->where('id')->eq($id)
                 ->exec();
         }