From 4e69741e7013929d51b2bee99f44e232149acdcb Mon Sep 17 00:00:00 2001
From: holan20180123 <56391770@qq.com>
Date: Thu, 12 Nov 2020 14:18:08 +0800
Subject: [PATCH] * Finish task #8194.

---
 module/doc/model.php                   |  9 +++++++-
 module/project/control.php             | 29 +++++++++++++++-----------
 module/project/view/treestory.html.php |  4 ++--
 module/project/view/treetask.html.php  |  6 +++---
 module/project/view/view.html.php      |  4 ++--
 module/story/view/view.html.php        |  2 +-
 module/testcase/view/view.html.php     |  6 +++---
 7 files changed, 36 insertions(+), 24 deletions(-)

diff --git a/module/doc/model.php b/module/doc/model.php
index e08db05a43..a399234707 100644
--- a/module/doc/model.php
+++ b/module/doc/model.php
@@ -107,8 +107,15 @@ class docModel extends model
                 }
             }
 
+            /* Determines whether the doc lib is editable. */
+            $docLib          = new stdClass();
+            $docLib->product = $productID;
+            $docLib->project = $projectID;
+            $changeAllowed   = common::checkObjectChangeAllowed('doc', $docLib);
+
+            $lib      = isset($lib) ? $lib : new stdClass();
             $actions  = $this->setFastMenu($fastLib);
-            $actions .= common::hasPriv('doc', 'createLib') ? html::a(helper::createLink('doc', 'createLib', "type={$type}&objectID={$currentLib}"), "<i class='icon icon-plus'></i> " . $this->lang->doc->createLib, '', "class='btn btn-secondary iframe'") : '';
+            $actions .= ($changeAllowed and common::hasPriv('doc', 'createLib', $lib)) ? html::a(helper::createLink('doc', 'createLib', "type={$type}&objectID={$currentLib}"), "<i class='icon icon-plus'></i> " . $this->lang->doc->createLib, '', "class='btn btn-secondary iframe'") : '';
 
             $this->lang->TRActions = $actions;
         }
diff --git a/module/project/control.php b/module/project/control.php
index 5d75a981b0..7672abbd4e 100644
--- a/module/project/control.php
+++ b/module/project/control.php
@@ -1576,6 +1576,10 @@ class project extends control
         $project = $this->project->getById($projectID, true);
         if(!$project) die(js::error($this->lang->notFound) . js::locate('back'));
 
+        /* Determines whether an object is editable. */
+        $changeAllowed = true;
+        if(!empty($this->config->global->closedProjectStatus) and $project->status == 'closed') $changeAllowed = false;
+
         $products = $this->project->getProducts($project->id);
         $linkedBranches = array();
         foreach($products as $product)
@@ -1600,18 +1604,19 @@ class project extends control
         $this->view->position[] = html::a($this->createLink('project', 'browse', "projectID=$projectID"), $project->name);
         $this->view->position[] = $this->view->title;
 
-        $this->view->project      = $project;
-        $this->view->products     = $products;
-        $this->view->branchGroups = $this->loadModel('branch')->getByProducts(array_keys($products), '', $linkedBranches);
-        $this->view->planGroups   = $this->project->getPlans($products);
-        $this->view->groups       = $this->loadModel('group')->getPairs();
-        $this->view->actions      = $this->loadModel('action')->getList('project', $projectID);
-        $this->view->dynamics     = $this->loadModel('action')->getDynamic('all', 'all', 'date_desc', $pager, 'all', $projectID);
-        $this->view->users        = $this->loadModel('user')->getPairs('noletter');
-        $this->view->teamMembers  = $this->project->getTeamMembers($projectID);
-        $this->view->docLibs      = $this->loadModel('doc')->getLibsByObject('project', $projectID);
-        $this->view->statData     = $this->project->statRelatedData($projectID);
-        $this->view->chartData    = $chartData;
+        $this->view->project       = $project;
+        $this->view->products      = $products;
+        $this->view->branchGroups  = $this->loadModel('branch')->getByProducts(array_keys($products), '', $linkedBranches);
+        $this->view->planGroups    = $this->project->getPlans($products);
+        $this->view->groups        = $this->loadModel('group')->getPairs();
+        $this->view->actions       = $this->loadModel('action')->getList('project', $projectID);
+        $this->view->dynamics      = $this->loadModel('action')->getDynamic('all', 'all', 'date_desc', $pager, 'all', $projectID);
+        $this->view->users         = $this->loadModel('user')->getPairs('noletter');
+        $this->view->teamMembers   = $this->project->getTeamMembers($projectID);
+        $this->view->docLibs       = $this->loadModel('doc')->getLibsByObject('project', $projectID);
+        $this->view->statData      = $this->project->statRelatedData($projectID);
+        $this->view->chartData     = $chartData;
+        $this->view->changeAllowed = $changeAllowed;
 
         $this->display();
     }
diff --git a/module/project/view/treestory.html.php b/module/project/view/treestory.html.php
index 593fb0ba83..436360f244 100644
--- a/module/project/view/treestory.html.php
+++ b/module/project/view/treestory.html.php
@@ -32,7 +32,7 @@
     <?php echo !empty($story->verify) ? $story->verify : "<div class='text-center text-muted'>" . $lang->noData . '</div>';?>
   </div>
 </div>
-<?php echo $this->fetch('file', 'printFiles', array('files' => $story->files, 'fieldset' => 'true'));?>
+<?php echo $this->fetch('file', 'printFiles', array('files' => $story->files, 'fieldset' => 'true', 'object' => $story));?>
 
 <details class="detail" open>
   <summary class="detail-title"><?php echo $lang->story->legendBasicInfo;?></summary>
@@ -341,7 +341,7 @@
     </table>
   </div>
 </details>
-<?php $actionFormLink = $this->createLink('action', 'comment', "objectType=story&objectID=$story->id");?>
+<?php if(common::checkObjectChangeAllowed('story', $story)) $actionFormLink = $this->createLink('action', 'comment', "objectType=story&objectID=$story->id");?>
 <?php include '../../common/view/action.html.php';?>
 <script>
 <?php if(isset($pageJS)) echo $pageJS;?>
diff --git a/module/project/view/treetask.html.php b/module/project/view/treetask.html.php
index 406581d5bd..33433ca643 100644
--- a/module/project/view/treetask.html.php
+++ b/module/project/view/treetask.html.php
@@ -58,7 +58,7 @@
   <div class='detail-content article-content'>
     <?php echo (!empty($task->storySpec) || !empty($task->storyFiles)) ? $task->storySpec : "<div class='text-center text-muted'>" . $lang->noData . '</div>';?>
   </div>
-  <?php echo $this->fetch('file', 'printFiles', array('files' => $task->storyFiles, 'fieldset' => 'false'));?>
+  <?php echo $this->fetch('file', 'printFiles', array('files' => $task->storyFiles, 'fieldset' => 'false', 'object' => $task));?>
 </div>
 <div class='detail' open>
   <div class='detail-title'><?php echo $lang->task->storyVerify;?></div>
@@ -78,8 +78,8 @@
 </div>
 <?php endif;?>
 <?php endif;?>
-<?php echo $this->fetch('file', 'printFiles', array('files' => $task->files, 'fieldset' => 'true'));?>
-<?php $actionFormLink = $this->createLink('action', 'comment', "objectType=task&objectID=$task->id");?>
+<?php echo $this->fetch('file', 'printFiles', array('files' => $task->files, 'fieldset' => 'true', 'object' => $task));?>
+<?php if(common::checkObjectChangeAllowed('task', $task)) $actionFormLink = $this->createLink('action', 'comment', "objectType=task&objectID=$task->id");?>
 <?php include '../../common/view/action.html.php';?>
 <script>
 <?php if(isset($pageJS)) echo $pageJS;?>
diff --git a/module/project/view/view.html.php b/module/project/view/view.html.php
index 3da59f0ae6..7c47a1ab66 100644
--- a/module/project/view/view.html.php
+++ b/module/project/view/view.html.php
@@ -102,7 +102,7 @@
                 <?php $j++;?>
                 <?php endforeach;?>
                 <div class="col-xs-6">
-                  <?php common::printLink('project', 'manageMembers', "projectID=$project->id", "<i class='icon icon-plus hl-primary text-primary'></i> &nbsp;" . $lang->project->manageMembers, '', "class='text-muted'");?>
+                  <?php if($changeAllowed) common::printLink('project', 'manageMembers', "projectID=$project->id", "<i class='icon icon-plus hl-primary text-primary'></i> &nbsp;" . $lang->project->manageMembers, '', "class='text-muted'");?>
                 </div>
                 <?php endif;?>
               </div>
@@ -133,7 +133,7 @@
                 <?php $i++;?>
                 <?php endforeach;?>
                 <div class="col-xs-6">
-                  <?php common::printLink('doc', 'createLib', "type=project&objectID=$project->id", "<i class='icon icon-plus hl-primary text-primary'></i> &nbsp;" . $lang->doc->createLib, '', "class='text-muted iframe' data-width='1000px'");?>
+                  <?php if($changeAllowed) common::printLink('doc', 'createLib', "type=project&objectID=$project->id", "<i class='icon icon-plus hl-primary text-primary'></i> &nbsp;" . $lang->doc->createLib, '', "class='text-muted iframe' data-width='1000px'");?>
                 </div>
                 <?php endif;?>
               </div>
diff --git a/module/story/view/view.html.php b/module/story/view/view.html.php
index 53ec2d8aab..a29b2054d7 100644
--- a/module/story/view/view.html.php
+++ b/module/story/view/view.html.php
@@ -131,7 +131,7 @@
             $divideLang = ($story->type == 'story' || !$story->type) ? $lang->story->subdivide : $lang->story->splitRequirent; 
             $misc       = "class='btn divideStory' data-toggle='modal' data-type='iframe' data-width='95%'";
             $link       = $this->createLink('story', 'batchCreate', "productID=$story->product&branch=$story->branch&moduleID=$story->module&storyID=$story->id", '', true);
-            if(common::hasPriv('story', 'batchCreate')) echo html::a($link, "<i class='icon icon-treemap-alt'></i> " . $divideLang, '', $misc);
+            if(common::hasPriv('story', 'batchCreate', $story)) echo html::a($link, "<i class='icon icon-treemap-alt'></i> " . $divideLang, '', $misc);
         }
 
         common::printIcon('story', 'assignTo', "storyID=$story->id", $story, 'button', '', '', 'iframe showinonlybody', true);
diff --git a/module/testcase/view/view.html.php b/module/testcase/view/view.html.php
index 4546d8c6ba..583a82d508 100644
--- a/module/testcase/view/view.html.php
+++ b/module/testcase/view/view.html.php
@@ -50,7 +50,7 @@
   <?php if(!isonlybody()):?>
   <div class='btn-toolbar pull-right'>
     <button type='button' class='btn btn-secondary fullscreen-btn' title='<?php echo $lang->retrack;?>'><i class='icon icon-fullscreen'></i><?php echo ' ' . $lang->retrack;?></button>
-    <?php common::printLink('testcase', 'create', "productID={$case->product}&branch={$case->branch}&moduleID={$case->module}", "<i class='icon icon-plus'></i>" . $lang->testcase->create, '', "class='btn btn-primary'"); ?>
+    <?php if(common::checkObjectChangeAllowed('testcase', $case)) common::printLink('testcase', 'create', "productID={$case->product}&branch={$case->branch}&moduleID={$case->module}", "<i class='icon icon-plus'></i>" . $lang->testcase->create, '', "class='btn btn-primary'"); ?>
   </div>
   <?php endif;?>
 </div>
@@ -105,7 +105,7 @@
         <div class="detail-content article-content"><?php echo nl2br(htmlspecialchars($case->xml));?></div>
       </div>
       <?php endif;?>
-      <?php echo $this->fetch('file', 'printFiles', array('files' => $case->files, 'fieldset' => 'true'));?>
+      <?php echo $this->fetch('file', 'printFiles', array('files' => $case->files, 'fieldset' => 'true', 'object' => $case));?>
     </div>
     <?php $this->printExtendFields($case, 'div', "position=left&inForm=0&inCell=1");?>
     <div class='main-actions'>
@@ -194,7 +194,7 @@
                 if($case->story and $case->storyStatus == 'active' and $case->latestStoryVersion > $case->storyVersion)
                 {
                     echo "(<span class='warning'>{$lang->story->changed}</span> ";
-                    if(common::hasPriv('testcase', 'confirmStoryChange')) echo html::a($this->createLink('testcase', 'confirmStoryChange', "caseID=$case->id"), $lang->confirm, 'hiddenwin');
+                    if(common::hasPriv('testcase', 'confirmStoryChange', $case)) echo html::a($this->createLink('testcase', 'confirmStoryChange', "caseID=$case->id"), $lang->confirm, 'hiddenwin');
                     echo ")";
                 }
                 ?>