From 2e79c5f8696744194ed021936b33f8e3af0b5d34 Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Wed, 29 Dec 2021 03:49:17 +0000
Subject: [PATCH 01/22] Finish task #46679 and fix a bug.

---
 module/my/control.php                   |  1 +
 module/programplan/control.php          |  1 +
 module/programplan/js/create.js         |  2 +
 module/programplan/lang/en.php          |  1 +
 module/programplan/lang/zh-cn.php       |  1 +
 module/programplan/model.php            |  3 +-
 module/programplan/view/create.html.php | 65 +++++++++++++------------
 module/project/view/view.html.php       |  2 +-
 8 files changed, 43 insertions(+), 33 deletions(-)

diff --git a/module/my/control.php b/module/my/control.php
index 748fcb8c36..6f6d6827d3 100644
--- a/module/my/control.php
+++ b/module/my/control.php
@@ -1078,6 +1078,7 @@ class my extends control
         $this->session->set('opportunityLibList', $uri, 'assetlib');
         $this->session->set('practiceLibList',    $uri, 'assetlib');
         $this->session->set('componentLibList',   $uri, 'assetlib');
+        $this->session->set('opportunityList',    $uri, 'project');
 
         /* Set the pager. */
         $this->app->loadClass('pager', $static = true);
diff --git a/module/programplan/control.php b/module/programplan/control.php
index 8faba1e7c3..9eb751e67d 100644
--- a/module/programplan/control.php
+++ b/module/programplan/control.php
@@ -145,6 +145,7 @@ class programplan extends control
         $this->view->plans       = $this->programplan->getStage($planID ? $planID : $projectID, $this->productID, 'parent');
         $this->view->planID      = $planID;
         $this->view->type        = 'lists';
+        $this->view->PMUsers     = $this->loadModel('user')->getPairs('noclosed|nodeleted|pmfirst',  $project->PM);
 
         $this->display();
     }
diff --git a/module/programplan/js/create.js b/module/programplan/js/create.js
index 62a08dbd0e..cd4322931a 100644
--- a/module/programplan/js/create.js
+++ b/module/programplan/js/create.js
@@ -5,6 +5,8 @@ function addItem(obj)
     var newItem = $('#names' + i).closest('tr');
     newItem.find('.form-date').datepicker();
     $("#output" + i).chosen();
+    $("#PM_i__chosen").remove();
+    $("#PM" + i).chosen();
     $("#output_i__chosen").remove();
     i ++;
 }
diff --git a/module/programplan/lang/en.php b/module/programplan/lang/en.php
index 5a6a4ed3ab..0d93fbccb9 100644
--- a/module/programplan/lang/en.php
+++ b/module/programplan/lang/en.php
@@ -21,6 +21,7 @@ $lang->programplan->createSubPlan = 'Create Sub Stage';
 $lang->programplan->parent           = 'Parent Stage';
 $lang->programplan->emptyParent      = 'N/A';
 $lang->programplan->name             = 'Stage Name';
+$lang->programplan->PM               = 'Stage Manager';
 $lang->programplan->subStageName     = 'Sub Stage Name';
 $lang->programplan->percent          = 'Workload Ratio';
 $lang->programplan->percentAB        = 'Ratio';
diff --git a/module/programplan/lang/zh-cn.php b/module/programplan/lang/zh-cn.php
index ef8951ee19..69bebee6ad 100644
--- a/module/programplan/lang/zh-cn.php
+++ b/module/programplan/lang/zh-cn.php
@@ -21,6 +21,7 @@ $lang->programplan->createSubPlan = '创建二级阶段';
 $lang->programplan->parent           = '父阶段';
 $lang->programplan->emptyParent      = '无';
 $lang->programplan->name             = '阶段名称';
+$lang->programplan->PM               = '阶段负责人';
 $lang->programplan->subStageName     = '子阶段名称';
 $lang->programplan->percent          = '工作量占比';
 $lang->programplan->percentAB        = '工作量占比';
diff --git a/module/programplan/model.php b/module/programplan/model.php
index 321c3b8309..6cac0425b7 100644
--- a/module/programplan/model.php
+++ b/module/programplan/model.php
@@ -409,8 +409,6 @@ class programplanModel extends model
             $parentACL       = $parentStage->acl;
         }
 
-        $attributes = array_values($attributes);
-        $milestone  = array_values($milestone);
         $datas      = array();
         foreach($names as $key => $name)
         {
@@ -431,6 +429,7 @@ class programplanModel extends model
             $plan->realEnd   = empty($realEnd[$key]) ? '0000-00-00' : $realEnd[$key];
             $plan->output    = empty($output[$key]) ? '' : implode(',', $output[$key]);
             $plan->acl       = empty($parentID) ? $acl[$key] : $parentACL;
+            $plan->PM        = empty($PM[$key]) ? '' : $PM[$key];
 
             $datas[] = $plan;
         }
diff --git a/module/programplan/view/create.html.php b/module/programplan/view/create.html.php
index 98dfed8df9..812f4b8d97 100644
--- a/module/programplan/view/create.html.php
+++ b/module/programplan/view/create.html.php
@@ -45,6 +45,7 @@
       <thead>
         <tr class='text-center'>
           <th class='required'><?php echo $name;?></th>
+          <th class='w-110px'><?php echo $lang->programplan->PM;?></th>
           <th class='w-110px'>
             <?php echo $lang->programplan->percent;?>
             <?php if($planID):?>
@@ -69,20 +70,21 @@
         <?php if(empty($plans) and $planID == 0):?>
           <?php foreach($stages as $stage):?>
           <tr>
-            <td><input type='text' name='names[]' id='names<?php echo $i;?>' value='<?php echo $stage->name;?>' class='form-control' /></td>
+            <td><input type='text' name='names[<?php echo $i;?>]' id='names<?php echo $i;?>' value='<?php echo $stage->name;?>' class='form-control' /></td>
+            <td><?php echo html::select("PM[$i]", $PMUsers, '', "class='form-control chosen'");?></td>
             <td>
               <div class='input-group'>
-                <input type='text' name='percents[]' id='percent<?php echo $i;?>' value='<?php echo $stage->percent;?>' class='form-control'/>
+                <input type='text' name='percents[<?php echo $i;?>]' id='percent<?php echo $i;?>' value='<?php echo $stage->percent;?>' class='form-control'/>
                 <span class='input-group-addon'>%</span>
               </div>
             </td>
             <td class='<?php echo $hideAttribute?>'><?php echo html::select("attributes[$i]", $lang->stage->typeList, $stage->type, "class='form-control'");?></td>
-            <td><?php echo html::select("acl[]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
+            <td><?php echo html::select("acl[$i]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
             <td><?php echo html::radio("milestone[$i]", $lang->programplan->milestoneList, 0);?></td>
-            <td><input type='text' name='begin[]' id='begin<?php echo $i;?>' value='' class='form-control form-date' /></td>
-            <td><input type='text' name='end[]' id='end<?php echo $i;?>' value='' class='form-control form-date' /></td>
-            <td><input type='text' name='realBegan[]' id='realBegan<?php echo $i;?>' value='' class='form-control form-date' /></td>
-            <td><input type='text' name='realEnd[]' id='realEnd<?php echo $i;?>' value='' class='form-control form-date' /></td>
+            <td><input type='text' name='begin[<?php echo $i;?>]' id='begin<?php echo $i;?>' value='' class='form-control form-date' /></td>
+            <td><input type='text' name='end[<?php echo $i;?>]' id='end<?php echo $i;?>' value='' class='form-control form-date' /></td>
+            <td><input type='text' name='realBegan[<?php echo $i;?>]' id='realBegan<?php echo $i;?>' value='' class='form-control form-date' /></td>
+            <td><input type='text' name='realEnd[<?php echo $i;?>]' id='realEnd<?php echo $i;?>' value='' class='form-control form-date' /></td>
             <?php if(isset($this->config->qcVersion)):?>
             <td><?php echo html::select("output[$i][]", $documentList, '', "class='form-control chosen' multiple");?></td>
             <?php endif;?>
@@ -98,22 +100,23 @@
         <?php if(!empty($plans)):?>
           <?php foreach($plans as $plan):?>
           <?php $disabled = $plan->setMilestone ? '' : "disabled='disabled'"?>
-          <?php echo html::hidden('planIDList[]', $plan->id);?>
+          <?php echo html::hidden("planIDList[$i]", $plan->id);?>
           <tr>
-            <td><input type='text' name="names[]" id='names<?php echo $i;?>' value='<?php echo $plan->name;?>' class='form-control' /></td>
+            <td><input type='text' name="names[<?php echo $i;?>]" id='names<?php echo $i;?>' value='<?php echo $plan->name;?>' class='form-control' /></td>
+            <td><?php echo html::select("PM[$i]", $PMUsers, '', "class='form-control chosen'");?></td>
             <td>
               <div class='input-group'>
-                <input type='text' name='percents[]' id='percent<?php echo $i;?>' value='<?php echo $plan->percent;?>' class='form-control' />
+                <input type='text' name='percents[<?php echo $i;?>]' id='percent<?php echo $i;?>' value='<?php echo $plan->percent;?>' class='form-control' />
                 <span class='input-group-addon'>%</span>
               </div>
             </td>
             <td class='<?php echo $hideAttribute?>'><?php echo html::select("attributes[$i]", $lang->stage->typeList, $plan->attribute, "class='form-control'");?></td>
-            <td><?php echo html::select("acl[]", $lang->project->aclList, $plan->acl, "class='form-control' $class");?></td>
+            <td><?php echo html::select("acl[$i]", $lang->project->aclList, $plan->acl, "class='form-control' $class");?></td>
             <td><?php echo html::radio("milestone[$i]", $lang->programplan->milestoneList, $plan->milestone, $disabled);?></td>
-            <td><input type='text' name='begin[] ' id='begin<?php echo $i;?>' value='<?php echo $plan->begin;?>' class='form-control form-date' /></td>
-            <td><input type='text' name='end[]' id='end<?php echo $i;?>' value='<?php echo $plan->end;?>' class='form-control form-date' /></td>
-            <td><input type='text' name='realBegan[] ' id='realBegan<?php echo $i;?>' value='<?php echo $plan->realBegan;?>' class='form-control form-date' /></td>
-            <td><input type='text' name='realEnd[]' id='realEnd<?php echo $i;?>' value='<?php echo $plan->realEnd;?>' class='form-control form-date' /></td>
+            <td><input type='text' name='begin[<?php echo $i;?>] ' id='begin<?php echo $i;?>' value='<?php echo $plan->begin;?>' class='form-control form-date' /></td>
+            <td><input type='text' name='end[<?php echo $i;?>]' id='end<?php echo $i;?>' value='<?php echo $plan->end;?>' class='form-control form-date' /></td>
+            <td><input type='text' name='realBegan[<?php echo $i;?>] ' id='realBegan<?php echo $i;?>' value='<?php echo $plan->realBegan;?>' class='form-control form-date' /></td>
+            <td><input type='text' name='realEnd[<?php echo $i;?>]' id='realEnd<?php echo $i;?>' value='<?php echo $plan->realEnd;?>' class='form-control form-date' /></td>
             <?php if(isset($this->config->qcVersion)):?>
             <?php $option = empty($plan->output) ? 0 : explode(',', $plan->output);?>
             <td><?php echo html::select("output[$i][]", $documentList, $option, "class='form-control chosen' multiple");?></td>
@@ -128,20 +131,21 @@
 
         <?php for($j = 0; $j < 5; $j ++):?>
         <tr class='addedItem'>
-          <td><input type='text' name='names[]' id='names<?php echo $i;?>' value='' class='form-control' /></td>
+          <td><input type='text' name='names[<?php echo $i;?>]' id='names<?php echo $i;?>' value='' class='form-control' /></td>
+          <td><?php echo html::select("PM[$i]", $PMUsers, '', "class='form-control chosen'");?></td>
           <td>
             <div class='input-group'>
-              <input type='text' name='percents[]' id='percent<?php echo $i;?>' value='' class='form-control' />
+              <input type='text' name='percents[<?php echo $i;?>]' id='percent<?php echo $i;?>' value='' class='form-control' />
               <span class='input-group-addon'>%</span>
             </div>
           </td>
           <td class='<?php echo $hideAttribute?>'><?php echo html::select("attributes[$i]", $lang->stage->typeList, '', "class='form-control'");?></td>
-          <td><?php echo html::select("acl[]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
+          <td><?php echo html::select("acl[$i]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
           <td><?php echo html::radio("milestone[$i]", $lang->programplan->milestoneList, 0);?></td>
-          <td><input type='text' name='begin[] ' id='begin<?php echo $i;?>' value='' class='form-control form-date' /></td>
-          <td><input type='text' name='end[]' id='end<?php echo $i;?>' value='' class='form-control form-date' /></td>
-          <td><input type='text' name='realBegan[] ' id='realBegan<?php echo $i;?>' value='' class='form-control form-date' /></td>
-          <td><input type='text' name='realEnd[]' id='realEnd<?php echo $i;?>' value='' class='form-control form-date' /></td>
+          <td><input type='text' name='begin[<?php echo $i;?>] ' id='begin<?php echo $i;?>' value='' class='form-control form-date' /></td>
+          <td><input type='text' name='end[<?php echo $i;?>]' id='end<?php echo $i;?>' value='' class='form-control form-date' /></td>
+          <td><input type='text' name='realBegan[<?php echo $i;?>] ' id='realBegan<?php echo $i;?>' value='' class='form-control form-date' /></td>
+          <td><input type='text' name='realEnd[<?php echo $i;?>]' id='realEnd<?php echo $i;?>' value='' class='form-control form-date' /></td>
           <?php if(isset($this->config->qcVersion)):?>
           <td><?php echo html::select("output[$i][]", $documentList, '', "class='form-control chosen' multiple");?></td>
           <?php endif;?>
@@ -167,21 +171,22 @@
   <?php $i = '%i%';?>
   <table class='hidden'>
     <tr id='addItem' class='hidden'>
-      <td><input type='text' name='names[]' id='names<?php echo $i;?>' class='form-control' /></td>
-      <?php echo html::hidden('planIDList[]', 0);?>
+      <td><input type='text' name='<?php echo "names[$i]";?>' id='names<?php echo $i;?>' class='form-control' /></td>
+      <td><?php echo html::select("PM[$i]", $PMUsers, '', "class='form-control chosen' id='PM$i'");?></td>
+      <?php echo html::hidden("planIDList[$i]", 0);?>
       <td>
         <div class='input-group'>
-          <input type='text' name='percents[]' id='percent<?php echo $i;?>' class='form-control' />
+          <input type='text' name='<?php echo "percents[$i]";?>' id='percent<?php echo $i;?>' class='form-control' />
           <span class='input-group-addon'>%</span>
         </div>
       </td>
       <td class='<?php echo $hideAttribute?>'><?php echo html::select("attributes[$i]", $lang->stage->typeList, '', "class='form-control'");?></td>
-      <td><?php echo html::select("acl[]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
+      <td><?php echo html::select("acl[$i]", $lang->project->aclList, 'open', "class='form-control' $class");?></td>
       <td><?php echo html::radio("milestone[$i]", $lang->programplan->milestoneList, 0);?></td>
-      <td><input type='text' name='begin[] ' id='begin<?php echo $i;?>' class='form-control form-date' /></td>
-      <td><input type='text' name='end[]' id='end<?php echo $i;?>' class='form-control form-date' /></td>
-      <td><input type='text' name='realBegan[] ' id='realBegan<?php echo $i;?>' class='form-control form-date' /></td>
-      <td><input type='text' name='realEnd[]' id='realEnd<?php echo $i;?>' class='form-control form-date' /></td>
+      <td><input type='text' name='<?php echo "begin[$i]";?>' id='begin<?php echo $i;?>' class='form-control form-date' /></td>
+      <td><input type='text' name='<?php echo "end[$i]";?>' id='end<?php echo $i;?>' class='form-control form-date' /></td>
+      <td><input type='text' name='<?php echo "realBegan[$i]";?>' id='realBegan<?php echo $i;?>' class='form-control form-date' /></td>
+      <td><input type='text' name='<?php echo "realEnd[$i]";?>' id='realEnd<?php echo $i;?>' class='form-control form-date' /></td>
       <?php if(isset($this->config->qcVersion)):?>
       <td><?php echo html::select("output[$i][]", $documentList, '', "class='form-control chosen ' multiple");?></td>
       <?php endif;?>
diff --git a/module/project/view/view.html.php b/module/project/view/view.html.php
index 82cc615f3c..0285d8c651 100644
--- a/module/project/view/view.html.php
+++ b/module/project/view/view.html.php
@@ -193,7 +193,7 @@
                   </tr>
                   <tr>
                     <th><?php echo $lang->execution->totalEstimate;?></th>
-                    <td><?php echo (float)$workhour->totalEstimate . $lang->execution->workHour;?></td>                   
+                    <td><?php echo (float)$workhour->totalEstimate . $lang->execution->workHour;?></td>
                     <th><?php echo $lang->execution->totalDays;?></th>
                     <td><?php echo $project->days;?></td>
                   </tr>

From cc81db0ddcf360201282665a47059803b200f9f6 Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 08:24:38 +0800
Subject: [PATCH 02/22] * Finish task #46667.

---
 module/productplan/js/browse.js               | 30 +++++++++++++++----
 module/productplan/lang/en.php                |  4 ++-
 module/productplan/lang/zh-cn.php             |  1 +
 .../productplan/view/browsebykanban.html.php  | 11 +++++--
 4 files changed, 37 insertions(+), 9 deletions(-)

diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index 9bc95dee80..4e8afc1570 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -167,15 +167,23 @@ function changeCardColType(card, fromColType, toColType, kanbanID)
  */
 function renderKanbanItem(item, $item)
 {
-    var privs     = item.actions;
-    var $titleBox = $item.children('.titleBox');
+    var privs        = item.actions;
+    var printMoreBtn = privs.includes('view');
 
     /* Output header information. */
+    var $header = $item.children('.header');
+    if(!$header.length) $header = $(
+    [
+        '<div class="header">',
+        '</div>'
+    ].join('')).appendTo($item);
+
+    var $titleBox = $item.children('.titleBox');
     if(!$titleBox.length) $titleBox = $(
     [
         '<div class="titleBox">',
         '</div>'
-    ].join('')).appendTo($item);
+    ].join('')).appendTo($header);
 
     /* Print plan name. */
     var $title = $titleBox.children('.title');
@@ -190,15 +198,27 @@ function renderKanbanItem(item, $item)
     var today = new Date();
     var begin = $.zui.createDate(item.begin);
     var end   = $.zui.createDate(item.end);
-    if(end.toLocaleDateString() < today.toLocaleDateString())
+    if(end.toLocaleDateString() < today.toLocaleDateString() && (item.status == 'wait' || item.status == 'doing'))
     {
-        $expired = $titleBox.children('.expired');
+        $expired = $('.titleBox').children('.expired');
         if(!$expired.length)
         {
             $('<span class="expired label label-danger label-badge">' + productplanLang.expired + '</span>').appendTo($titleBox);
         }
     }
 
+    if(printMoreBtn)
+    {
+        $(
+        [
+            '<div class="actions" title="' + productplanLang.more + '">',
+              '<a data-contextmenu="card" data-id="' + item.id + '">',
+                '<i class="icon icon-ellipsis-v"></i>',
+              '</a>',
+            '</div>'
+        ].join('')).appendTo($header);
+    }
+
     /* Output plan date information. */
     var $dateBox = $item.children('.dateBox');
     if(!$dateBox.length) $dateBox = $(
diff --git a/module/productplan/lang/en.php b/module/productplan/lang/en.php
index 93d7bcbde9..404d8b8b92 100644
--- a/module/productplan/lang/en.php
+++ b/module/productplan/lang/en.php
@@ -18,12 +18,13 @@ $lang->productplan->delete     = "Delete Plan";
 $lang->productplan->start      = "Start Plan";
 $lang->productplan->finish     = "Finish Plan";
 $lang->productplan->close      = "Close Plan";
-$lang->productplan->activate   = "Activate Plan";
 $lang->productplan->startAB    = "Start";
 $lang->productplan->finishAB   = "Finish";
 $lang->productplan->closeAB    = "Close";
 $lang->productplan->activateAB = "Activate";
 $lang->productplan->view       = "Plan Detail";
+$lang->productplan->activate   = "Activate Plan";
+$lang->productplan->view       = "View";
 $lang->productplan->bugSummary = "Total <strong>%s</strong> Bugs on this page.";
 $lang->productplan->basicInfo  = 'Basic Info';
 $lang->productplan->batchEdit  = 'Batch Edit';
@@ -31,6 +32,7 @@ $lang->productplan->project    = 'Project';
 $lang->productplan->plan       = 'Plan';
 $lang->productplan->allAB      = 'All';
 $lang->productplan->to         = 'To';
+$lang->productplan->more       = 'More';
 
 $lang->productplan->batchUnlink      = "Batch Unlink";
 $lang->productplan->unlinkAB         = "Unlink";
diff --git a/module/productplan/lang/zh-cn.php b/module/productplan/lang/zh-cn.php
index b1da22b2d2..6006897542 100644
--- a/module/productplan/lang/zh-cn.php
+++ b/module/productplan/lang/zh-cn.php
@@ -32,6 +32,7 @@ $lang->productplan->project    = '项目';
 $lang->productplan->plan       = '计划';
 $lang->productplan->allAB      = '所有';
 $lang->productplan->to         = '至';
+$lang->productplan->more       = '更多操作';
 
 $lang->productplan->batchUnlink      = "批量移除";
 $lang->productplan->unlinkAB         = "移除";
diff --git a/module/productplan/view/browsebykanban.html.php b/module/productplan/view/browsebykanban.html.php
index 267561190c..42bbf6d51f 100644
--- a/module/productplan/view/browsebykanban.html.php
+++ b/module/productplan/view/browsebykanban.html.php
@@ -18,13 +18,18 @@
 #branchBox {width: 120px;}
 #branch_chosen .icon-delay {padding-right: 10px; font-size: 15px;}
 #kanbanContainer {padding-bottom: 0; margin-bottom: 0;}
+.kanban-item:hover > .header > .actions {opacity: 1;}
 .kanban-card {height: 80px !important;}
-.kanban-card .titleBox {width: 100%; display: flex;}
-.kanban-card .titleBox > span {flex: none;}
+.kanban-card .header .titleBox {display: flex; width: 90%; float: left;}
+.kanban-card .header .titleBox > span {flex: none;}
+.kanban-card .header .actions {float: right; opacity: 0;}
+.kanban-card .header .actions > a:hover {background-color: rgba(0,0,0,.075); opacity: 1;}
+.kanban-card:hover > .header > .actions {opacity: 1;}
 .kanban-card .title {white-space: nowrap; overflow: hidden;}
 .kanban-card .expired {margin-left: 2px;}
-.kanban-card .dateBox {padding-top: 5px;}
+.kanban-card .dateBox {padding-top: 22px;}
 .kanban-card .desc {overflow: hidden; text-overflow: ellipsis; white-space: nowrap; color: #838a9d; padding-top: 5px;}
+.kanban-card .actions > a {display: block; float: left; width: 20px; height: 20px; line-height: 20px; text-align: center; border-radius: 4px; opacity: .7;}
 </style>
 <?php js::set('kanbanData', $kanbanData);?>
 <?php js::set('productplanLang', $lang->productplan);?>

From 08723126ea0ede21bcd601533dcda075593cb746 Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 11:02:42 +0800
Subject: [PATCH 03/22] * Finish task #46672.

---
 module/kanban/model.php                       |  9 +-
 module/productplan/control.php                | 31 ++++---
 module/productplan/js/browse.js               | 87 ++++++++++++++++++-
 module/productplan/view/browse.html.php       | 31 +++++++
 .../productplan/view/browsebykanban.html.php  |  1 +
 module/productplan/view/browsebylist.html.php | 30 +------
 6 files changed, 144 insertions(+), 45 deletions(-)

diff --git a/module/kanban/model.php b/module/kanban/model.php
index d29ea2588f..ee6580f9be 100644
--- a/module/kanban/model.php
+++ b/module/kanban/model.php
@@ -537,7 +537,7 @@ class kanbanModel extends model
         $branches    = array();
         $colorIndex  = 0;
         $laneOrder   = 1;
-        $cardActions = array('view');
+        $cardActions = array('view', 'createExecution', 'linkStory', 'linkBug', 'edit', 'start', 'finish', 'close', 'activate');
 
         if($product->type == 'normal')
         {
@@ -573,7 +573,12 @@ class kanbanModel extends model
                 $plan->actions = array();
                 foreach($cardActions as $action)
                 {
-                    if(common::hasPriv('productplan', $action)) $plan->actions[] = $action;
+                    if($action == 'createExecution')
+                    {
+                        if(common::hasPriv('execution', 'create')) $plan->actions[] = $action;
+                        continue;
+                    }
+                    if($this->productplan->isClickable($plan, $action)) $plan->actions[] = $action;
                 }
                 $planList[$plan->status][] = $plan;
             }
diff --git a/module/productplan/control.php b/module/productplan/control.php
index 035d61cbea..56e9bd455a 100644
--- a/module/productplan/control.php
+++ b/module/productplan/control.php
@@ -252,8 +252,12 @@ class productplan extends control
         $viewType = $this->cookie->viewType ? $this->cookie->viewType : 'list';
 
         $this->commonAction($productID, $branch);
-        $product     = $this->product->getById($productID);
-        $productName = empty($product) ? '' : $product->name;
+        $product          = $this->product->getById($productID);
+        $productName      = empty($product) ? '' : $product->name;
+        $branchList       = $this->branch->getList($productID, 0, 'all');
+        $branchStatusList = array();
+        foreach($branchList as $productBranch) $branchStatusList[$productBranch->id] = $productBranch->status;
+
         if($viewType == 'kanban')
         {
             $branches    = array();
@@ -285,17 +289,18 @@ class productplan extends control
             $this->view->kanbanData = $this->loadModel('kanban')->getPlanKanban($product, $branchID, $planGroup);
         }
 
-        $this->view->title      = $productName . $this->lang->colon . $this->lang->productplan->browse;
-        $this->view->position[] = $this->lang->productplan->browse;
-        $this->view->productID  = $productID;
-        $this->view->branch     = $branch;
-        $this->view->browseType = $browseType;
-        $this->view->viewType   = $viewType;
-        $this->view->orderBy    = $orderBy;
-        $this->view->plans      = $this->productplan->getList($productID, $branch, $browseType, $pager, $sort);
-        $this->view->pager      = $pager;
-        $this->view->projects   = $this->product->getProjectPairsByProduct($productID, $branch);
-        $this->view->statusList = $this->lang->productplan->featureBar['browse'];
+        $this->view->title            = $productName . $this->lang->colon . $this->lang->productplan->browse;
+        $this->view->position[]       = $this->lang->productplan->browse;
+        $this->view->productID        = $productID;
+        $this->view->branch           = $branch;
+        $this->view->branchStatusList = $branchStatusList;
+        $this->view->browseType       = $browseType;
+        $this->view->viewType         = $viewType;
+        $this->view->orderBy          = $orderBy;
+        $this->view->plans            = $this->productplan->getList($productID, $branch, $browseType, $pager, $sort);
+        $this->view->pager            = $pager;
+        $this->view->projects         = $this->product->getProjectPairsByProduct($productID, $branch);
+        $this->view->statusList       = $this->lang->productplan->featureBar['browse'];
         $this->display();
     }
 
diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index 4e8afc1570..a114e35ecb 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -75,9 +75,94 @@ $(function()
         {
             $.zui.ContextMenu.hide();
         });
+
+        /* Init contextmenu */
+        $('#kanban').on('click', '[data-contextmenu]', function(event)
+        {
+            var $trigger    = $(this);
+            var menuType    = $trigger.data('contextmenu');
+            var menuCreator = window.menuCreators[menuType];
+            if(!menuCreator) return;
+
+            var options = $.extend({event: event, $trigger: $trigger}, $trigger.data());
+            var items = menuCreator(options);
+            if(!items || !items.length) return;
+
+            $.zui.ContextMenu.show(items, items.$options || {event: event});
+        });
     }
 });
 
+/* Define menu creators */
+window.menuCreators =
+{
+    card: createCardMenu
+};
+
+/**
+ * Create card menu.
+ *
+ * @param  object $options
+ * @access public
+ * @return array
+ */
+function createCardMenu(options)
+{
+    var card  = options.$trigger.closest('.kanban-item').data('item');
+    var privs = card.actions;
+    if(!privs.length) return [];
+
+    var items = [];
+    if(privs.includes('createExecution'))
+    {
+        var className     = '';
+        var executionLink = systemMode == 'new' ? '#projects' : createLink('execution', 'create', "projectID=0&executionID=0&copyExecutionID=0&plan=" + card.id + "&confirm=no&productID=" + productID);
+        var today         = new Date();
+        var end           = $.zui.createDate(card.end);
+        if(end.toLocaleDateString() < today.toLocaleDateString() && (card.status == 'wait' || card.status == 'doing'))
+        {
+            className = 'disabled';
+        }
+        else if(product.type != 'normal')
+        {
+            var branchStatus = branchStatusList[card.branch];
+            if(branchStatus == 'closed') className = 'disabled';
+        }
+
+        if(systemMode == 'new')
+        {
+            items.push({label: productplanLang.createExecution, icon: 'plus', url: executionLink, className: className, attrs: {'data-toggle': 'modal', 'onclick': 'getPlanID(this,' + card.branch + ')', 'data-id': card.id}});
+        }
+        else
+        {
+            items.push({label: productplanLang.createExecution, icon: 'plus', url: executionLink, className: className});
+        }
+    }
+
+    if(privs.includes('linkStory')) items.push({label: productplanLang.linkStory, icon: 'link', url: createLink('productplan', 'view', "planID=" + card.id + "&type=story&orderBy=id_desc&link=true")});
+    if(privs.includes('linkBug')) items.push({label: productplanLang.linkBug, icon: 'bug', url: createLink('productplan', 'view', "planID=" + card.id + "&type=bug&orderBy=id_desc&link=true")});
+    if(privs.includes('edit')) items.push({label: productplanLang.edit, icon: 'edit', url: createLink('productplan', 'edit', "planID=" + card.id)});
+    if(privs.includes('start'))
+    {
+        if(card.begin == '2030-01-01' || card.end == '2030-01-01')
+        {
+            items.push({label: productplanLang.start, icon: 'start', url: createLink('productplan', 'start', "planID=" + card.id, '', true), className: 'iframe', attrs: {'data-toggle': 'modal', 'data-id': card.id, 'data-width': '550px'}});
+        }
+        else
+        {
+            items.push({label: productplanLang.start, icon: 'start', url: createLink('productplan', 'start', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
+        }
+    }
+
+    if(privs.includes('finish')) items.push({label: productplanLang.finish, icon: 'checked', url: createLink('productplan', 'finish', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
+    if(privs.includes('close')) items.push({label: productplanLang.close, icon: 'off', url: createLink('productplan', 'close', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
+    if(privs.includes('activate')) items.push({label: productplanLang.activate, icon: 'magic', url: createLink('productplan', 'activate', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
+
+    var bounds = options.$trigger[0].getBoundingClientRect();
+    items.$options = {x: bounds.right, y: bounds.top};
+    return items;
+}
+
 $(document).on('click', 'td.content .more', function(e)
 {
     var $toggle = $(this);
@@ -168,7 +253,7 @@ function changeCardColType(card, fromColType, toColType, kanbanID)
 function renderKanbanItem(item, $item)
 {
     var privs        = item.actions;
-    var printMoreBtn = privs.includes('view');
+    var printMoreBtn = (privs.includes('createExecution') || privs.includes('linkStory') || privs.includes('linkBug') || privs.includes('edit') || privs.includes('start') || privs.includes('finish') || privs.includes('close') || privs.includes('activate'));
 
     /* Output header information. */
     var $header = $item.children('.header');
diff --git a/module/productplan/view/browse.html.php b/module/productplan/view/browse.html.php
index d29e415c8f..c206d4b389 100644
--- a/module/productplan/view/browse.html.php
+++ b/module/productplan/view/browse.html.php
@@ -18,6 +18,9 @@
 <?php js::set('enterProjectList', $lang->productplan->enterProjectList);?>
 <?php js::set('projectNotEmpty', $lang->productplan->projectNotEmpty)?>
 <?php js::set('viewType', $viewType);?>
+<?php js::set('product', $product);?>
+<?php js::set('systemMode', $config->systemMode);?>
+<?php js::set('branchStatusList', $branchStatusList);?>
 <?php
 if($viewType == 'kanban')
 {
@@ -28,4 +31,32 @@ else
     include 'browsebylist.html.php';
 }
 ?>
+<div class="modal fade" id="projects">
+  <div class="modal-dialog mw-500px">
+    <div class="modal-content">
+      <div class="modal-header">
+        <h4 class="modal-title"><?php echo $lang->productplan->selectProjects;?></h4>
+      </div>
+      <div class="modal-body">
+        <table class='table table-form'>
+          <tr>
+            <th><?php echo $lang->productplan->project?></th>
+            <td><?php echo html::select('project', $projects, '', "class='form-control chosen'");?></td>
+          </tr>
+          <tr class='tips hidden'>
+            <th></th>
+            <td><span class='text-red'><?php echo $lang->productplan->noLinkedProject;?></span></td>
+          </tr>
+          <tr>
+            <td colspan='2' class='text-center'>
+              <?php echo html::hidden('planID', '');?>
+              <?php echo html::commonButton($lang->productplan->nextStep, "id='createExecutionButton'", 'btn btn-primary btn-wide');?>
+              <?php echo html::commonButton($lang->cancel, "data-dismiss='modal'", 'btn btn-default btn-wide');?>
+            </td>
+          </tr>
+        </table>
+      </div>
+    </div>
+  </div>
+</div>
 <?php include '../../common/view/footer.html.php';?>
diff --git a/module/productplan/view/browsebykanban.html.php b/module/productplan/view/browsebykanban.html.php
index 42bbf6d51f..9048604fb6 100644
--- a/module/productplan/view/browsebykanban.html.php
+++ b/module/productplan/view/browsebykanban.html.php
@@ -30,6 +30,7 @@
 .kanban-card .dateBox {padding-top: 22px;}
 .kanban-card .desc {overflow: hidden; text-overflow: ellipsis; white-space: nowrap; color: #838a9d; padding-top: 5px;}
 .kanban-card .actions > a {display: block; float: left; width: 20px; height: 20px; line-height: 20px; text-align: center; border-radius: 4px; opacity: .7;}
+.dropdown-menu > li > .disabled {pointer-events: none; color: #838a9d;}
 </style>
 <?php js::set('kanbanData', $kanbanData);?>
 <?php js::set('productplanLang', $lang->productplan);?>
diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index e271775e94..96ba8f4bc7 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -163,7 +163,7 @@
 
               if($product->type != 'normal')
               {
-                  $branchStatus = $this->branch->getByID($plan->branch, 0, 'status');
+                  $branchStatus = isset($branchStatusList[$plan->branch]) ? $branchStatusList[$plan->branch] : '';
                   if($branchStatus == 'closed') $disabled = 'disabled';
               }
 
@@ -214,31 +214,3 @@
   </form>
   <?php endif;?>
 </div>
-<div class="modal fade" id="projects">
-  <div class="modal-dialog mw-500px">
-    <div class="modal-content">
-      <div class="modal-header">
-        <h4 class="modal-title"><?php echo $lang->productplan->selectProjects;?></h4>
-      </div>
-      <div class="modal-body">
-        <table class='table table-form'>
-          <tr>
-            <th><?php echo $lang->productplan->project?></th>
-            <td><?php echo html::select('project', $projects, '', "class='form-control chosen'");?></td>
-          </tr>
-          <tr class='tips hidden'>
-            <th></th>
-            <td><span class='text-red'><?php echo $lang->productplan->noLinkedProject;?></span></td>
-          </tr>
-          <tr>
-            <td colspan='2' class='text-center'>
-              <?php echo html::hidden('planID', '');?>
-              <?php echo html::commonButton($lang->productplan->nextStep, "id='createExecutionButton'", 'btn btn-primary btn-wide');?>
-              <?php echo html::commonButton($lang->cancel, "data-dismiss='modal'", 'btn btn-default btn-wide');?>
-            </td>
-          </tr>
-        </table>
-      </div>
-    </div>
-  </div>
-</div>

From ff35ce06cd001d9cf335a4c373fe471e8d20a0af Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 11:24:07 +0800
Subject: [PATCH 04/22] * Hide contextmenu when page scroll.

---
 module/productplan/js/browse.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index a114e35ecb..5b6e183368 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -91,6 +91,12 @@ $(function()
             $.zui.ContextMenu.show(items, items.$options || {event: event});
         });
     }
+
+    /* Hide contextmenu when page scroll */
+    $(window).on('scroll', function()
+    {
+        $.zui.ContextMenu.hide();
+    });
 });
 
 /* Define menu creators */

From 53aa3007447c272dac3be42b0b8f9e8e43efe4b9 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 11:25:57 +0800
Subject: [PATCH 05/22] * Add dynamic for parent plan status flow.

---
 module/action/model.php           |  4 +++
 module/productplan/control.php    | 15 ---------
 module/productplan/lang/en.php    |  8 +++++
 module/productplan/lang/zh-cn.php |  8 +++++
 module/productplan/model.php      | 54 ++++++++++++++++++++++++++++---
 5 files changed, 69 insertions(+), 20 deletions(-)

diff --git a/module/action/model.php b/module/action/model.php
index ddfeef63fe..ca1ef97a30 100755
--- a/module/action/model.php
+++ b/module/action/model.php
@@ -707,6 +707,10 @@ class actionModel extends model
             {
                 $desc = $this->lang->$objectType->action->rejectreviewed;
             }
+            elseif($action->objectType == 'productplan' and in_array($action->action, array('startedbychild','finishedbychild','closedbychild','activatedbychild')))
+            {
+                $desc = $this->lang->$objectType->action->changebychild;
+            }
             elseif(isset($this->config->maxVersion) and strpos($this->config->action->assetType, $action->objectType) !== false and $action->action == 'approved')
             {
                 $desc = empty($this->lang->action->approve->{$action->extra}) ? '' : $this->lang->action->approve->{$action->extra};
diff --git a/module/productplan/control.php b/module/productplan/control.php
index b83ddc255b..4e4720796a 100644
--- a/module/productplan/control.php
+++ b/module/productplan/control.php
@@ -403,9 +403,6 @@ class productplan extends control
                 $changes = $this->productplan->updateStatus($planID, 'doing');
                 if(dao::isError()) die(js::error(dao::getError()));
 
-                $actionID = $this->loadModel('action')->create('productplan', $planID, 'started');
-                $this->action->logHistory($actionID, $changes);
-
                 die(js::reload('parent'));
             }
         }
@@ -416,9 +413,6 @@ class productplan extends control
                 $changes = $this->productplan->updateStatus($planID, 'doing');
                 if(dao::isError()) return $this->send(array('result' => 'fail', 'message' => dao::getError()));
 
-                $actionID = $this->loadModel('action')->create('productplan', $planID, 'started');
-                $this->action->logHistory($actionID, $changes);
-
                 return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess,'locate' => 'parent'));
             }
             $this->view->plan = $plan;
@@ -445,9 +439,6 @@ class productplan extends control
             $changes = $this->productplan->updateStatus($planID, 'done');
             if(dao::isError()) die(js::error(dao::getError()));
 
-            $actionID = $this->loadModel('action')->create('productplan', $planID, 'finished');
-            $this->action->logHistory($actionID, $changes);
-
             die(js::reload('parent'));
         }
     }
@@ -471,9 +462,6 @@ class productplan extends control
             $changes = $this->productplan->updateStatus($planID, 'closed');
             if(dao::isError()) die(js::error(dao::getError()));
 
-            $actionID = $this->loadModel('action')->create('productplan', $planID, 'closed');
-            $this->action->logHistory($actionID, $changes);
-
             die(js::reload('parent'));
         }
     }
@@ -497,9 +485,6 @@ class productplan extends control
             $changes = $this->productplan->updateStatus($planID, 'doing');
             if(dao::isError()) die(js::error(dao::getError()));
 
-            $actionID = $this->loadModel('action')->create('productplan', $planID, 'activated');
-            $this->action->logHistory($actionID, $changes);
-
             die(js::reload('parent'));
         }
     }
diff --git a/module/productplan/lang/en.php b/module/productplan/lang/en.php
index 0d120879e2..dbd1b0c1e3 100644
--- a/module/productplan/lang/en.php
+++ b/module/productplan/lang/en.php
@@ -96,6 +96,11 @@ $lang->productplan->statusList['doing']  = 'Doing';
 $lang->productplan->statusList['done']   = 'Done';
 $lang->productplan->statusList['closed'] = 'Closed';
 
+$lang->productplan->parentActionList['startedbychild']   = '<strong>starting </strong>the productplan sets the plan status as <strong>Doing</strong>.';
+$lang->productplan->parentActionList['finishedbychild']  = '<strong>finishing </strong>all productplan sets the plan status as <strong>Done</strong>.';
+$lang->productplan->parentActionList['closedbychild']    = '<strong>closing </strong>all productplan sets the plan status as <strong>Closed</strong>.';
+$lang->productplan->parentActionList['activatedbychild'] = '<strong>activating </strong>the productplan sets the plan status as <strong>Doing</strong>.';
+
 $lang->productplan->endList[7]    = '1 Week';
 $lang->productplan->endList[14]   = '2 Weeks';
 $lang->productplan->endList[31]   = '1 Month';
@@ -120,3 +125,6 @@ $lang->productplan->featureBar['browse']['wait']   = 'Waiting';
 $lang->productplan->featureBar['browse']['doing']  = 'Doing';
 $lang->productplan->featureBar['browse']['done']   = 'Done';
 $lang->productplan->featureBar['browse']['closed'] = 'Closed';
+
+$lang->productplan->action = new stdclass();
+$lang->productplan->action->changebychild = array('main' => '$date, $extra', 'extra' => 'parentActionList');
diff --git a/module/productplan/lang/zh-cn.php b/module/productplan/lang/zh-cn.php
index a2e654e6b8..f307c00b52 100644
--- a/module/productplan/lang/zh-cn.php
+++ b/module/productplan/lang/zh-cn.php
@@ -96,6 +96,11 @@ $lang->productplan->statusList['doing']  = '进行中';
 $lang->productplan->statusList['done']   = '已完成';
 $lang->productplan->statusList['closed'] = '已关闭';
 
+$lang->productplan->parentActionList['startedbychild']   = '系统判断由于子计划 <strong>开始</strong> ，将计划状态置为 <strong>进行中</strong> 。';
+$lang->productplan->parentActionList['finishedbychild']  = '系统判断由于子计划 <strong>全部完成</strong> ，将计划状态置为 <strong>已完成</strong> 。';
+$lang->productplan->parentActionList['closedbychild']    = '系统判断由于子计划 <strong>全部关闭</strong> ，将计划状态置为 <strong>已关闭</strong> 。';
+$lang->productplan->parentActionList['activatedbychild'] = '系统判断由于子计划 <strong>激活</strong> ，将计划状态置为 <strong>进行中</strong> 。';
+
 $lang->productplan->endList[7]   = '一星期';
 $lang->productplan->endList[14]  = '两星期';
 $lang->productplan->endList[31]  = '一个月';
@@ -120,3 +125,6 @@ $lang->productplan->featureBar['browse']['wait']   = '未开始';
 $lang->productplan->featureBar['browse']['doing']  = '进行中';
 $lang->productplan->featureBar['browse']['done']   = '已完成';
 $lang->productplan->featureBar['browse']['closed'] = '已关闭';
+
+$lang->productplan->action = new stdclass();
+$lang->productplan->action->changebychild = array('main' => '$date, $extra', 'extra' => 'parentActionList');
diff --git a/module/productplan/model.php b/module/productplan/model.php
index 2b8b027fca..fbc4deb642 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -467,7 +467,7 @@ class productplanModel extends model
 
         if($oldPlan->parent > 0) $parentPlan = $this->getByID($oldPlan->parent);
         if(!empty($parentPlan->begin))
-        { 
+        {
             if($plan->begin < $parentPlan->begin) dao::$errors['begin'] = sprintf($this->lang->productplan->beginLetterParent, $parentPlan->begin);
         }
         if(!empty($parentPlan->end))
@@ -513,7 +513,11 @@ class productplanModel extends model
     {
         $planID  = (int)$planID;
         $oldPlan = $this->getByID($planID);
-        if($oldPlan->parent > 0) $parentPlan = $this->getByID($oldPlan->parent);
+        if($oldPlan->parent > 0)
+        {
+            $parentPlan   = $this->getByID($oldPlan->parent);
+            $parentChange = false;
+        }
 
         if($status == 'doing' and !empty($_POST))
         {
@@ -530,6 +534,7 @@ class productplanModel extends model
                 ->where('id')->eq($planID)
                 ->beginIF(isset($parentPlan))->orWhere('id')->eq($oldPlan->parent)->fi()
                 ->exec();
+            if($parentPlan->status != 'doing') $parentChange = true;
         }
         elseif($status == 'doing' and isset($parentPlan) and $parentPlan->status != 'doing')
         {
@@ -538,6 +543,7 @@ class productplanModel extends model
                 ->where('id')->eq($planID)
                 ->orWhere('id')->eq($oldPlan->parent)
                 ->exec();
+            if($parentPlan->status != 'doing') $parentChange = true;
         }
         elseif($status == 'done' and isset($parentPlan))
         {
@@ -551,6 +557,7 @@ class productplanModel extends model
                     break;
                 }
             }
+            if($parentDone) $parentChange = true;
             $this->dao->update(TABLE_PRODUCTPLAN)
                 ->set('`status`')->eq($status)
                 ->where('id')->eq($planID)
@@ -569,6 +576,7 @@ class productplanModel extends model
                     break;
                 }
             }
+            if($parentClosed) $parentChange = true;
             $this->dao->update(TABLE_PRODUCTPLAN)
                 ->set('`status`')->eq($status)
                 ->where('id')->eq($planID)
@@ -586,7 +594,43 @@ class productplanModel extends model
         if(dao::isError()) return false;
 
         if(!isset($plan)) $plan = $this->getByID($planID);
-        if(!dao::isError())return common::createChanges($oldPlan, $plan);
+        if(!dao::isError())
+        {
+            $method = $this->app->rawMethod;
+            if($method == 'start')
+            {
+                $action = 'started';
+                if($parentChange) $parentAction = 'startedbychild';
+            }
+            elseif($method == 'finish')
+            {
+                $action = 'finished';
+                if($parentChange) $parentAction = 'finishedbychild';
+            }
+            elseif($method == 'close')
+            {
+                $action = 'closed';
+                if($parentChange) $parentAction = 'closedbychild';
+            }
+            elseif($method == 'activate')
+            {
+                $action = 'activated';
+                if($parentChange) $parentAction = 'activatedbychild';
+            }
+
+            if(isset($action))
+            {
+                $changes = common::createChanges($oldPlan, $plan);
+                $actionID = $this->loadModel('action')->create('productplan', $planID, $action);
+                $this->action->loghistory($actionID, $changes);
+
+                if($parentChange)
+                {
+                    $parentChanges = array(array('field' => 'status', 'old' => $parentPlan->status, 'new' => $status, 'diff' => ''));
+                    $actionID      = $this->action->create('productplan', $oldPlan->parent, $parentAction, '', $parentAction);
+                }
+            }
+        }
     }
 
     /**
@@ -605,7 +649,7 @@ class productplanModel extends model
         $config   = HTMLPurifier_Config::createDefault();
         $config->set('Cache.DefinitionImpl', null);
         $purifier = new HTMLPurifier($config);
-        
+
         $plans = array();
         $extendFields = $this->getFlowExtendFields();
         foreach($data->id as $planID)
@@ -617,7 +661,7 @@ class productplanModel extends model
             $plan->begin  = $data->begin[$planID] == '' ? '2030-01-01' : $data->begin[$planID];
             $plan->end    = $data->end[$planID] == '' ? '2030-01-01' : $data->end[$planID];
             $plan->status = $data->status[$planID];
-            
+
             if($oldPlans[$planID]->parent > 0) $parentPlan = $this->getByID($oldPlans[$planID]->parent);
             if(!empty($parentPlan->begin))
             {

From 8436cbe443f7e0c1e8a3148c8b8c324cc23d0b39 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 11:34:27 +0800
Subject: [PATCH 06/22] * Modify judgment.

---
 module/productplan/model.php | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/module/productplan/model.php b/module/productplan/model.php
index fbc4deb642..2d9fca41e1 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -624,11 +624,7 @@ class productplanModel extends model
                 $actionID = $this->loadModel('action')->create('productplan', $planID, $action);
                 $this->action->loghistory($actionID, $changes);
 
-                if($parentChange)
-                {
-                    $parentChanges = array(array('field' => 'status', 'old' => $parentPlan->status, 'new' => $status, 'diff' => ''));
-                    $actionID      = $this->action->create('productplan', $oldPlan->parent, $parentAction, '', $parentAction);
-                }
+                if($parentChange) $actionID = $this->action->create('productplan', $oldPlan->parent, $parentAction, '', $parentAction);
             }
         }
     }

From 97ea32f7c36fa7002857ed9313e0c98aab3431b2 Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 13:49:49 +0800
Subject: [PATCH 07/22] * Modify the mutual test question.

---
 module/productplan/js/browse.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index 5b6e183368..aac308c533 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -134,6 +134,10 @@ function createCardMenu(options)
             var branchStatus = branchStatusList[card.branch];
             if(branchStatus == 'closed') className = 'disabled';
         }
+        else if(card.status == 'done' || card.status == 'closed')
+        {
+            className = 'disabled';
+        }
 
         if(systemMode == 'new')
         {
@@ -291,7 +295,7 @@ function renderKanbanItem(item, $item)
     var end   = $.zui.createDate(item.end);
     if(end.toLocaleDateString() < today.toLocaleDateString() && (item.status == 'wait' || item.status == 'doing'))
     {
-        $expired = $('.titleBox').children('.expired');
+        $expired = $titleBox.children('.expired');
         if(!$expired.length)
         {
             $('<span class="expired label label-danger label-badge">' + productplanLang.expired + '</span>').appendTo($titleBox);

From 05a75e70399676baf241e73d4e01bdabebf1bd36 Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Thu, 30 Dec 2021 05:50:50 +0000
Subject: [PATCH 08/22] Finish task #46674.

---
 module/project/config.php                | 34 ++++++++++++++++
 module/project/control.php               |  5 +++
 module/project/lang/zh-cn.php            |  2 +
 module/project/lang/zh-tw.php            |  2 +
 module/project/model.php                 | 50 ++++++++++++++++++++++++
 module/project/view/createguide.html.php |  7 ++++
 module/project/view/edit.html.php        |  5 ++-
 7 files changed, 104 insertions(+), 1 deletion(-)

diff --git a/module/project/config.php b/module/project/config.php
index 524a86f476..b2d37e3597 100644
--- a/module/project/config.php
+++ b/module/project/config.php
@@ -129,3 +129,37 @@ $config->project->removePriv['project']   = array('index', 'browse', 'kanban', '
 $config->project->removePriv['bug']       = array('batchChangePlan');
 $config->project->removePriv['doc']       = array('catalog', 'index');
 $config->project->removePriv['auditplan'] = array('delete');
+
+$config->project->checkList = new stdclass();
+
+$config->project->checkList->scrum                     = new stdclass();
+$config->project->checkList->scrum->execution          = defined('TABLE_EXECUTION') ? TABLE_EXECUTION : '';
+$config->project->checkList->scrum->bug                = defined('TABLE_BUG') ? TABLE_BUG : '';
+$config->project->checkList->scrum->case               = defined('TABLE_CASE') ? TABLE_CASE : '';
+$config->project->checkList->scrum->issue              = defined('TABLE_ISSUE') ? TABLE_ISSUE : '';
+$config->project->checkList->scrum->risk               = defined('TABLE_RISK') ? TABLE_RISK : '';
+$config->project->checkList->scrum->testtask           = defined('TABLE_TESTTASK') ? TABLE_TESTTASK : '';
+$config->project->checkList->scrum->doc                = defined('TABLE_DOC') ? TABLE_DOC : '';
+$config->project->checkList->scrum->build              = defined('TABLE_BUILD') ? TABLE_BUILD : '';
+$config->project->checkList->scrum->projectrelease     = defined('TABLE_RELEASE') ? TABLE_RELEASE : '';
+$config->project->checkList->scrum->meeting            = defined('TABLE_MEETING') ? TABLE_MEETING : '';
+
+$config->project->checkList->waterfall                 = new stdclass();
+$config->project->checkList->waterfall->stage          = defined('TABLE_EXECUTION') ? TABLE_EXECUTION : '';
+$config->project->checkList->waterfall->design         = defined('TABLE_DESIGN') ? TABLE_DESIGN : '';
+$config->project->checkList->waterfall->doc            = defined('TABLE_DOC') ? TABLE_DOC : '';
+$config->project->checkList->waterfall->bug            = defined('TABLE_BUG') ? TABLE_BUG : '';
+$config->project->checkList->waterfall->case           = defined('TABLE_CASE') ? TABLE_CASE : '';
+$config->project->checkList->waterfall->build          = defined('TABLE_BUILD') ? TABLE_BUILD : '';
+$config->project->checkList->waterfall->projectrelease = defined('TABLE_RELEASE') ? TABLE_RELEASE : '';
+$config->project->checkList->waterfall->testtask       = defined('TABLE_TESTTASK') ? TABLE_TESTTASK : '';
+
+$config->project->checkList->waterfall->review         = defined('TABLE_REVIEW') ? TABLE_REVIEW : '';
+$config->project->checkList->waterfall->build          = defined('TABLE_BUILD') ? TABLE_BUILD : '';
+$config->project->checkList->waterfall->researchplan   = defined('TABLE_RESEARCHPLAN') ? TABLE_RESEARCHPLAN : '';
+$config->project->checkList->waterfall->issue          = defined('TABLE_ISSUE') ? TABLE_ISSUE : '';
+$config->project->checkList->waterfall->risk           = defined('TABLE_RISK') ? TABLE_RISK : '';
+$config->project->checkList->waterfall->opportunity    = defined('TABLE_OPPORTUNITY') ? TABLE_OPPORTUNITY : '';
+$config->project->checkList->waterfall->auditplan      = defined('TABLE_AUDITPLAN') ? TABLE_AUDITPLAN : '';
+$config->project->checkList->waterfall->gapanalysis    = defined('TABLE_GAPANALYSIS') ? TABLE_GAPANALYSIS : '';
+$config->project->checkList->waterfall->meeting        = defined('TABLE_MEETING') ? TABLE_MEETING : '';
diff --git a/module/project/control.php b/module/project/control.php
index 3b138f6170..8bd948555d 100644
--- a/module/project/control.php
+++ b/module/project/control.php
@@ -593,6 +593,9 @@ class project extends control
             }
         }
 
+        $canChangeModel = $this->project->checkCanChangeModel($projectID, $project->model);
+        $disableModel = $canChangeModel == true ? '' : 'disabled';
+
         $this->view->title      = $this->lang->project->edit;
         $this->view->position[] = $this->lang->project->edit;
 
@@ -617,6 +620,8 @@ class project extends control
         $this->view->parentProgram            = $this->program->getByID($project->parent);
         $this->view->availableBudget          = $this->program->getBudgetLeft($parentProject) + (float)$project->budget;
         $this->view->budgetUnitList           = $this->project->getBudgetUnitList();
+        $this->view->model                    = $project->model;
+        $this->view->disableModel             = $disableModel;
 
         $this->display();
     }
diff --git a/module/project/lang/zh-cn.php b/module/project/lang/zh-cn.php
index 643d7f02d8..f5bd231ae8 100644
--- a/module/project/lang/zh-cn.php
+++ b/module/project/lang/zh-cn.php
@@ -271,6 +271,8 @@ $lang->project->childLongTime          = "子项目中有长期项目，父项
 $lang->project->readjustTime           = '重新调整项目起止时间';
 $lang->project->notAllowRemoveProducts = "该产品中的需求与项目进行了关联或者项目下的{$lang->execution->common}关联了该产品，请取消关联后再操作。";
 $lang->project->ge                     = "『%s』应当不小于实际开始时间『%s』。";
+$lang->project->kanban                 = "看板";
+$lang->project->kanbanTitle            = "看板项目管理";
 
 $lang->project->programTitle['0']    = '不显示';
 $lang->project->programTitle['base'] = '只显示一级项目集';
diff --git a/module/project/lang/zh-tw.php b/module/project/lang/zh-tw.php
index da49a6d435..8f616b504b 100644
--- a/module/project/lang/zh-tw.php
+++ b/module/project/lang/zh-tw.php
@@ -271,6 +271,8 @@ $lang->project->childLongTime          = "子項目中有長期項目，父項
 $lang->project->readjustTime           = '重新調整項目起止時間';
 $lang->project->notAllowRemoveProducts = "該產品中的需求與項目進行了關聯或者項目下的{$lang->execution->common}關聯了該產品，請取消關聯後再操作。";
 $lang->project->ge                     = "『%s』應當不小於實際開始時間『%s』。";
+$lang->project->kanban                 = "看板";
+$lang->project->kanbanTitle            = "看板项目管理";
 
 $lang->project->programTitle['0']    = '不顯示';
 $lang->project->programTitle['base'] = '只顯示一級項目集';
diff --git a/module/project/model.php b/module/project/model.php
index 7993bec39c..3f974baf4f 100644
--- a/module/project/model.php
+++ b/module/project/model.php
@@ -2086,4 +2086,54 @@ class projectModel extends model
         if(!$this->common->isOpenMethod($moduleName, $methodName) and !commonModel::hasPriv($moduleName, $methodName)) $this->common->deny($moduleName, $methodName, false);
         common::setMenuVars('project', $objectID);
     }
+
+    /**
+     * Check if the project model can be changed.
+     *
+     * @param  int    $projectID
+     * @param  string $model
+     * @access public
+     * @return bool
+     */
+    public function checkCanChangeModel($projectID, $model)
+    {
+        $checkList = $this->config->project->checkList->$model;
+        foreach($checkList as $table)
+        {
+            $object = '';
+            if($table == '') continue;
+            if($table == TABLE_EXECUTION and $model == 'scrum')
+            {
+                $object = $this->fetchByProject($table, $projectID, 'sprint');
+            }
+            elseif($table == TABLE_EXECUTION and $model == 'waterfall')
+            {
+                $object = $this->fetchByProject($table, $projectID, 'stage');
+            }
+            else
+            {
+                $object = $this->fetchByProject($table, $projectID);
+            }
+            if(!empty($object)) return false;
+        }
+        return true;
+    }
+
+    /**
+     * Get the objects under the project.
+     *
+     * @param  constant $table
+     * @param  int      $projectID
+     * @param  string   $type
+     * @access public
+     * @return object
+     */
+    public function fetchByProject($table, $projectID, $type = '')
+    {
+        $result = $this->dao->select('*')->from($table)
+            ->where('project')->eq($projectID)
+            ->beginIF(!empty($type))->andWhere('type')->eq($type)->fi()
+            ->fetch();
+        return $result;
+    }
 }
diff --git a/module/project/view/createguide.html.php b/module/project/view/createguide.html.php
index 316e6ac81a..3c54ea68f6 100644
--- a/module/project/view/createguide.html.php
+++ b/module/project/view/createguide.html.php
@@ -29,6 +29,13 @@
             <p><?php echo $lang->project->waterfallTitle; ?></p>
           </div>
         </div>
+        <div class='col-xs-6'>
+          <div class='project-type text-center'>
+            <?php echo html::a($this->createLink("project", "create", "model=kanban&programID=$programID&copyProjectID=0&extra=productID=$productID,branchID=$branchID"), "<img class='project-type-img' data-type='waterfall' src='{$config->webRoot}theme/default/images/main/waterfall.png'>", '', "data-app='project' class='createButton'")?>
+            <h3><?php echo $lang->project->kanban; ?></h3>
+            <p><?php echo $lang->project->kanbanTitle; ?></p>
+          </div>
+        </div>
       </div>
     </div>
   </div>
diff --git a/module/project/view/edit.html.php b/module/project/view/edit.html.php
index bd007d5e87..c72e8566a5 100644
--- a/module/project/view/edit.html.php
+++ b/module/project/view/edit.html.php
@@ -34,6 +34,10 @@
     </div>
     <form class='form-indicator main-form form-ajax' method='post' target='hiddenwin' id='dataform'>
       <table class='table table-form'>
+        <tr>
+          <th><?php echo $lang->project->model;?></th>
+          <td><?php echo html::select('model', $lang->project->modelList, $model, "class='form-control chosen' required $disableModel");?></td>
+        </tr>
         <tr>
           <th class='w-120px'><?php echo $lang->program->parent;?></th>
           <?php
@@ -183,7 +187,6 @@
         <tr>
           <td colspan='4' class='text-center form-actions'>
             <?php
-              echo html::hidden('model', $project->model);
               echo html::submitButton();
               if(!isonlybody()) echo html::backButton();
             ?>

From 4d56aa8bdcd5f7d45f04a2375d6970bd3b1e6a68 Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 14:02:55 +0800
Subject: [PATCH 09/22] * Add card drop-down operation.

---
 module/kanban/model.php         | 2 +-
 module/productplan/js/browse.js | 5 +++--
 module/productplan/model.php    | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/module/kanban/model.php b/module/kanban/model.php
index ee6580f9be..d13038a88d 100644
--- a/module/kanban/model.php
+++ b/module/kanban/model.php
@@ -537,7 +537,7 @@ class kanbanModel extends model
         $branches    = array();
         $colorIndex  = 0;
         $laneOrder   = 1;
-        $cardActions = array('view', 'createExecution', 'linkStory', 'linkBug', 'edit', 'start', 'finish', 'close', 'activate');
+        $cardActions = array('view', 'createExecution', 'linkStory', 'linkBug', 'edit', 'start', 'finish', 'close', 'activate', 'delete');
 
         if($product->type == 'normal')
         {
diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index aac308c533..7a4dbda12c 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -167,6 +167,7 @@ function createCardMenu(options)
     if(privs.includes('finish')) items.push({label: productplanLang.finish, icon: 'checked', url: createLink('productplan', 'finish', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
     if(privs.includes('close')) items.push({label: productplanLang.close, icon: 'off', url: createLink('productplan', 'close', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
     if(privs.includes('activate')) items.push({label: productplanLang.activate, icon: 'magic', url: createLink('productplan', 'activate', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
+    if(privs.includes('delete')) items.push({label: productplanLang.delete, icon: 'trash', url: createLink('productplan', 'delete', "planID=" + card.id), attrs: {'target': 'hiddenwin'}});
 
     var bounds = options.$trigger[0].getBoundingClientRect();
     items.$options = {x: bounds.right, y: bounds.top};
@@ -263,7 +264,7 @@ function changeCardColType(card, fromColType, toColType, kanbanID)
 function renderKanbanItem(item, $item)
 {
     var privs        = item.actions;
-    var printMoreBtn = (privs.includes('createExecution') || privs.includes('linkStory') || privs.includes('linkBug') || privs.includes('edit') || privs.includes('start') || privs.includes('finish') || privs.includes('close') || privs.includes('activate'));
+    var printMoreBtn = (privs.includes('createExecution') || privs.includes('linkStory') || privs.includes('linkBug') || privs.includes('edit') || privs.includes('start') || privs.includes('finish') || privs.includes('close') || privs.includes('activate') || privs.includes('delete'));
 
     /* Output header information. */
     var $header = $item.children('.header');
@@ -285,7 +286,7 @@ function renderKanbanItem(item, $item)
     if(!$title.length)
     {
         if(privs.includes('view')) $title = $('<a class="title"></a>').appendTo($titleBox).attr('href', createLink('productplan', 'view', 'cardID=' + item.id));
-        if(!privs.includes('view')) $title = $('<p class="title"></p>').appendTo($titleBox);
+        if(!privs.includes('view')) $title = $('<a class="title"></a>').appendTo($titleBox);
     }
     $title.text(item.title).attr('title', item.title);
 
diff --git a/module/productplan/model.php b/module/productplan/model.php
index 2d9fca41e1..efc2fd08d8 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -959,7 +959,7 @@ class productplanModel extends model
                 if($plan->status != 'done' or $plan->parent < 0) return false;
                 break;
             case 'activate' :
-                if($plan->status != 'closed' or $plan->parent < 0) return false;
+                if($plan->status == 'wait' or $plan == 'doing' or $plan->parent < 0) return false;
                 break;
         }
 

From 6b8e4630ba18a26f82192d7f5a3ea78d46a937ca Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 14:23:37 +0800
Subject: [PATCH 10/22] * Fix bug for task #46654.

---
 module/productplan/css/browse.css             |  2 +-
 module/productplan/model.php                  | 20 +++++++++++--------
 module/productplan/view/browsebylist.html.php | 15 ++++++++++----
 module/productplan/view/view.html.php         |  5 +++--
 4 files changed, 27 insertions(+), 15 deletions(-)

diff --git a/module/productplan/css/browse.css b/module/productplan/css/browse.css
index d9750bbb47..154e628e50 100644
--- a/module/productplan/css/browse.css
+++ b/module/productplan/css/browse.css
@@ -18,7 +18,7 @@ td.c-branch {overflow: hidden; text-align: left !important; text-overflow: ellip
 .c-title {width: 160px;}
 .c-branch {width: 100px;}
 .c-story {width: 80px;}
-.c-execution {width: 120px;}
+.c-execution {width: 50px !important;}
 .c-bug, .c-hour {width: 60px;}
 
 .plan-name {position: relative; display: flex; align-items: center;}
diff --git a/module/productplan/model.php b/module/productplan/model.php
index 2d9fca41e1..b67c2a7a76 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -532,9 +532,13 @@ class productplanModel extends model
                 ->batchCheck($this->config->productplan->start->requiredFields, 'notempty')
                 ->checkIF(!empty($_POST['begin']) && !empty($_POST['end']), 'end', 'ge', $plan->begin)
                 ->where('id')->eq($planID)
-                ->beginIF(isset($parentPlan))->orWhere('id')->eq($oldPlan->parent)->fi()
                 ->exec();
-            if($parentPlan->status != 'doing') $parentChange = true;
+
+            if(isset($parentPlan) and $parentPlan->status != 'doing')
+            {
+                $this->dao->update(TABLE_PRODUCTPLAN)->set('status')->eq($status)->where('id')->eq($oldPlan->parent)->exec();
+                $parentChange = true;
+            }
         }
         elseif($status == 'doing' and isset($parentPlan) and $parentPlan->status != 'doing')
         {
@@ -719,17 +723,17 @@ class productplanModel extends model
             $maxEnd     = $end;
             foreach($childPlans as $childPlan)
             {
-                if($childPlan->begin < $minBegin) $minBegin = $childPlan->begin;
-                if($childPlan->end > $maxEnd) $maxEnd = $childPlan->end;
+                if($childPlan->begin < $minBegin and $minBegin != '2030-01-01') $minBegin = $childPlan->begin;
+                if($childPlan->end > $maxEnd and $maxEnd != '2030-01-01') $maxEnd = $childPlan->end;
             }
-            if($minBegin < $begin) dao::$errors['begin'] = sprintf($this->lang->beginGreaterChild, $minBegin);
-            if($maxEnd > $end) dao::$errors['end'] = sprintf($this->lang->endLetterChild, $maxEnd);
+            if($minBegin < $begin and $begin != '2030-01-01') dao::$errors['begin'] = sprintf($this->lang->beginGreaterChild, $minBegin);
+            if($maxEnd > $end and $end != '2030-01-01') dao::$errors['end'] = sprintf($this->lang->endLetterChild, $maxEnd);
         }
         elseif($plan->parent > 0)
         {
             $parentPlan = $this->getByID($plan->parent);
-            if($begin < $parentPlan->begin) dao::$errors['begin'] = sprintf($this->lang->productplan->beginLetterParent, $parentPlan->begin);
-            if($end > $parentPlan->end) dao::$errors['end'] = sprintf($this->lang->productplan->endGreaterParent, $parentPlan->end);
+            if($begin < $parentPlan->begin and $parentPlan->begin != '2030-01-01') dao::$errors['begin'] = sprintf($this->lang->productplan->beginLetterParent, $parentPlan->begin);
+            if($end > $parentPlan->end and $parentPlan->end != '2030-01-01') dao::$errors['end'] = sprintf($this->lang->productplan->endGreaterParent, $parentPlan->end);
         }
     }
 
diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index 96ba8f4bc7..9563308bb9 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -78,6 +78,7 @@
       </thead>
       <tbody>
       <?php $this->loadModel('file');?>
+      <?php $today = date('Y-m-d');?>
       <?php foreach($plans as $plan):?>
       <?php
       $canBeChanged = common::canBeChanged('plan', $plan);
@@ -113,8 +114,8 @@
         <td class='c-title text-left<?php if($plan->parent == '-1') echo ' has-child';?>' title="<?php echo $plan->title?>">
           <?php
           $suffix = '';
-          if($plan->end < helper::now()) $suffix = "<span class='label label-danger label-badge'>{$this->lang->productplan->expired}</span>";
-          if($plan->parent == '-1') $suffix .= '<a class="task-toggle" data-id="' . $plan->id . '"><i class="icon icon-angle-double-right"></i></a>';
+          if($plan->end < $today and in_array($plan->status, array('wait', 'doing'))) $suffix = "<span class='label label-danger label-badge'>{$this->lang->productplan->expired}</span>";
+          if($plan->parent == '-1' and isset($plan->children)) $suffix .= '<a class="task-toggle" data-id="' . $plan->id . '"><i class="icon icon-angle-double-right"></i></a>';
           if(!empty($suffix)) echo '<div class="plan-name has-prefix has-suffix">';
           echo html::a(inlink('view', "id=$plan->id"), $plan->title);
           if(!empty($suffix)) echo $suffix . '</div>';
@@ -181,8 +182,14 @@
           common::printIcon('productplan', 'edit', "planID=$plan->id", $plan, 'list');
           if(common::hasPriv('productplan', 'create', $plan))
           {
-              if($plan->parent > '0') echo "<button type='button' class='disabled btn'><i class='disabled icon-split' title='{$this->lang->productplan->children}'></i></button> ";
-              if($plan->parent <= '0') echo html::a($this->createLink('productplan', 'create', "product=$productID&branch=$branch&parent={$plan->id}"), "<i class='icon-split'></i>", '', "class='btn' title='{$this->lang->productplan->children}'");
+              if($plan->parent > '0' or in_array($plan->status, array('done', 'closed')))
+              {
+                  echo "<button type='button' class='disabled btn'><i class='disabled icon-split' title='{$this->lang->productplan->children}'></i></button> ";
+              }
+              else
+              {
+                  echo html::a($this->createLink('productplan', 'create', "product=$productID&branch=$branch&parent={$plan->id}"), "<i class='icon-split'></i>", '', "class='btn' title='{$this->lang->productplan->children}'");
+              }
           }
 
           if(common::hasPriv('productplan', 'delete', $plan))
diff --git a/module/productplan/view/view.html.php b/module/productplan/view/view.html.php
index d891801f4b..7423ce1262 100644
--- a/module/productplan/view/view.html.php
+++ b/module/productplan/view/view.html.php
@@ -59,11 +59,12 @@
             common::printLink('productplan', 'finish', "planID=$plan->id", "<i class='icon-checked'></i>{$lang->productplan->finishAB}", '', "class='btn btn-link {$class}' target='hiddenwin' title='{$lang->productplan->finish}'", '', false, $plan);
             $class = $plan->status == 'done' ? '' : 'disabled';
             common::printLink('productplan', 'close', "planID=$plan->id", "<i class='icon-off'></i>{$lang->productplan->closeAB}", '', "class='btn btn-link {$class}' target='hiddenwin' title='{$lang->productplan->close}'", '', false, $plan);
-            $class = $plan->status == 'closed' ? '' : 'disabled';
+            $class = in_array($plan->status, array('closed', 'done')) ? '' : 'disabled';
             common::printLink('productplan', 'activate', "planID=$plan->id", "<i class='icon-magic'></i>{$lang->productplan->activateAB}", '', "class='btn btn-link {$class}' target='hiddenwin' title='{$lang->productplan->activate}'", '', false, $plan);
         }
 
-        if(common::hasPriv('productplan', 'create', $plan) and $plan->parent <= '0') echo html::a($this->createLink('productplan', 'create', "product={$plan->product}&branch={$plan->branch}&parent={$plan->id}"), "<i class='icon-split'></i> " . $this->lang->productplan->children , '', "class='btn btn-link' title='{$this->lang->productplan->children}'");
+        $class = in_array($plan->status, array('done', 'closed')) ? 'disabled' : '';
+        if(common::hasPriv('productplan', 'create', $plan) and $plan->parent <= '0') echo html::a($this->createLink('productplan', 'create', "product={$plan->product}&branch={$plan->branch}&parent={$plan->id}"), "<i class='icon-split'></i> " . $this->lang->productplan->children , '', "class='btn btn-link {$class}' title='{$this->lang->productplan->children}'");
         if(common::hasPriv('productplan', 'edit', $plan)) echo html::a($this->createLink('productplan', 'edit', "planID=$plan->id"), "<i class='icon-common-edit icon-edit'></i> " . $this->lang->edit, '', "class='btn btn-link' title='{$this->lang->edit}'");
         if(common::hasPriv('productplan', 'delete', $plan) and $plan->parent >= 0) echo html::a($this->createLink('productplan', 'delete', "planID=$plan->id"), "<i class='icon-common-delete icon-trash'></i> " . $this->lang->delete, '', "class='btn btn-link' title='{$this->lang->delete}' target='hiddenwin'");
     }

From 344682bf7b6ee8f8764597f8a306a395547ba599 Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Thu, 30 Dec 2021 06:25:22 +0000
Subject: [PATCH 11/22] Delete createguide of kanban,change cmmi to waterfall.

---
 module/project/lang/en.php               | 4 ++--
 module/project/lang/zh-cn.php            | 2 --
 module/project/lang/zh-tw.php            | 2 --
 module/project/view/createguide.html.php | 7 -------
 4 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/module/project/lang/en.php b/module/project/lang/en.php
index b47bca0d24..7d276d2813 100644
--- a/module/project/lang/en.php
+++ b/module/project/lang/en.php
@@ -259,8 +259,8 @@ $lang->project->membersUnit            = '%s men';
 $lang->project->lastIteration          = "Recent {$lang->executionCommon}";
 $lang->project->ongoingStage           = 'Ongoing stage';
 $lang->project->scrum                  = 'Scrum';
-$lang->project->waterfall              = 'CMMI';
-$lang->project->waterfallTitle         = 'CMMI';
+$lang->project->waterfall              = 'Waterfall';
+$lang->project->waterfallTitle         = 'Waterfall project management';
 $lang->project->cannotCreateChild      = 'It is not empty, so you cannot add a child. You can add a parent for it, and then create a child.';
 $lang->project->confirmDelete          = "Do you want to delete [%s]?";
 $lang->project->emptyPM                = 'No manager';
diff --git a/module/project/lang/zh-cn.php b/module/project/lang/zh-cn.php
index f5bd231ae8..643d7f02d8 100644
--- a/module/project/lang/zh-cn.php
+++ b/module/project/lang/zh-cn.php
@@ -271,8 +271,6 @@ $lang->project->childLongTime          = "子项目中有长期项目，父项
 $lang->project->readjustTime           = '重新调整项目起止时间';
 $lang->project->notAllowRemoveProducts = "该产品中的需求与项目进行了关联或者项目下的{$lang->execution->common}关联了该产品，请取消关联后再操作。";
 $lang->project->ge                     = "『%s』应当不小于实际开始时间『%s』。";
-$lang->project->kanban                 = "看板";
-$lang->project->kanbanTitle            = "看板项目管理";
 
 $lang->project->programTitle['0']    = '不显示';
 $lang->project->programTitle['base'] = '只显示一级项目集';
diff --git a/module/project/lang/zh-tw.php b/module/project/lang/zh-tw.php
index 8f616b504b..da49a6d435 100644
--- a/module/project/lang/zh-tw.php
+++ b/module/project/lang/zh-tw.php
@@ -271,8 +271,6 @@ $lang->project->childLongTime          = "子項目中有長期項目，父項
 $lang->project->readjustTime           = '重新調整項目起止時間';
 $lang->project->notAllowRemoveProducts = "該產品中的需求與項目進行了關聯或者項目下的{$lang->execution->common}關聯了該產品，請取消關聯後再操作。";
 $lang->project->ge                     = "『%s』應當不小於實際開始時間『%s』。";
-$lang->project->kanban                 = "看板";
-$lang->project->kanbanTitle            = "看板项目管理";
 
 $lang->project->programTitle['0']    = '不顯示';
 $lang->project->programTitle['base'] = '只顯示一級項目集';
diff --git a/module/project/view/createguide.html.php b/module/project/view/createguide.html.php
index 3c54ea68f6..316e6ac81a 100644
--- a/module/project/view/createguide.html.php
+++ b/module/project/view/createguide.html.php
@@ -29,13 +29,6 @@
             <p><?php echo $lang->project->waterfallTitle; ?></p>
           </div>
         </div>
-        <div class='col-xs-6'>
-          <div class='project-type text-center'>
-            <?php echo html::a($this->createLink("project", "create", "model=kanban&programID=$programID&copyProjectID=0&extra=productID=$productID,branchID=$branchID"), "<img class='project-type-img' data-type='waterfall' src='{$config->webRoot}theme/default/images/main/waterfall.png'>", '', "data-app='project' class='createButton'")?>
-            <h3><?php echo $lang->project->kanban; ?></h3>
-            <p><?php echo $lang->project->kanbanTitle; ?></p>
-          </div>
-        </div>
       </div>
     </div>
   </div>

From e3933a0f883b1c07a613203e0c0f2ebb7f2f3778 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 14:26:35 +0800
Subject: [PATCH 12/22] * Modify judgment for task#46654.

---
 module/productplan/view/browsebylist.html.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index 9563308bb9..3b4fdafbfb 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -167,6 +167,7 @@
                   $branchStatus = isset($branchStatusList[$plan->branch]) ? $branchStatusList[$plan->branch] : '';
                   if($branchStatus == 'closed') $disabled = 'disabled';
               }
+              if(in_array($plan->status, array('done', 'closed'))) $disabled = 'disabled';
 
               if($config->systemMode == 'new')
               {

From 82a0d10f4b984a32a057bea8fbea7b1e85953cd3 Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Thu, 30 Dec 2021 14:29:53 +0800
Subject: [PATCH 13/22] * The plan is completed or closed grayed out to create
 an execution button.

---
 module/productplan/js/browse.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index 7a4dbda12c..48add680b1 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -125,7 +125,11 @@ function createCardMenu(options)
         var executionLink = systemMode == 'new' ? '#projects' : createLink('execution', 'create', "projectID=0&executionID=0&copyExecutionID=0&plan=" + card.id + "&confirm=no&productID=" + productID);
         var today         = new Date();
         var end           = $.zui.createDate(card.end);
-        if(end.toLocaleDateString() < today.toLocaleDateString() && (card.status == 'wait' || card.status == 'doing'))
+        if(end.toLocaleDateString() < today.toLocaleDateString())
+        {
+            className = 'disabled';
+        }
+        else if(card.status == 'done' || card.status == 'closed')
         {
             className = 'disabled';
         }
@@ -134,10 +138,6 @@ function createCardMenu(options)
             var branchStatus = branchStatusList[card.branch];
             if(branchStatus == 'closed') className = 'disabled';
         }
-        else if(card.status == 'done' || card.status == 'closed')
-        {
-            className = 'disabled';
-        }
 
         if(systemMode == 'new')
         {

From 9ecbdf2509d3a83f13649b8f8700112812448661 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 14:33:20 +0800
Subject: [PATCH 14/22] * Modify the judged data type.

---
 module/productplan/view/browsebylist.html.php | 2 +-
 module/productplan/view/view.html.php         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index 3b4fdafbfb..9aebfe29e2 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -183,7 +183,7 @@
           common::printIcon('productplan', 'edit', "planID=$plan->id", $plan, 'list');
           if(common::hasPriv('productplan', 'create', $plan))
           {
-              if($plan->parent > '0' or in_array($plan->status, array('done', 'closed')))
+              if($plan->parent > 0 or in_array($plan->status, array('done', 'closed')))
               {
                   echo "<button type='button' class='disabled btn'><i class='disabled icon-split' title='{$this->lang->productplan->children}'></i></button> ";
               }
diff --git a/module/productplan/view/view.html.php b/module/productplan/view/view.html.php
index 7423ce1262..e966ae107a 100644
--- a/module/productplan/view/view.html.php
+++ b/module/productplan/view/view.html.php
@@ -64,7 +64,7 @@
         }
 
         $class = in_array($plan->status, array('done', 'closed')) ? 'disabled' : '';
-        if(common::hasPriv('productplan', 'create', $plan) and $plan->parent <= '0') echo html::a($this->createLink('productplan', 'create', "product={$plan->product}&branch={$plan->branch}&parent={$plan->id}"), "<i class='icon-split'></i> " . $this->lang->productplan->children , '', "class='btn btn-link {$class}' title='{$this->lang->productplan->children}'");
+        if(common::hasPriv('productplan', 'create', $plan) and $plan->parent <= 0) echo html::a($this->createLink('productplan', 'create', "product={$plan->product}&branch={$plan->branch}&parent={$plan->id}"), "<i class='icon-split'></i> " . $this->lang->productplan->children , '', "class='btn btn-link {$class}' title='{$this->lang->productplan->children}'");
         if(common::hasPriv('productplan', 'edit', $plan)) echo html::a($this->createLink('productplan', 'edit', "planID=$plan->id"), "<i class='icon-common-edit icon-edit'></i> " . $this->lang->edit, '', "class='btn btn-link' title='{$this->lang->edit}'");
         if(common::hasPriv('productplan', 'delete', $plan) and $plan->parent >= 0) echo html::a($this->createLink('productplan', 'delete', "planID=$plan->id"), "<i class='icon-common-delete icon-trash'></i> " . $this->lang->delete, '', "class='btn btn-link' title='{$this->lang->delete}' target='hiddenwin'");
     }

From 9f341e49edf5c4d9ca3694f64302d5920abf44de Mon Sep 17 00:00:00 2001
From: tanghucheng <tanghucheng@easycorp.ltd>
Date: Thu, 30 Dec 2021 15:10:54 +0800
Subject: [PATCH 15/22] * Finish task #46677.

---
 module/doc/view/content.html.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/doc/view/content.html.php b/module/doc/view/content.html.php
index 9768f7324c..16ae3254f2 100644
--- a/module/doc/view/content.html.php
+++ b/module/doc/view/content.html.php
@@ -49,7 +49,7 @@ $sessionString .= session_name() . '=' . session_id();
             if($canImportToPracticeLib or $canImportToComponentLib)
             {
                 echo "<div class='btn-group' id='more'>";
-                echo html::a('javascript:;', "<i class='icon icon-ellipsis-v'></i>", '', "data-toggle='dropdown' class='btn btn-link'");
+                echo html::a('javascript:;', "<i class='icon icon-diamond'></i>", '', "data-toggle='dropdown' class='btn btn-link'");
                 echo "<ul class='dropdown-menu pull-right'>";
                 if($canImportToPracticeLib) echo '<li>' . html::a('#importToPracticeLib', $lang->doc->importToPracticeLib, '', 'data-toggle="modal"') . '</li>';
                 if($canImportToComponentLib) echo '<li>' . html::a('#importToComponentLib', $lang->doc->importToComponentLib, '', 'data-toggle="modal"') . '</li>';

From ebe4c658070d4f924bd4c2a63a934968ae38e3ee Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 15:11:43 +0800
Subject: [PATCH 16/22] * Add child Label.

---
 module/productplan/view/browsebylist.html.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index 9aebfe29e2..cd6dc6fdf4 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -113,10 +113,13 @@
         </td>
         <td class='c-title text-left<?php if($plan->parent == '-1') echo ' has-child';?>' title="<?php echo $plan->title?>">
           <?php
+          $prefix = '';
           $suffix = '';
+          if($plan->parent > 0 and !isset($plans[$plan->parent])) $prefix = "<span class='label label-badge label-light' title='{$this->lang->productplan->children}'>{$this->lang->productplan->childrenAB}</span>";
           if($plan->end < $today and in_array($plan->status, array('wait', 'doing'))) $suffix = "<span class='label label-danger label-badge'>{$this->lang->productplan->expired}</span>";
           if($plan->parent == '-1' and isset($plan->children)) $suffix .= '<a class="task-toggle" data-id="' . $plan->id . '"><i class="icon icon-angle-double-right"></i></a>';
           if(!empty($suffix)) echo '<div class="plan-name has-prefix has-suffix">';
+          if(!empty($prefix)) echo $prefix;
           echo html::a(inlink('view', "id=$plan->id"), $plan->title);
           if(!empty($suffix)) echo $suffix . '</div>';
           ?>

From e9231b595ada904cabe669ef4909b282074358de Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Thu, 30 Dec 2021 07:16:28 +0000
Subject: [PATCH 17/22] Change configuration file.

---
 module/project/config.php | 34 ++--------------------------------
 module/project/model.php  |  7 ++++---
 2 files changed, 6 insertions(+), 35 deletions(-)

diff --git a/module/project/config.php b/module/project/config.php
index b2d37e3597..071d385551 100644
--- a/module/project/config.php
+++ b/module/project/config.php
@@ -131,35 +131,5 @@ $config->project->removePriv['doc']       = array('catalog', 'index');
 $config->project->removePriv['auditplan'] = array('delete');
 
 $config->project->checkList = new stdclass();
-
-$config->project->checkList->scrum                     = new stdclass();
-$config->project->checkList->scrum->execution          = defined('TABLE_EXECUTION') ? TABLE_EXECUTION : '';
-$config->project->checkList->scrum->bug                = defined('TABLE_BUG') ? TABLE_BUG : '';
-$config->project->checkList->scrum->case               = defined('TABLE_CASE') ? TABLE_CASE : '';
-$config->project->checkList->scrum->issue              = defined('TABLE_ISSUE') ? TABLE_ISSUE : '';
-$config->project->checkList->scrum->risk               = defined('TABLE_RISK') ? TABLE_RISK : '';
-$config->project->checkList->scrum->testtask           = defined('TABLE_TESTTASK') ? TABLE_TESTTASK : '';
-$config->project->checkList->scrum->doc                = defined('TABLE_DOC') ? TABLE_DOC : '';
-$config->project->checkList->scrum->build              = defined('TABLE_BUILD') ? TABLE_BUILD : '';
-$config->project->checkList->scrum->projectrelease     = defined('TABLE_RELEASE') ? TABLE_RELEASE : '';
-$config->project->checkList->scrum->meeting            = defined('TABLE_MEETING') ? TABLE_MEETING : '';
-
-$config->project->checkList->waterfall                 = new stdclass();
-$config->project->checkList->waterfall->stage          = defined('TABLE_EXECUTION') ? TABLE_EXECUTION : '';
-$config->project->checkList->waterfall->design         = defined('TABLE_DESIGN') ? TABLE_DESIGN : '';
-$config->project->checkList->waterfall->doc            = defined('TABLE_DOC') ? TABLE_DOC : '';
-$config->project->checkList->waterfall->bug            = defined('TABLE_BUG') ? TABLE_BUG : '';
-$config->project->checkList->waterfall->case           = defined('TABLE_CASE') ? TABLE_CASE : '';
-$config->project->checkList->waterfall->build          = defined('TABLE_BUILD') ? TABLE_BUILD : '';
-$config->project->checkList->waterfall->projectrelease = defined('TABLE_RELEASE') ? TABLE_RELEASE : '';
-$config->project->checkList->waterfall->testtask       = defined('TABLE_TESTTASK') ? TABLE_TESTTASK : '';
-
-$config->project->checkList->waterfall->review         = defined('TABLE_REVIEW') ? TABLE_REVIEW : '';
-$config->project->checkList->waterfall->build          = defined('TABLE_BUILD') ? TABLE_BUILD : '';
-$config->project->checkList->waterfall->researchplan   = defined('TABLE_RESEARCHPLAN') ? TABLE_RESEARCHPLAN : '';
-$config->project->checkList->waterfall->issue          = defined('TABLE_ISSUE') ? TABLE_ISSUE : '';
-$config->project->checkList->waterfall->risk           = defined('TABLE_RISK') ? TABLE_RISK : '';
-$config->project->checkList->waterfall->opportunity    = defined('TABLE_OPPORTUNITY') ? TABLE_OPPORTUNITY : '';
-$config->project->checkList->waterfall->auditplan      = defined('TABLE_AUDITPLAN') ? TABLE_AUDITPLAN : '';
-$config->project->checkList->waterfall->gapanalysis    = defined('TABLE_GAPANALYSIS') ? TABLE_GAPANALYSIS : '';
-$config->project->checkList->waterfall->meeting        = defined('TABLE_MEETING') ? TABLE_MEETING : '';
+$config->project->checkList->scrum     = array('bug', 'execution', 'meeting', 'release', 'build', 'doc', 'testtask', 'risk', 'issue', 'case');
+$config->project->checkList->waterfall = array('execution', 'design', 'doc', 'bug', 'case', 'build', 'release', 'testtask', 'review', 'build', 'researchplan', 'issue', 'risk', 'opportunity', 'auditplan', 'gapanalysis', 'meeting');
diff --git a/module/project/model.php b/module/project/model.php
index 3f974baf4f..8c5bab4129 100644
--- a/module/project/model.php
+++ b/module/project/model.php
@@ -2098,10 +2098,11 @@ class projectModel extends model
     public function checkCanChangeModel($projectID, $model)
     {
         $checkList = $this->config->project->checkList->$model;
-        foreach($checkList as $table)
+        foreach($checkList as $module)
         {
             $object = '';
-            if($table == '') continue;
+            if($module == '') continue;
+            $table = constant('TABLE_'. strtoupper($module));;
             if($table == TABLE_EXECUTION and $model == 'scrum')
             {
                 $object = $this->fetchByProject($table, $projectID, 'sprint');
@@ -2130,7 +2131,7 @@ class projectModel extends model
      */
     public function fetchByProject($table, $projectID, $type = '')
     {
-        $result = $this->dao->select('*')->from($table)
+        $result = $this->dao->select('id')->from($table)
             ->where('project')->eq($projectID)
             ->beginIF(!empty($type))->andWhere('type')->eq($type)->fi()
             ->fetch();

From 3602538f9c4af0e58021049508a2b5eb0e48accb Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 15:21:09 +0800
Subject: [PATCH 18/22] * Fix bug for update status.

---
 module/productplan/model.php | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/module/productplan/model.php b/module/productplan/model.php
index 311e7c2e48..2060716c92 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -604,22 +604,22 @@ class productplanModel extends model
             if($method == 'start')
             {
                 $action = 'started';
-                if($parentChange) $parentAction = 'startedbychild';
+                if(isset($parentChange) and $parentChange) $parentAction = 'startedbychild';
             }
             elseif($method == 'finish')
             {
                 $action = 'finished';
-                if($parentChange) $parentAction = 'finishedbychild';
+                if(isset($parentChange) and $parentChange) $parentAction = 'finishedbychild';
             }
             elseif($method == 'close')
             {
                 $action = 'closed';
-                if($parentChange) $parentAction = 'closedbychild';
+                if(isset($parentChange) and $parentChange) $parentAction = 'closedbychild';
             }
             elseif($method == 'activate')
             {
                 $action = 'activated';
-                if($parentChange) $parentAction = 'activatedbychild';
+                if(isset($parentChange) and $parentChange) $parentAction = 'activatedbychild';
             }
 
             if(isset($action))
@@ -628,7 +628,7 @@ class productplanModel extends model
                 $actionID = $this->loadModel('action')->create('productplan', $planID, $action);
                 $this->action->loghistory($actionID, $changes);
 
-                if($parentChange) $actionID = $this->action->create('productplan', $oldPlan->parent, $parentAction, '', $parentAction);
+                if(isset($parentChange) and $parentChange) $actionID = $this->action->create('productplan', $oldPlan->parent, $parentAction, '', $parentAction);
             }
         }
     }

From e9c8da2f1e27ec9ea0a2ea2ea4d515019ca419b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AD=99=E5=B9=BF=E6=98=8E?= <sunguangming@cnezsoft.com>
Date: Thu, 30 Dec 2021 16:04:32 +0800
Subject: [PATCH 19/22] * Finish task #46670.

---
 module/productplan/config.php                 |  1 +
 module/productplan/control.php                |  1 +
 module/productplan/js/browse.js               | 58 ++++++++++++++++++-
 module/productplan/model.php                  | 11 +++-
 module/productplan/view/browsebylist.html.php |  8 +--
 module/productplan/view/start.html.php        | 11 ++--
 6 files changed, 77 insertions(+), 13 deletions(-)

diff --git a/module/productplan/config.php b/module/productplan/config.php
index 3c07e859d5..a669201cc0 100644
--- a/module/productplan/config.php
+++ b/module/productplan/config.php
@@ -10,5 +10,6 @@ $config->productplan->start->requiredFields  = 'begin,end';
 $config->productplan->editor = new stdclass();
 $config->productplan->editor->create = array('id' => 'desc', 'tools' => 'simpleTools');
 $config->productplan->editor->edit   = array('id' => 'desc', 'tools' => 'simpleTools');
+$config->productplan->editor->start  = array('id' => 'desc', 'tools' => 'simpleTools');
 
 $config->productplan->laneColorList = array('#32C5FF', '#006AF1', '#9D28B2', '#FF8F26', '#FFC20E', '#00A78E', '#7FBB00', '#424BAC', '#C0E9FF', '#EC2761');
diff --git a/module/productplan/control.php b/module/productplan/control.php
index 8b6204bf00..e9d42232d9 100644
--- a/module/productplan/control.php
+++ b/module/productplan/control.php
@@ -420,6 +420,7 @@ class productplan extends control
 
                 return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess,'locate' => 'parent'));
             }
+
             $this->view->plan = $plan;
             $this->display();
         }
diff --git a/module/productplan/js/browse.js b/module/productplan/js/browse.js
index 5b6e183368..19e22af2a3 100644
--- a/module/productplan/js/browse.js
+++ b/module/productplan/js/browse.js
@@ -198,8 +198,7 @@ function findDropColumns($element, $root)
     var $col        = $element.closest('.kanban-col');
     var col         = $col.data();
     var lane        = $col.closest('.kanban-lane').data();
-    var kanbanID    = $root.data('id');
-    var kanbanRules = window.kanbanDropRules ? window.kanbanDropRules[kanbanID] : null;
+    var kanbanRules = window.kanbanDropRules ? window.kanbanDropRules : null;
 
     if(!kanbanRules) return $root.find('.kanban-lane[data-id="' + lane.id + '"] .kanban-lane-col:not([data-type="project"],[data-type="' + col.type + '"])');
 
@@ -251,6 +250,50 @@ function handleFinishDrop(event)
 function changeCardColType(card, fromColType, toColType, kanbanID)
 {
     if(typeof card == 'undefined') return false;
+    var objectID   = card.id;
+    var privs      = card.actions;
+    var showIframe = false;
+    var link       = '';
+
+    if(toColType == 'doing')
+    {
+        if(fromColType == 'wait' && privs.includes('start'))
+        {
+            var link   = createLink('productplan', 'start', 'planID=' + objectID, '', true);
+            showIframe = true;
+        }
+        else if((fromColType == 'done' || fromColType == 'closed') && privs.includes('activate'))
+        {
+            var link   = createLink('productplan', 'activate', 'planID=' + objectID, '', true);
+            showIframe = false;
+        }
+    }
+    else if(toColType == 'done')
+    {
+        if(fromColType == 'doing')
+        {
+            var link   = createLink('productplan', 'finish', 'planID=' + objectID, '', true);
+            showIframe = false;
+        }
+    }
+    else if(toColType == 'closed')
+    {
+        if(fromColType == 'done')
+        {
+            var link   = createLink('productplan', 'close', 'planID=' + objectID);
+            showIframe = false;
+        }
+    }
+
+    if(showIframe)
+    {
+        var modalTrigger = new $.zui.ModalTrigger({type: 'iframe', width: '50%', url: link});
+        modalTrigger.show();
+    }
+    else if(!showIframe && link)
+    {
+        hiddenwin.location.href = link;
+    }
 }
 
 /**
@@ -374,3 +417,14 @@ function getPlanID(obj, branch)
         }
     });
 }
+
+if(!window.kanbanDropRules)
+{
+    window.kanbanDropRules =
+    {    
+        wait: ['doing'],
+        doing: ['done'],
+        done: ['doing', 'closed'],
+        closed: ['doing']
+    }    
+}
diff --git a/module/productplan/model.php b/module/productplan/model.php
index 2d9fca41e1..4561d53268 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -521,10 +521,15 @@ class productplanModel extends model
 
         if($status == 'doing' and !empty($_POST))
         {
-            $plan = fixer::input('post')->add('status', $status)->get();
+            $plan = fixer::input('post')
+                ->add('status', $status)
+                ->stripTags($this->config->productplan->editor->start['id'], $this->config->allowedTags)
+                ->remove('uid')
+                ->get();
 
             $this->checkDate4Plan($oldPlan, $plan->begin, $plan->end);
             if(dao::isError()) return false;
+            $plan = $this->loadModel('file')->processImgURL($plan, $this->config->productplan->editor->start['id'], $this->post->uid);
 
             $this->dao->update(TABLE_PRODUCTPLAN)
                 ->data($plan)
@@ -534,6 +539,8 @@ class productplanModel extends model
                 ->where('id')->eq($planID)
                 ->beginIF(isset($parentPlan))->orWhere('id')->eq($oldPlan->parent)->fi()
                 ->exec();
+
+            $this->file->updateObjectID($this->post->uid, $planID, 'productplan');
             if($parentPlan->status != 'doing') $parentChange = true;
         }
         elseif($status == 'doing' and isset($parentPlan) and $parentPlan->status != 'doing')
@@ -959,7 +966,7 @@ class productplanModel extends model
                 if($plan->status != 'done' or $plan->parent < 0) return false;
                 break;
             case 'activate' :
-                if($plan->status != 'closed' or $plan->parent < 0) return false;
+                if(($plan->status != 'closed' and $plan->status != 'done') or $plan->parent < 0) return false;
                 break;
         }
 
diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index 96ba8f4bc7..6f3ce09231 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -147,12 +147,12 @@
               if($plan->begin == '2030-01-01' or $plan->end == '2030-01-01')
               {
                   $class      = 'iframe';
-                  $attr       = "data-toggle='modal' data-id='{$plan->id}' data-width='550px'";
+                  $attr       = "data-id='{$plan->id}' data-width='550px'";
                   $isOnlyBody = true;
               }
-              common::printIcon('productplan', 'start', "planID=$plan->id", $plan, 'list', 'play', '', $class, $isOnlyBody, $attr, $lang->productplan->start);
-              common::printIcon('productplan', 'finish', "planID=$plan->id", $plan, 'list', 'checked', '', $class, false, $attr, $lang->productplan->finish);
-              common::printIcon('productplan', 'close', "planID=$plan->id", $plan, 'list', 'off', '', $class, false, $attr, $lang->productplan->close);
+              common::printIcon('productplan', 'start', "planID=$plan->id", $plan, 'list', 'play', '', $class, $isOnlyBody);
+              common::printIcon('productplan', 'finish', "planID=$plan->id", $plan, 'list', 'checked', '', $class, false, $attr);
+              common::printIcon('productplan', 'close', "planID=$plan->id", $plan, 'list', 'off', '', $class, false, $attr);
           }
 
           $attr = $plan->expired ? "disabled='disabled'" : '';
diff --git a/module/productplan/view/start.html.php b/module/productplan/view/start.html.php
index 1f9a9c43b5..5087c5207d 100644
--- a/module/productplan/view/start.html.php
+++ b/module/productplan/view/start.html.php
@@ -10,11 +10,8 @@
  * @link        https://www.zentao.net
  */
 ?>
-<style>
-.table-form {margin-top: 90px;}
-.form-actions {height:160px;}
-</style>
 <?php include '../../common/view/header.html.php';?>
+<?php include '../../common/view/kindeditor.html.php';?>
 <div id='mainContent' class='main-content'>
   <div class='center-block'>
     <div class='main-header'>
@@ -31,7 +28,11 @@
           <td colspan='2'><?php echo html::input('end', $plan->end != '2030-01-01' ? formatTime($plan->end) : '', 'class="form-control form-date"');?></td>
         </tr>
         <tr>
-          <td colspan='4' class='text-center form-actions'>
+          <th><?php echo $lang->productplan->desc;?></th>
+          <td colspan='4'><?php echo html::textarea('desc', $plan->desc, 'class="form-control"');?></td>
+        </tr>
+        <tr>
+          <td colspan='5' class='text-center form-actions'>
             <?php echo html::submitButton($lang->productplan->start);?>
             <?php echo html::commonButton($lang->cancel, "data-dismiss='modal'", 'btn btn-wide');?>
           </td>

From 50dabf7bd7f6465c73a7c636fe08210cfe01c0c4 Mon Sep 17 00:00:00 2001
From: zhouxin <zhouxin@easycorp.ltd>
Date: Thu, 30 Dec 2021 08:09:50 +0000
Subject: [PATCH 20/22] Refactor method checkCanChangeModel.

---
 module/project/model.php | 23 ++++++++++-------------
 1 file changed, 10 insertions(+), 13 deletions(-)

diff --git a/module/project/model.php b/module/project/model.php
index 8c5bab4129..76d9bdf9dd 100644
--- a/module/project/model.php
+++ b/module/project/model.php
@@ -2100,21 +2100,18 @@ class projectModel extends model
         $checkList = $this->config->project->checkList->$model;
         foreach($checkList as $module)
         {
-            $object = '';
             if($module == '') continue;
-            $table = constant('TABLE_'. strtoupper($module));;
-            if($table == TABLE_EXECUTION and $model == 'scrum')
+
+            $type = '';
+            $table = constant('TABLE_'. strtoupper($module));
+            $object = new stdclass();
+
+            if($table == TABLE_EXECUTION)
             {
-                $object = $this->fetchByProject($table, $projectID, 'sprint');
-            }
-            elseif($table == TABLE_EXECUTION and $model == 'waterfall')
-            {
-                $object = $this->fetchByProject($table, $projectID, 'stage');
-            }
-            else
-            {
-                $object = $this->fetchByProject($table, $projectID);
+                $type = $model == 'scrum' ? 'sprint' : 'stage';
             }
+
+            $object = $this->getDataByProject($table, $projectID, $type);
             if(!empty($object)) return false;
         }
         return true;
@@ -2129,7 +2126,7 @@ class projectModel extends model
      * @access public
      * @return object
      */
-    public function fetchByProject($table, $projectID, $type = '')
+    public function getDataByProject($table, $projectID, $type = '')
     {
         $result = $this->dao->select('id')->from($table)
             ->where('project')->eq($projectID)

From a02d19a0c4eb1efb3296813ac0a860dbe62dedf2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AD=99=E5=B9=BF=E6=98=8E?= <sunguangming@cnezsoft.com>
Date: Thu, 30 Dec 2021 16:14:12 +0800
Subject: [PATCH 21/22] * Fix merge code bug.

---
 module/productplan/model.php | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/module/productplan/model.php b/module/productplan/model.php
index 316b698401..7d34e98a37 100644
--- a/module/productplan/model.php
+++ b/module/productplan/model.php
@@ -970,11 +970,7 @@ class productplanModel extends model
                 if($plan->status != 'done' or $plan->parent < 0) return false;
                 break;
             case 'activate' :
-<<<<<<< module/productplan/model.php
-                if(($plan->status != 'closed' and $plan->status != 'done') or $plan->parent < 0) return false;
-=======
                 if($plan->status == 'wait' or $plan == 'doing' or $plan->parent < 0) return false;
->>>>>>> module/productplan/model.php
                 break;
         }
 

From abd52e3141eb1961ea1c9a290aaa51cf7c930b72 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Thu, 30 Dec 2021 16:25:32 +0800
Subject: [PATCH 22/22] * Modify print label code of plan list.

---
 module/productplan/control.php                |  2 +-
 module/productplan/css/browse.css             | 10 +++++---
 module/productplan/view/browsebylist.html.php | 25 +++++++++++--------
 3 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/module/productplan/control.php b/module/productplan/control.php
index 8b6204bf00..bf74b028e1 100644
--- a/module/productplan/control.php
+++ b/module/productplan/control.php
@@ -68,7 +68,7 @@ class productplan extends control
 
             if($this->viewType == 'json') return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess, 'id' => $planID));
             if(isonlybody()) return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess, 'closeModal' => true, 'callback' => 'parent.refreshPlan()'));
-            return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess, 'locate' => $this->createLink('productplan', 'browse', "productID=$productID&branch=$branchID")));
+            return $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess, 'locate' => $this->createLink('productplan', 'browse', "productID=$productID&branch=$branchID&browseType=wait")));
         }
 
         $this->commonAction($productID, $branchID);
diff --git a/module/productplan/css/browse.css b/module/productplan/css/browse.css
index 154e628e50..b5607f9b1b 100644
--- a/module/productplan/css/browse.css
+++ b/module/productplan/css/browse.css
@@ -17,16 +17,18 @@ td.c-branch {overflow: hidden; text-align: left !important; text-overflow: ellip
 
 .c-title {width: 160px;}
 .c-branch {width: 100px;}
-.c-story {width: 80px;}
+.c-story, .c-status {width: 80px;}
 .c-execution {width: 50px !important;}
 .c-bug, .c-hour {width: 60px;}
 
 .plan-name {position: relative; display: flex; align-items: center;}
 .plan-name > span {flex: none;}
 
-.c-title.has-child > .plan-name.has-suffix > a, .c-title.has-child > .plan-name.has-prefix > a {overflow:hidden; max-width: calc(100% - 70px);}
-.plan-name.has-suffix > a, .plan-name.has-prefix > a {overflow:hidden; max-width: calc(100% - 46px);}
-#productplanList .plan-name > .label.label-danger {margin-left:3px; }
+#productplanList .c-title.has-child > .plan-name.expired > a {overflow:hidden; max-width: calc(100% - 62px);}
+#productplanList .c-title.has-child > .plan-name > a {overflow:hidden; max-width: calc(100% - 16px);}
+#productplanList .c-title > .plan-name.expired > a {overflow:hidden; max-width: calc(100% - 46px);}
+#productplanList .plan-name.expired > .label.label-danger {margin-left:3px; }
+#productplanList .plan-name > .label.label-light {margin-right:3px; }
 
 .switchButton {background: #fff !important;}
 .panel-actions {position: relative; padding: 0 0; padding-top: 1px;}
diff --git a/module/productplan/view/browsebylist.html.php b/module/productplan/view/browsebylist.html.php
index cd6dc6fdf4..7bd3c4a9db 100644
--- a/module/productplan/view/browsebylist.html.php
+++ b/module/productplan/view/browsebylist.html.php
@@ -57,7 +57,7 @@
         </th>
         <th class='c-title'><?php common::printOrderLink('title', $orderBy, $vars, $lang->productplan->title);?></th>
         <?php if($browseType == 'all'):?>
-        <th><?php common::printOrderLink('status', $orderBy, $vars, $lang->productplan->status);?></th>
+        <th class='c-status'><?php common::printOrderLink('status', $orderBy, $vars, $lang->productplan->status);?></th>
         <?php endif;?>
         <?php if($this->session->currentProductType != 'normal'):?>
         <th class='c-branch'><?php common::printOrderLink('branch',$orderBy, $vars, $lang->productplan->branch);?></th>
@@ -111,17 +111,22 @@
           <?php echo sprintf('%03d', $plan->id);?>
           <?php endif;?>
         </td>
-        <td class='c-title text-left<?php if($plan->parent == '-1') echo ' has-child';?>' title="<?php echo $plan->title?>">
+        <td class='c-title text-left<?php if(isset($plan->children)) echo ' has-child';?>' title="<?php echo $plan->title?>">
           <?php
-          $prefix = '';
-          $suffix = '';
-          if($plan->parent > 0 and !isset($plans[$plan->parent])) $prefix = "<span class='label label-badge label-light' title='{$this->lang->productplan->children}'>{$this->lang->productplan->childrenAB}</span>";
-          if($plan->end < $today and in_array($plan->status, array('wait', 'doing'))) $suffix = "<span class='label label-danger label-badge'>{$this->lang->productplan->expired}</span>";
-          if($plan->parent == '-1' and isset($plan->children)) $suffix .= '<a class="task-toggle" data-id="' . $plan->id . '"><i class="icon icon-angle-double-right"></i></a>';
-          if(!empty($suffix)) echo '<div class="plan-name has-prefix has-suffix">';
-          if(!empty($prefix)) echo $prefix;
+          $class   = '';
+          $expired = '';
+          if($plan->end < $today and in_array($plan->status, array('wait', 'doing')))
+          {
+              $class  .= ' expired';
+              $expired = "<span class='label label-danger label-badge'>{$this->lang->productplan->expired}</span>";
+          }
+
+          echo "<div class='plan-name has-prefix {$class}'>";
+          if($plan->parent > 0 and !isset($plans[$plan->parent])) echo "<span class='label label-badge label-light' title='{$this->lang->productplan->children}'>{$this->lang->productplan->childrenAB}</span>";
           echo html::a(inlink('view', "id=$plan->id"), $plan->title);
-          if(!empty($suffix)) echo $suffix . '</div>';
+          if(!empty($expired)) echo $expired;
+          if(isset($plan->children)) echo '<a class="task-toggle" data-id="' . $plan->id . '"><i class="icon icon-angle-double-right"></i></a>';
+          echo '</div>';
           ?>
         </td>
         <?php if($browseType == 'all'):?>