From 4c344964ebe8eea219e548ab55b61fa32b262bed Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Wed, 10 Apr 2024 11:14:38 +0800
Subject: [PATCH] * Optimize code.

---
 module/programplan/model.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/module/programplan/model.php b/module/programplan/model.php
index 8dbb42d4d8..50503149a0 100755
--- a/module/programplan/model.php
+++ b/module/programplan/model.php
@@ -357,12 +357,11 @@ class programplanModel extends model
             if($data->start_date == '' or $data->endDate == '') $data->duration = 1;
 
             if(strpos($selectCustom, 'task') !== false) $datas['data'][$data->id] = $data;
+            $isParent = $task->parent == -1;
             foreach($stageIndex as $index => $stage)
             {
                 if($stage['planID'] == $task->execution)
                 {
-                    $isParent = $task->parent == -1;
-
                     $stageIndex[$index]['progress']['totalEstimate'] += $isParent ? 0 : $task->estimate;
                     $stageIndex[$index]['progress']['totalConsumed'] += $isParent ? 0 : $task->consumed;
                     $stageIndex[$index]['progress']['totalReal']     += $isParent ? 0 : ((($task->status == 'closed' || $task->status == 'cancel' || $isParent) ? 0 : $task->left) + $task->consumed);