From 4bfac8f7bc33b4388e536f04bb242409fbaa04bd Mon Sep 17 00:00:00 2001
From: wangxuepeng <wangxuepeng@easycorp.ltd>
Date: Thu, 12 Oct 2023 02:00:11 +0000
Subject: [PATCH] * Add unit test for actionModel::updateStageAttribute.

---
 module/action/model.php                       | 10 ++++---
 module/action/test/action.class.php           | 20 +++++++++++++
 .../action/test/model/updatestageattibute.php | 29 +++++++++++++++++++
 3 files changed, 55 insertions(+), 4 deletions(-)
 create mode 100644 module/action/test/model/updatestageattibute.php

diff --git a/module/action/model.php b/module/action/model.php
index 42436391f4..4b3c7b6459 100755
--- a/module/action/model.php
+++ b/module/action/model.php
@@ -1671,13 +1671,15 @@ class actionModel extends model
      * Update stage attribute.
      *
      * @param  string $attribute
-     * @param  array  $idList
+     * @param  array  $executions
      * @access public
-     * @return int
+     * @return bool
      */
-    public function updateStageAttribute(string $attribute, array $stages): int
+    public function updateStageAttribute(string $attribute, array $executions): bool
     {
-        return $this->dao->update(TABLE_EXECUTION)->set('attribute')->eq($attribute)->where('id')->in($stages)->exec();
+        $this->dao->update(TABLE_EXECUTION)->set('attribute')->eq($attribute)->where('id')->in($executions)->exec();
+
+        return !dao::isError();
     }
 
     /**
diff --git a/module/action/test/action.class.php b/module/action/test/action.class.php
index def6a60c10..9b1a535d74 100644
--- a/module/action/test/action.class.php
+++ b/module/action/test/action.class.php
@@ -658,4 +658,24 @@ class actionTest
 
         return $result[0];
     }
+    
+    /**
+     * 测试更新阶段的属性。
+     * Test update stage attribute.
+     *
+     * @param  string     $attributeList
+     * @param  array      $executionID
+     * @access public
+     * @return array|bool
+     */
+    public function updateStageAttributeTest(string $attribute, array $stages): array|bool
+    {
+        $this->objectModel->updateStageAttribute($attribute, $stages);
+
+        if(dao::isError()) return dao::getError();
+
+        global $tester;
+        $objects = $tester->dao->select('*')->from(TABLE_EXECUTION)->where('id')->in($stages)->fetchAll();
+        return $objects;
+    }
 }
diff --git a/module/action/test/model/updatestageattibute.php b/module/action/test/model/updatestageattibute.php
new file mode 100644
index 0000000000..e27b574822
--- /dev/null
+++ b/module/action/test/model/updatestageattibute.php
@@ -0,0 +1,29 @@
+#!/usr/bin/env php
+<?php
+
+include dirname(__FILE__, 5) . '/test/lib/init.php';
+include dirname(__FILE__, 2) . '/action.class.php';
+su('admin');
+
+zdTable('project')->gen(5);
+
+/**
+
+title=测试 actionModel->read();
+cid=1
+pid=1
+
+测试attributeList为0,executionID为0          >> 0
+测试attributeList为1,executionID为1          >> 1
+测试attributeList为attribute,executionID为2  >> 3,attribute;4,attribute
+
+*/
+
+$attributeList = array(0, 1, 'attribute');
+$executionID   = array(array(1), array(2), array(3, 4));
+
+$action = new actionTest();
+
+r($action->updateStageAttributeTest($attributeList[0], $executionID[0])) && p('0:id,attribute') && e('1,0');                                    //测试attributeList为0,executionID为0
+r($action->updateStageAttributeTest($attributeList[1], $executionID[1])) && p('0:id,attribute') && e('2,1');                                    //测试attributeList为1,executionID为1
+r($action->updateStageAttributeTest($attributeList[2], $executionID[2])) && p('0:id,attribute;1:id,attribute') && e('3,attribute;4,attribute');  //测试attributeList为attribute,executionID为2