From 45a0548b0ad934fe81c28b94b68f29563dcee98d Mon Sep 17 00:00:00 2001 From: zenggang Date: Mon, 28 Aug 2023 02:55:15 +0000 Subject: [PATCH] * Adjust code --- module/repo/ui/review.html.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/module/repo/ui/review.html.php b/module/repo/ui/review.html.php index 99f5fc180b..8e3c17c344 100644 --- a/module/repo/ui/review.html.php +++ b/module/repo/ui/review.html.php @@ -16,10 +16,11 @@ foreach($bugs as $bug) $lines = explode(',', trim($bug->lines, ',')); $bug->entry = $repo->name . '/' . $this->repo->decodePath($bug->entry); + $encodeEntry = urlencode($bug->entry); if(empty($bug->v1)) { $revision = $repo->SCM != 'Subversion' ? $this->repo->getGitRevisionName($bug->v2, zget($historys, $bug->v2)) : $bug->v2; - $bug->link = $this->repo->createLink('view', "repoID=$repoID&objectID=0&entry={$bug->entry}&revision={$bug->v2}") . "#L$lines[0]"; + $bug->link = $this->repo->createLink('view', "repoID=$repoID&objectID=0&entry={$encodeEntry}&revision={$bug->v2}") . "#L$lines[0]"; } else { @@ -27,7 +28,7 @@ foreach($bugs as $bug) $revision .= ' : '; $revision .= $repo->SCM != 'Subversion' ? substr($bug->v2, 0, 10) : $bug->v2; if($repo->SCM != 'Subversion') $revision .= ' (' . zget($historys, $bug->v1) . ' : ' . zget($historys, $bug->v2) . ')'; - $bug->link = $this->repo->createLink('diff', "repoID=$repoID&objectID=0&entry={$bug->entry}&oldRevision={$bug->v1}&newRevision={$bug->v2}") . "#L$lines[0]"; + $bug->link = $this->repo->createLink('diff', "repoID=$repoID&objectID=0&entry={$encodeEntry}&oldRevision={$bug->v1}&newRevision={$bug->v2}") . "#L$lines[0]"; } } $bugs = initTableData($bugs, $config->repo->reviewDtable->fieldList);