diff --git a/framework/base/helper.class.php b/framework/base/helper.class.php index df9946f0cb..c6bdcd99ff 100644 --- a/framework/base/helper.class.php +++ b/framework/base/helper.class.php @@ -226,7 +226,10 @@ class baseHelper $extModelClass = 'ext' . $modelClass; $extTmpModelClass = 'tmpExt' . $modelClass; $modelLines = "getBasePath());\n"; + $modelLines .= "helper::import('" . str_replace($app->getBasePath(), '.' . DS, $mainModelFile) . "');\n"; + $modelLines .= "helper::cd();\n"; $modelLines .= "class $extTmpModelClass extends $modelClass \n{\n"; /* Cycle all the extension files. */ diff --git a/module/custom/view/set.html.php b/module/custom/view/set.html.php index 7a84f6802f..5de05c4d01 100644 --- a/module/custom/view/set.html.php +++ b/module/custom/view/set.html.php @@ -71,7 +71,7 @@ EOT; custom->reviewList, $needReview);?> - + > custom->forceReview;?> custom->notice->forceReview, $lang->$module->common);?> @@ -162,4 +162,22 @@ EOT; + + + diff --git a/module/story/model.php b/module/story/model.php index 0aa6279f77..a9d1a13304 100644 --- a/module/story/model.php +++ b/module/story/model.php @@ -1308,6 +1308,7 @@ class storyModel extends model */ public function getProductStoryPairs($productID = 0, $branch = 0, $moduleIdList = 0, $status = 'all', $order = 'id_desc', $limit = 0) { + if($branch) $branch = "0,$branch";//Fix bug 1059. $stories = $this->dao->select('t1.id, t1.title, t1.module, t1.pri, t1.estimate, t2.name AS product') ->from(TABLE_STORY)->alias('t1')->leftJoin(TABLE_PRODUCT)->alias('t2')->on('t1.product = t2.id') ->where('1=1') diff --git a/module/testcase/model.php b/module/testcase/model.php index 87eab58da7..1523ff5da7 100644 --- a/module/testcase/model.php +++ b/module/testcase/model.php @@ -1352,12 +1352,11 @@ class testcaseModel extends model * Check whether force review * * @access public - * @return void + * @return bool */ public function forceReview() { - if(!$this->config->testcase->needReview) return false; - if(empty($this->config->testcase->forceReview)) return true; + if($this->config->testcase->needReview) return true; if(strpos(",{$this->config->testcase->forceReview},", ",{$this->app->user->account},") !== false) return true; return false; }