From 3e01a5a14237f88f2a49d2d0eafe4df2071967bb Mon Sep 17 00:00:00 2001 From: caoyanyi Date: Mon, 18 Dec 2023 19:09:26 +0800 Subject: [PATCH] * Adjust sonar error for gogs. --- module/gogs/control.php | 1 - module/gogs/model.php | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/module/gogs/control.php b/module/gogs/control.php index 7627668a5f..8772fdffa8 100644 --- a/module/gogs/control.php +++ b/module/gogs/control.php @@ -185,7 +185,6 @@ class gogs extends control $gogsUsers = $this->gogs->apiGetUsers($gogsID); $bindedUsers = $this->loadModel('pipeline')->getUserBindedPairs($gogsID, 'gogs'); $matchedResult = $this->gogsZen->getMatchedUsers($gogsID, $gogsUsers); - $bindedUsers = $this->pipeline->getUserBindedPairs($gogsID, 'gitea'); $zentaoUsers = $this->loadModel('user')->getRealNameAndEmails(helper::arrayColumn($matchedResult, 'zentaoAccount')); foreach($gogsUsers as $gogsUser) diff --git a/module/gogs/model.php b/module/gogs/model.php index e10267c54f..c8e34efd5e 100644 --- a/module/gogs/model.php +++ b/module/gogs/model.php @@ -20,7 +20,7 @@ class gogsModel extends model * @access public * @return string */ - public function getApiRoot(int $gogsID) string + public function getApiRoot(int $gogsID): string { $gogs = $this->fetchByID($gogsID); if(!$gogs) return ''; @@ -38,7 +38,7 @@ class gogsModel extends model * @access public * @return array */ - public function bindUser(int $gogsID, , array $users, array $gogsNames): bool + public function bindUser(int $gogsID, array $users, array $gogsNames): bool { $accountList = array(); $repeatUsers = array();