diff --git a/extension/lite/execution/ext/control/edit.php b/extension/lite/execution/ext/control/edit.php index c7796cbc34..549a815fbf 100644 --- a/extension/lite/execution/ext/control/edit.php +++ b/extension/lite/execution/ext/control/edit.php @@ -2,9 +2,9 @@ helper::importControl('execution'); class myExecution extends execution { - public function edit($executionID, $action = 'edit', $extra = '') + public function edit($executionID, $action = 'edit', $extra = '', $newPlans = '', $confirm = 'no') { $this->config->execution->edit->requiredFields = 'name,code,begin,end'; parent::edit($executionID, $action, $extra); } -} \ No newline at end of file +} diff --git a/framework/model.class.php b/framework/model.class.php index 45477bace2..3ae6f6d4be 100644 --- a/framework/model.class.php +++ b/framework/model.class.php @@ -103,7 +103,7 @@ class model extends baseModel if($action->extensionType == 'override') return $this->loadModel('flow')->buildActionMenu($moduleName, $action, $data, $type); $conditions = json_decode($action->conditions); - if($action->extensionType == 'extend') + if($conditions and $action->extensionType == 'extend') { if($icon != 'copy' and $methodName != 'create') $title = $action->name; if($conditions) $enabled = $this->loadModel('flow')->checkConditions($conditions, $data); diff --git a/module/action/model.php b/module/action/model.php index db1d6c8eb3..029c0a6899 100755 --- a/module/action/model.php +++ b/module/action/model.php @@ -692,7 +692,7 @@ class actionModel extends model * @param string $orderBy * @param object $pager * @access public - * @return void + * @return array */ public function getTrashesBySearch($objectType, $type, $queryID, $orderBy, $pager = null) { @@ -716,9 +716,7 @@ class actionModel extends model $extra = $type == 'hidden' ? self::BE_HIDDEN : self::CAN_UNDELETED; $trashQuery = $this->session->trashQuery; - $trashQuery = preg_replace("/`objectID`/", 't1.`objectID`', $trashQuery); - $trashQuery = preg_replace("/`actor`/", 't1.`actor`', $trashQuery); - $trashQuery = preg_replace("/`date`/", 't1.`date`', $trashQuery); + $trashQuery = str_replace(array('`objectID`', '`actor`', '`date`'), array('t1.`objectID`', 't1.`actor`', 't1.`date`'), $trashQuery); $table = $this->config->objectTables[$objectType]; $nameField = isset($this->config->action->objectNameFields[$objectType]) ? 't2.' . "`{$this->config->action->objectNameFields[$objectType]}`" : ''; diff --git a/module/bug/css/browse.en.css b/module/bug/css/browse.en.css new file mode 100644 index 0000000000..ca31c97339 --- /dev/null +++ b/module/bug/css/browse.en.css @@ -0,0 +1 @@ +#mainMenu .btn-toolbar a.btn {padding: 6px 3px;} diff --git a/module/bug/css/view.css b/module/bug/css/view.css index d3e4181d63..59cb9d6ffc 100644 --- a/module/bug/css/view.css +++ b/module/bug/css/view.css @@ -4,3 +4,4 @@ .side-col .cell {padding: 0px;} .tab-pane table {border: 1px solid #ddd; border-top: none;} .btn-edit-comment {z-index: 100;} +.modal-body {right: 15px;} diff --git a/module/bug/js/view.js b/module/bug/js/view.js index 5226a3e3e4..dbef34842b 100644 --- a/module/bug/js/view.js +++ b/module/bug/js/view.js @@ -18,7 +18,7 @@ $('#tostory').click(function() */ function loadProductExecutions(productID, projectID) { - link = createLink('product', 'ajaxGetExecutions', 'productID=' + productID + '&projectID=' + projectID +'&branch=' + branchID + '&number=&executionID=0&from=bugToTask'); + var link = createLink('product', 'ajaxGetExecutions', 'productID=' + productID + '&projectID=' + projectID +'&branch=' + branchID + '&number=&executionID=0&from=bugToTask'); $('#executionBox').load(link, function() { @@ -41,7 +41,7 @@ $('#toTaskButton').on('click', function() else if(systemMode == 'classic' && executionID) { $('#cancelButton').click(); - link = createLink('task', 'create', 'executionID=' + executionID + '&storyID=0&moduleID=0&taskID=0&todoID=0&extra=projectID=0&bugID=' + bugID); + var link = createLink('task', 'create', 'executionID=' + executionID + '&storyID=0&moduleID=0&taskID=0&todoID=0&extra=projectID=0&bugID=' + bugID); window.parent.$.apps.open(link, 'execution'); } else if(executionID == 0) diff --git a/module/bug/lang/en.php b/module/bug/lang/en.php index 82bacdeb8b..ce50184388 100644 --- a/module/bug/lang/en.php +++ b/module/bug/lang/en.php @@ -428,10 +428,11 @@ $lang->bug->featureBar['browse']['unclosed'] = $lang->bug->unclosed; $lang->bug->featureBar['browse']['openedbyme'] = $lang->bug->openedByMe; $lang->bug->featureBar['browse']['assigntome'] = $lang->bug->assignToMe; $lang->bug->featureBar['browse']['resolvedbyme'] = $lang->bug->resolvedByMe; -$lang->bug->featureBar['browse']['assignedbyme'] = $lang->bug->assignedByMe; + $lang->bug->featureBar['browse']['unresolved'] = $lang->bug->unResolved; $lang->bug->featureBar['browse']['more'] = $lang->more; +$lang->bug->moreSelects['assignedbyme'] = $lang->bug->assignedByMe; $lang->bug->moreSelects['unconfirmed'] = $lang->bug->unconfirmed; $lang->bug->moreSelects['assigntonull'] = $lang->bug->assignToNull; $lang->bug->moreSelects['longlifebugs'] = $lang->bug->longLifeBugs; diff --git a/module/bug/lang/zh-cn.php b/module/bug/lang/zh-cn.php index e8c8889894..da4082ab33 100644 --- a/module/bug/lang/zh-cn.php +++ b/module/bug/lang/zh-cn.php @@ -432,6 +432,7 @@ $lang->bug->featureBar['browse']['assignedbyme'] = $lang->bug->assignedByMe; $lang->bug->featureBar['browse']['unresolved'] = $lang->bug->unResolved; $lang->bug->featureBar['browse']['more'] = $lang->more; + $lang->bug->moreSelects['unconfirmed'] = $lang->bug->unconfirmed; $lang->bug->moreSelects['assigntonull'] = $lang->bug->assignToNull; $lang->bug->moreSelects['longlifebugs'] = $lang->bug->longLifeBugs; diff --git a/module/bug/model.php b/module/bug/model.php index 870b16e798..251cb0596c 100644 --- a/module/bug/model.php +++ b/module/bug/model.php @@ -1619,10 +1619,7 @@ class bugModel extends model if($moduleName == 'contributeBug') { $bugsAssignedByMe = $this->loadModel('my')->getAssignedByMe($account, 0, $pager, $orderBy, 0, 'bug'); - foreach($bugsAssignedByMe as $bugID => $bug) - { - $bugIDList[$bugID] = $bugID; - } + foreach($bugsAssignedByMe as $bugID => $bug) $bugIDList[$bugID] = $bugID; } if($queryID) diff --git a/module/common/model.php b/module/common/model.php index 9ce8e55520..e2a5804e90 100644 --- a/module/common/model.php +++ b/module/common/model.php @@ -46,23 +46,23 @@ class commonModel extends model public function syncPPEStatus($objectID) { global $app; - $thisModule = $app->rawModule; + $rawModule = $app->rawModule; if($this->config->systemMode == 'classic') { - if($thisModule == 'task') $this->syncExecutionStatus($objectID); + if($rawModule == 'task') $this->syncExecutionStatus($objectID); } if($this->config->systemMode == 'new') { - if($thisModule == 'task' or $thisModule == 'effort') + if($rawModule == 'task' or $rawModule == 'effort') { $taskID = $objectID; $execution = $this->syncExecutionStatus($taskID); $project = $this->syncProjectStatus($execution); $this->syncProgramStatus($project); } - if($thisModule == 'execution') + if($rawModule == 'execution') { $executionID = $objectID; $execution = $this->dao->select('id, project, grade, parent')->from(TABLE_EXECUTION)->where('id')->eq($executionID)->fetch(); @@ -70,13 +70,13 @@ class commonModel extends model $project = $this->syncProjectStatus($execution); $this->syncProgramStatus($project); } - if($thisModule == 'project') + if($rawModule == 'project') { $projectID = $objectID; $project = $this->dao->select('id, parent, path')->from(TABLE_PROJECT)->where('id')->eq($projectID)->fetch(); $this->syncProgramStatus($project); } - if($thisModule == 'program') + if($rawModule == 'program') { $programID = $objectID; $program = $this->dao->select('id, parent, path')->from(TABLE_PROGRAM)->where('id')->eq($programID)->fetch(); diff --git a/module/common/view/action.html.php b/module/common/view/action.html.php index dda0ecae69..b07da8587d 100755 --- a/module/common/view/action.html.php +++ b/module/common/view/action.html.php @@ -7,9 +7,6 @@