From 2564d2d60beca3fe0e92a58094b5351fc45be38c Mon Sep 17 00:00:00 2001 From: zenggang Date: Mon, 20 Jun 2022 09:27:56 +0000 Subject: [PATCH 01/10] * Finish task#57903 --- module/doc/control.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/module/doc/control.php b/module/doc/control.php index 9f6a58abb5..a228f4f577 100755 --- a/module/doc/control.php +++ b/module/doc/control.php @@ -871,9 +871,10 @@ class doc extends control if($doclib->acl == 'custom') { - return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control")); + return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control'")); } - if($doclib->acl == 'open') return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control")); + + if($doclib->acl == 'open') return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control'")); if($doclib->acl == 'private') echo 'private'; if($doclib->acl == 'default') echo 'default'; return false; From dff6937dc479ef921418feccc7f9238aa2b011f5 Mon Sep 17 00:00:00 2001 From: zenggang Date: Mon, 20 Jun 2022 09:29:29 +0000 Subject: [PATCH 02/10] * Adjust code --- module/doc/control.php | 1 - 1 file changed, 1 deletion(-) diff --git a/module/doc/control.php b/module/doc/control.php index a228f4f577..46b0872f57 100755 --- a/module/doc/control.php +++ b/module/doc/control.php @@ -873,7 +873,6 @@ class doc extends control { return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control'")); } - if($doclib->acl == 'open') return print(html::select('users[]', $users, $selectedUser, "multiple class='form-control'")); if($doclib->acl == 'private') echo 'private'; if($doclib->acl == 'default') echo 'default'; From b761aa029bcb07d6f4f35b3ab9670aa7bbe431f7 Mon Sep 17 00:00:00 2001 From: zenggang Date: Tue, 21 Jun 2022 02:50:55 +0000 Subject: [PATCH 03/10] * Finish task #57907 --- module/install/model.php | 10 ++++++++++ module/install/view/step5.html.php | 5 +++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/module/install/model.php b/module/install/model.php index 794df3de6d..8d4b8d65c3 100644 --- a/module/install/model.php +++ b/module/install/model.php @@ -516,6 +516,16 @@ class installModel extends model } } + /* Check password. */ + if(!validater::checkReg($this->post->password, '|(.){6,}|')) dao::$errors['password'][] = $this->lang->error->passwordrule; + if(isset($this->config->safe->mode) and (strlen($this->post->password) < $this->config->safe->mode)) dao::$errors['password'][] = $this->lang->user->weakPassword; + if(!empty($this->config->safe->changeWeak)) + { + if(!isset($this->config->safe->weak)) $this->app->loadConfig('admin'); + if(strpos(",{$this->config->safe->weak},", ",{$this->post->password},") !== false) dao::$errors['password'][] = sprintf($this->lang->user->errorWeak, $this->config->safe->weak); + } + if(dao::isError()) return false; + /* Insert a company. */ $company = new stdclass(); $company->name = $data->company; diff --git a/module/install/view/step5.html.php b/module/install/view/step5.html.php index 91ab940ac3..71af2e7ba8 100644 --- a/module/install/view/step5.html.php +++ b/module/install/view/step5.html.php @@ -46,7 +46,7 @@
- +
@@ -61,7 +61,8 @@ - + + From fae27b266a5a95af57d83907c50ceb6b05b39ddb Mon Sep 17 00:00:00 2001 From: zenggang Date: Tue, 21 Jun 2022 03:26:37 +0000 Subject: [PATCH 04/10] * Finish task #57909 --- module/testsuite/control.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/testsuite/control.php b/module/testsuite/control.php index ce81242869..7f10daebfd 100644 --- a/module/testsuite/control.php +++ b/module/testsuite/control.php @@ -74,7 +74,7 @@ class testsuite extends control $sort = common::appendOrder($orderBy); $productName = isset($this->products[$productID]) ? $this->products[$productID] : ''; - $suites = $this->testsuite->getSuites($productID, $sort, $pager, 'all'); + $suites = $this->testsuite->getSuites($productID, $sort, $pager); if(empty($suites) and $pageID > 1) { $pager = pager::init(0, $recPerPage, 1); From d97b5aeb97e0d441f86ef0781d719339eac51542 Mon Sep 17 00:00:00 2001 From: mayue Date: Tue, 21 Jun 2022 13:30:00 +0800 Subject: [PATCH 05/10] * Fix bug #23765. --- module/build/view/view.html.php | 2 +- module/execution/control.php | 15 +++++++++++++++ module/execution/js/kanban.js | 2 +- module/execution/js/taskkanban.js | 2 +- module/execution/lang/en.php | 1 + module/execution/lang/zh-cn.php | 1 + module/execution/model.php | 2 +- module/execution/view/importtask.html.php | 4 ++-- module/execution/view/linkstory.html.php | 2 +- module/execution/view/story.html.php | 2 +- module/execution/view/storykanban.html.php | 2 +- module/execution/view/treestory.html.php | 6 +++--- module/group/lang/resource.php | 1 + module/story/model.php | 2 +- module/story/view/view.html.php | 2 +- module/task/view/view.html.php | 2 +- 16 files changed, 33 insertions(+), 15 deletions(-) diff --git a/module/build/view/view.html.php b/module/build/view/view.html.php index 00bf20a69a..4aa19b8b94 100644 --- a/module/build/view/view.html.php +++ b/module/build/view/view.html.php @@ -93,7 +93,7 @@ tbody tr td:first-child input {display: none;} app->tab == 'execution' ? $build->execution : $build->project;?> $story):?> - createLink('story', 'view', "storyID=$story->id&version=0¶m=$objectID", '', true);?> + app->tab == 'execution' ? $this->createLink('execution', 'storyView', "storyID=$story->id", '', true) : $this->createLink('story', 'view', "storyID=$story->id&version=0¶m=$objectID", '', true);?> - createLink('story', 'view', "storyID=$story->id", '', true);?> + createLink('execution', 'storyView', "storyID=$story->id", '', true);?> $story):?> createLink('story', 'view', "storyID=$story->id&version=$story->version¶m=$execution->id"); + $storyLink = $this->createLink('execution', 'storyView', "storyID=$story->id&version=$story->version¶m=$execution->id"); $totalEstimate += $story->estimate; ?> diff --git a/module/execution/view/storykanban.html.php b/module/execution/view/storykanban.html.php index 10dce6e821..da91fd5b40 100644 --- a/module/execution/view/storykanban.html.php +++ b/module/execution/view/storykanban.html.php @@ -80,7 +80,7 @@ $account = $this->app->user->account;
- createLink('story', 'view', "story=$story->id", '', true), "#{$story->id} {$story->title}", '', 'class="title kanbaniframe" title="' . $story->title . '"');?> + createLink('execution', 'storyView', "story=$story->id", '', true), "#{$story->id} {$story->title}", '', 'class="title kanbaniframe" title="' . $story->title . '"');?>
story->priList, $story->pri);?> story->statusList[$story->status];?> diff --git a/module/execution/view/treestory.html.php b/module/execution/view/treestory.html.php index 0f82be8180..c7aafbeae6 100644 --- a/module/execution/view/treestory.html.php +++ b/module/execution/view/treestory.html.php @@ -89,7 +89,7 @@ { foreach($story->planTitle as $planID => $planTitle) { - if(!common::printLink('productplan', 'view', "planID=$planID", $planTitle)) echo $lanTitle; + if(!common::printLink('productplan', 'view', "planID=$planID", $planTitle)) echo $planTitle; echo '
'; } } @@ -258,7 +258,7 @@ extraStories[$linkStoryID])) echo '
  • ' . html::a($this->createLink('story', 'view', "storyID=$linkStoryID"), "#$linkStoryID " . $story->extraStories[$linkStoryID]) . '
    • '; + if(isset($story->extraStories[$linkStoryID])) echo '
  • ' . html::a($this->createLink('execution', 'storyView', "storyID=$linkStoryID"), "#$linkStoryID " . $story->extraStories[$linkStoryID]) . '
    • '; } ?> @@ -276,7 +276,7 @@ extraStories[$childStoryID])) echo '
  • ' . html::a($this->createLink('story', 'view', "storyID=$childStoryID"), "#$childStoryID " . $story->extraStories[$childStoryID]) . '
    • '; + if(isset($story->extraStories[$childStoryID])) echo '
  • ' . html::a($this->createLink('execution', 'storyView', "storyID=$childStoryID"), "#$childStoryID " . $story->extraStories[$childStoryID]) . '
    • '; } ?> diff --git a/module/group/lang/resource.php b/module/group/lang/resource.php index 32e10087ca..7c00e40205 100644 --- a/module/group/lang/resource.php +++ b/module/group/lang/resource.php @@ -769,6 +769,7 @@ $lang->resource->execution->whitelist = 'whitelist'; $lang->resource->execution->addWhitelist = 'addWhitelist'; $lang->resource->execution->unbindWhitelist = 'unbindWhitelist'; $lang->resource->execution->storyEstimate = 'storyEstimate'; +$lang->resource->execution->storyView = 'storyView'; if($config->systemMode == 'new') $lang->resource->execution->executionkanban = 'kanbanAction'; $lang->resource->execution->kanban = 'RDKanban'; //if($config->systemMode == 'classic') $lang->resource->project->list = 'list'; diff --git a/module/story/model.php b/module/story/model.php index 4dbd940f30..3f77567870 100644 --- a/module/story/model.php +++ b/module/story/model.php @@ -4137,7 +4137,7 @@ class storyModel extends model $canView = common::hasPriv($module, 'view'); $tab = $this->app->tab; $executionID = empty($execution) ? $this->session->execution : $execution->id; - $storyLink = $tab == 'execution' ? helper::createLink('story', 'view', "storyID=$story->id&version=$story->version¶m=$executionID") : helper::createLink($module, 'view', "storyID=$story->id"); + $storyLink = $tab == 'execution' ? helper::createLink('execution', 'storyView', "storyID=$story->id") : helper::createLink($module, 'view', "storyID=$story->id"); $account = $this->app->user->account; /* Check the product is closed. */ diff --git a/module/story/view/view.html.php b/module/story/view/view.html.php index fa43cce231..c2a92ef17e 100644 --- a/module/story/view/view.html.php +++ b/module/story/view/view.html.php @@ -268,7 +268,7 @@ { foreach($story->planTitle as $planID => $planTitle) { - if(!common::printLink('productplan', 'view', "planID=$planID", $planTitle, '', "data-app='product'")) echo $lanTitle; + if(!common::printLink('productplan', 'view', "planID=$planID", $planTitle, '', "data-app='product'")) echo $planTitle; echo '
    '; } } diff --git a/module/task/view/view.html.php b/module/task/view/view.html.php index 9393cd8ea1..3796adebe0 100644 --- a/module/task/view/view.html.php +++ b/module/task/view/view.html.php @@ -246,7 +246,7 @@ storyTitle) echo $lang->noData; $class = isonlybody() ? 'showinonlybody' : 'iframe'; - if($task->storyTitle and !common::printLink('story', 'view', "storyID=$task->story", $task->storyTitle, '', "class=$class data-width='80%'", true, true)) echo $task->storyTitle; + if($task->storyTitle and !common::printLink('execution', 'storyView', "storyID=$task->story", $task->storyTitle, '', "class=$class data-width='80%'", true, true)) echo $task->storyTitle; if($task->needConfirm) { echo "({$lang->story->changed} "; From 83ecf656d3e8ba7dfff9f0725bf70c954d9d0edf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E6=80=A1=E6=A0=8B?= Date: Tue, 21 Jun 2022 06:07:46 +0000 Subject: [PATCH 06/10] Merge branch 'sgm_parentplan' into 'master' * Code for feedback #397. See merge request easycorp/zentaopms!4033 (cherry picked from commit beaddb012c3dc8ef07e7bd5c754ae7d991758971) f0c23584 * Code for feedback #397. --- module/execution/model.php | 7 ++----- module/productplan/model.php | 24 ++++++++++-------------- 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/module/execution/model.php b/module/execution/model.php index ad8cf6b43e..024a6c7eca 100644 --- a/module/execution/model.php +++ b/module/execution/model.php @@ -3984,18 +3984,15 @@ class executionModel extends model ->where('product')->in(array_keys($products)) ->andWhere('deleted')->eq(0) ->andWhere('branch')->in($branchIdList)->fi() - ->beginIF(strpos($param, 'skipparent') !== false)->andWhere('parent')->ne(-1)->fi() ->orderBy('begin desc') ->fetchAll('id'); $plans = $this->productplan->reorder4Children($plans); $productPlans = array(); - $parentTitle = array(); foreach($plans as $plan) { - if($plan->parent == '-1') $parentTitle[$plan->id] = $plan->title; - if($plan->parent > 0 and isset($parentTitle[$plan->parent])) $plan->title = $parentTitle[$plan->parent] . ' /' . $plan->title; - + if($plan->parent == '-1' and strpos($param, 'skipparent') !== false) continue; + if($plan->parent > 0 and isset($plans[$plan->parent])) $plan->title = $plans[$plan->parent]->title . ' /' . $plan->title; $productPlans[$plan->product][$plan->id] = $plan->title . " [{$plan->begin} ~ {$plan->end}]"; if($plan->begin == '2030-01-01' and $plan->end == '2030-01-01') $productPlans[$plan->product][$plan->id] = $plan->title . ' ' . $this->lang->productplan->future; } diff --git a/module/productplan/model.php b/module/productplan/model.php index be0161beef..6ce103d1fc 100644 --- a/module/productplan/model.php +++ b/module/productplan/model.php @@ -247,18 +247,13 @@ class productplanModel extends model ->orderBy('t1.begin desc') ->fetchAll('id'); - $plans = $this->reorder4Children($plans); - $planPairs = array(); - $parentTitle = array(); + $plans = $this->reorder4Children($plans); + $planPairs = array(); $this->app->loadLang('branch'); foreach($plans as $plan) { - if($plan->parent == '-1') - { - $parentTitle[$plan->id] = $plan->title; - if($skipParent) continue; - } - if($plan->parent > 0 and isset($parentTitle[$plan->parent])) $plan->title = $parentTitle[$plan->parent] . ' /' . $plan->title; + if($skipParent and $plan->parent == '-1') continue; + if($plan->parent > 0 and isset($plans[$plan->parent])) $plan->title = $plans[$plan->parent]->title . ' /' . $plan->title; $planPairs[$plan->id] = $plan->title . " [{$plan->begin} ~ {$plan->end}]"; if($plan->begin == $this->config->productplan->future and $plan->end == $this->config->productplan->future) $planPairs[$plan->id] = $plan->title . ' ' . $this->lang->productplan->future; if($plan->productType != 'normal') $planPairs[$plan->id] = ($plan->branchName ? $plan->branchName : $this->lang->branch->main) . ' / ' . $planPairs[$plan->id]; @@ -351,7 +346,6 @@ class productplanModel extends model $plans = $this->dao->select('*')->from(TABLE_PRODUCTPLAN) ->where('deleted')->eq(0) ->beginIF($products)->andWhere('product')->in($products)->fi() - ->beginIF(strpos($param, 'skipparent') !== false)->andWhere('parent')->ne(-1)->fi() ->beginIF(strpos($param, 'unexpired') !== false)->andWhere('end')->ge($date)->fi() ->orderBy($orderBy) ->fetchAll('id'); @@ -366,8 +360,8 @@ class productplanModel extends model if($field == 'name') { - if($plan->parent == '-1') $parentTitle[$plan->id] = $plan->title; - if($plan->parent > 0 and isset($parentTitle[$plan->parent])) $plan->title = $parentTitle[$plan->parent] . ' /' . $plan->title; + if($plan->parent == '-1' and strpos($param, 'skipparent') !== false) continue; + if($plan->parent > 0 and isset($plans[$plan->parent])) $plan->title = $plans[$plan->parent]->title . ' /' . $plan->title; $planGroup[$plan->product][$plan->branch][$plan->id] = $plan->title . " [{$plan->begin} ~ {$plan->end}]"; if($plan->begin == $this->config->productplan->future and $plan->end == $this->config->productplan->future) $planGroup[$plan->product][$plan->branch][$plan->id] = $plan->title . ' ' . $this->lang->productplan->future; } @@ -419,17 +413,19 @@ class productplanModel extends model */ public function getBranchPlanPairs($productID, $branches = '', $skipParent = false) { - $plans = $this->dao->select('branch,id,title,begin,end')->from(TABLE_PRODUCTPLAN) + $plans = $this->dao->select('parent,branch,id,title,begin,end')->from(TABLE_PRODUCTPLAN) ->where('product')->eq($productID) ->andWhere('deleted')->eq(0) ->beginIF($branches != '')->andWhere('branch')->in($branches)->fi() - ->beginIF($skipParent)->andWhere('parent')->ne(-1)->fi() ->orderBy('begin desc') ->fetchAll('id'); $planPairs = array(); foreach($plans as $planID => $plan) { + if($skipParent and $plan->parent == '-1') continue; + + if($plan->parent > 0 and isset($plans[$plan->parent])) $plan->title = $plans[$plan->parent]->title . ' /' . $plan->title; $planPairs[$plan->branch][$planID] = $plan->title . ' [' . $plan->begin . '~' . $plan->end . ']'; } return $planPairs; From 4a09c0e82ceff33532fcea214f7bd3d033768d97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=8E=8B=E6=80=A1=E6=A0=8B?= Date: Tue, 21 Jun 2022 06:09:37 +0000 Subject: [PATCH 07/10] Merge branch 'sgm_fixbug' into 'master' * Finish task #57904. See merge request easycorp/zentaopms!4034 (cherry picked from commit 7009548c689d4188c55f14e5a6c232d355f8e8dc) f5ff0975 * Finish task #57904. --- module/kanban/control.php | 13 ++++++++----- module/kanban/view/editcard.html.php | 2 +- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/module/kanban/control.php b/module/kanban/control.php index 0d921abfbd..838dd0141d 100644 --- a/module/kanban/control.php +++ b/module/kanban/control.php @@ -917,6 +917,7 @@ class kanban extends control public function editCard($cardID) { $this->loadModel('action'); + $this->loadModel('user'); if(!empty($_POST)) { $changes = $this->kanban->updateCard($cardID); @@ -934,12 +935,14 @@ class kanban extends control $card = $this->kanban->getCardByID($cardID); $kanban = $this->kanban->getById($card->kanban); $kanbanUsers = $card->kanban == 0 ? ',' : trim($kanban->owner) . ',' . trim($kanban->team); - $users = $this->loadModel('user')->getPairs('noclosed|nodeleted', '', 0, $kanbanUsers); + $kanbanUsers = $this->user->getPairs('noclosed|nodeleted', '', 0, $kanbanUsers); + $users = $this->user->getPairs('noclosed|nodeleted'); - $this->view->card = $card; - $this->view->actions = $this->action->getList('kanbancard', $cardID); - $this->view->users = $users; - $this->view->kanban = $kanban; + $this->view->card = $card; + $this->view->actions = $this->action->getList('kanbancard', $cardID); + $this->view->users = $users; + $this->view->kanbanUsers = $kanbanUsers; + $this->view->kanban = $kanban; $this->display(); } diff --git a/module/kanban/view/editcard.html.php b/module/kanban/view/editcard.html.php index ae80ea5add..680e1fb506 100644 --- a/module/kanban/view/editcard.html.php +++ b/module/kanban/view/editcard.html.php @@ -48,7 +48,7 @@
    install->company;?>
    install->password;?>user->placeholder->password1;?>
    install->importDemoData);?>
    diff --git a/module/execution/control.php b/module/execution/control.php index 16bcba9dba..d215edae8c 100644 --- a/module/execution/control.php +++ b/module/execution/control.php @@ -871,6 +871,21 @@ class execution extends control $this->display(); } + /** + * View a story. + * + * @param int $storyID + * @access public + * @return void + */ + public function storyView($storyID) + { + $this->session->set('productList', $this->app->getURI(true), 'product'); + + $story = $this->loadModel('story')->getByID($storyID); + echo $this->fetch('story', 'view', "storyID=$storyID&version=$story->version¶m=" . $this->session->execution); + } + /** * Browse bugs of a execution. * diff --git a/module/execution/js/kanban.js b/module/execution/js/kanban.js index 9d1c806453..4ee4827f82 100644 --- a/module/execution/js/kanban.js +++ b/module/execution/js/kanban.js @@ -501,7 +501,7 @@ function renderStoryItem(item, $item, col) if(!$title.length) { $title = $('' + (scaleSize <= 1 ? ' ' : '') + '') - .attr('href', $.createLink('story', 'view', 'storyID=' + item.id + '&version=0¶m=' + execution.id, '', true)).attr('data-toggle', 'modal').attr('data-width', '95%'); + .attr('href', $.createLink('execution', 'storyView', 'storyID=' + item.id + '&version=0¶m=' + execution.id, '', true)).attr('data-toggle', 'modal').attr('data-width', '95%'); $title.appendTo($item); } var title = rdSearchValue != '' ? "" + item.title.replaceAll(rdSearchValue, "" + rdSearchValue + "") + "": "" + item.title + ""; diff --git a/module/execution/js/taskkanban.js b/module/execution/js/taskkanban.js index 8af14dd812..6b6db71515 100644 --- a/module/execution/js/taskkanban.js +++ b/module/execution/js/taskkanban.js @@ -123,7 +123,7 @@ function renderStoryItem(item, $item, col) if(!$title.length) { $title = $('' + (scaleSize <= 1 ? ' ' : '') + '') - .attr('href', $.createLink('story', 'view', 'storyID=' + item.id, '', true)); + .attr('href', $.createLink('execution', 'storyView', 'storyID=' + item.id, '', true)); $title.appendTo($item); } var title = searchValue != '' ? "" + item.title.replaceAll(searchValue, "" + searchValue + "") + "": "" + item.title + ""; diff --git a/module/execution/lang/en.php b/module/execution/lang/en.php index c1069f6169..4b79d498cd 100644 --- a/module/execution/lang/en.php +++ b/module/execution/lang/en.php @@ -94,6 +94,7 @@ $lang->execution->viewBug = 'Bugs'; $lang->execution->noProduct = "No {$lang->productCommon} yet."; $lang->execution->createStory = "Create Story"; $lang->execution->storyTitle = "Story Name"; +$lang->execution->storyView = "Story Detail"; $lang->execution->all = "All {$lang->executionCommon}s"; $lang->execution->undone = 'Unfinished '; $lang->execution->unclosed = 'Unclosed'; diff --git a/module/execution/lang/zh-cn.php b/module/execution/lang/zh-cn.php index b026756280..f23b9267e7 100644 --- a/module/execution/lang/zh-cn.php +++ b/module/execution/lang/zh-cn.php @@ -94,6 +94,7 @@ $lang->execution->viewBug = '查看bug'; $lang->execution->noProduct = "无{$lang->executionCommon}"; $lang->execution->createStory = "提{$lang->SRCommon}"; $lang->execution->storyTitle = "{$lang->SRCommon}名称"; +$lang->execution->storyView = "{$lang->SRCommon}详情"; $lang->execution->all = '所有'; $lang->execution->undone = '未完成'; $lang->execution->unclosed = '未关闭'; diff --git a/module/execution/model.php b/module/execution/model.php index ad8cf6b43e..3ba77a78ee 100644 --- a/module/execution/model.php +++ b/module/execution/model.php @@ -3848,7 +3848,7 @@ class executionModel extends model $storyItem->storyId = $story->id; $storyItem->openedBy = zget($users, $story->openedBy); $storyItem->assignedTo = zget($users, $story->assignedTo); - $storyItem->url = helper::createLink('story', 'view', "storyID=$story->id&version=$story->version&from=execution¶m=$executionID"); + $storyItem->url = helper::createLink('execution', 'storyView', "storyID=$story->id&version=$story->version&from=execution¶m=$executionID"); $storyItem->taskCreateUrl = helper::createLink('task', 'batchCreate', "executionID={$executionID}&story={$story->id}"); $storyTasks = isset($taskGroups[$node->id][$story->id]) ? $taskGroups[$node->id][$story->id] : array(); diff --git a/module/execution/view/importtask.html.php b/module/execution/view/importtask.html.php index a818ff5e31..e213308fb6 100644 --- a/module/execution/view/importtask.html.php +++ b/module/execution/view/importtask.html.php @@ -69,9 +69,9 @@ storyID) { - if(common::hasPriv('story', 'view')) + if(common::hasPriv('execution', 'storyView')) { - echo html::a($this->createLink('story', 'view', "storyid=$task->storyID"), $task->storyTitle, '', "class='preview'", true, isonlybody()); + echo html::a($this->createLink('execution', 'storyView', "storyid=$task->storyID"), $task->storyTitle, '', "class='preview'", true, isonlybody()); } else { diff --git a/module/execution/view/linkstory.html.php b/module/execution/view/linkstory.html.php index a95462dfd7..cf48937571 100644 --- a/module/execution/view/linkstory.html.php +++ b/module/execution/view/linkstory.html.php @@ -55,7 +55,7 @@
    id => sprintf('%03d', $story->id)));?> diff --git a/module/execution/view/story.html.php b/module/execution/view/story.html.php index 016866e4c4..32161a7501 100644 --- a/module/execution/view/story.html.php +++ b/module/execution/view/story.html.php @@ -215,7 +215,7 @@
    - + From 5f26b603e7e58eec53503357aae6e031ca78f2ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AD=99=E5=B9=BF=E6=98=8E?= Date: Tue, 21 Jun 2022 15:22:12 +0800 Subject: [PATCH 08/10] * Code for bug #24007. --- module/project/model.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/module/project/model.php b/module/project/model.php index 80b0e598b8..5087ab26de 100644 --- a/module/project/model.php +++ b/module/project/model.php @@ -1868,9 +1868,7 @@ class projectModel extends model $projectType = 'project'; $accounts = array_unique($accounts); $oldJoin = $this->dao->select('`account`, `join`')->from(TABLE_TEAM)->where('root')->eq($projectID)->andWhere('type')->eq($projectType)->fetchPairs(); - $this->dao->delete()->from(TABLE_TEAM)->where('root')->eq($projectID)->andWhere('type')->eq($projectType)->exec(); - $projectMember = array(); foreach($accounts as $key => $account) { if(empty($account)) continue; @@ -1885,6 +1883,14 @@ class projectModel extends model dao::$errors['message'][] = $this->lang->project->errorHours; return false; } + } + + $this->dao->delete()->from(TABLE_TEAM)->where('root')->eq($projectID)->andWhere('type')->eq($projectType)->exec(); + + $projectMember = array(); + foreach($accounts as $key => $account) + { + if(empty($account)) continue; $member = new stdclass(); $member->role = $roles[$key]; From a0fd4314017219c92112a07d279d5e354e985a2d Mon Sep 17 00:00:00 2001 From: mayue Date: Tue, 21 Jun 2022 15:23:12 +0800 Subject: [PATCH 09/10] * Optimize code. --- module/story/model.php | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/module/story/model.php b/module/story/model.php index 3f77567870..8f3637d296 100644 --- a/module/story/model.php +++ b/module/story/model.php @@ -4133,12 +4133,22 @@ class storyModel extends model */ public function printCell($col, $story, $users, $branches, $storyStages, $modulePairs = array(), $storyTasks = array(), $storyBugs = array(), $storyCases = array(), $mode = 'datatable', $storyType = 'story', $execution = '', $isShowBranch = '') { - $module = $this->app->rawModule == 'product' ? 'story' : $this->app->rawModule; - $canView = common::hasPriv($module, 'view'); $tab = $this->app->tab; $executionID = empty($execution) ? $this->session->execution : $execution->id; - $storyLink = $tab == 'execution' ? helper::createLink('execution', 'storyView', "storyID=$story->id") : helper::createLink($module, 'view', "storyID=$story->id"); $account = $this->app->user->account; + $storyLink = helper::createLink('story', 'view', "storyID=$story->id"); + $canView = common::hasPriv('story', 'view'); + + if($tab == 'project') + { + $storyLink = helper::createLink('projectstory', 'view', "storyID=$story->id"); + $canView = common::hasPriv('projectstory', 'view'); + } + elseif($tab == 'execution') + { + $storyLink = helper::createLink('execution', 'storyView', "storyID=$story->id"); + $canView = common::hasPriv('execution', 'storyView'); + } /* Check the product is closed. */ $canBeChanged = common::canBeChanged('story', $story); From 3b7746915f729058bc9fe4a7754a0415d2e7ee62 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AD=99=E5=B9=BF=E6=98=8E?= Date: Tue, 21 Jun 2022 17:16:24 +0800 Subject: [PATCH 10/10] * Fix bug for release pager. --- module/release/control.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/release/control.php b/module/release/control.php index a68c808123..c601da2de4 100644 --- a/module/release/control.php +++ b/module/release/control.php @@ -197,7 +197,7 @@ class release extends control ->fetchAll('id'); $this->loadModel('common')->saveQueryCondition($this->dao->get(), 'story'); - $stages = $this->dao->select('*')->from(TABLE_STORYSTAGE)->where('story')->in($release->stories)->andWhere('branch')->eq($release->branch)->fetchPairs('story', 'stage'); + $stages = $this->dao->select('*')->from(TABLE_STORYSTAGE)->where('story')->in(array_keys($stories))->andWhere('branch')->eq($release->branch)->fetchPairs('story', 'stage'); foreach($stages as $storyID => $stage)$stories[$storyID]->stage = $stage; $bugPager = new pager($type == 'bug' ? $recTotal : 0, $recPerPage, $type == 'bug' ? $pageID : 1);
    kanbancard->assignedTo;?>assignedTo, "class='form-control chosen' multiple");?>assignedTo, "class='form-control chosen' multiple");?>
    kanbancard->begin;?>