From 78d36ea73902f0dd3f5b16593f7d2d9e0353f961 Mon Sep 17 00:00:00 2001
From: holan20180123 <56391770@qq.com>
Date: Sun, 7 Nov 2021 20:45:50 +0800
Subject: [PATCH 1/3]  * Fix error of kanban session.

---
 module/execution/control.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/module/execution/control.php b/module/execution/control.php
index 6f2b721068..e7e4d2b3fb 100644
--- a/module/execution/control.php
+++ b/module/execution/control.php
@@ -1834,7 +1834,7 @@ class execution extends control
     public function kanban($executionID, $browseType = '', $orderBy = 'order_asc', $groupBy = '')
     {
         if(empty($browseType)) $browseType = $this->session->kanbanType ? $this->session->kanbanType : 'all';
-        if(empty($groupBy) and $browseType != 'all') $groupBy = $this->session->kanbanGroupBy ? $this->session->kanbanGroupBy : 'default';
+        if(empty($groupBy) and $browseType != 'all') $groupBy = $this->session->{'kanbanGroupBy' . $browseType} ? $this->session->{'kanbanGroupBy' . $browseType} : 'default';
         if(empty($groupBy) and $browseType == 'all') $groupBy = 'default';
 
         /* Save to session. */
@@ -1842,7 +1842,7 @@ class execution extends control
         $this->app->session->set('taskList', $uri, 'execution');
         $this->app->session->set('bugList',  $uri, 'qa');
         $this->app->session->set('kanbanType', $browseType, 'execution');
-        $this->app->session->set('kanbanGroupBy', $groupBy, 'execution');
+        $this->app->session->set('kanbanGroupBy' . $browseType, $groupBy, 'execution');
 
         /* Load language. */
         $this->app->loadLang('story');

From d188fbd7b8e5f133bc3a7cc8a20dc8ec056485e5 Mon Sep 17 00:00:00 2001
From: liyuchun <563917701@qq.com>
Date: Thu, 18 Nov 2021 22:54:48 +0800
Subject: [PATCH 2/3]  * Fix bug #16389,#16387.

---
 module/bug/css/create.css       | 8 +++++---
 module/bug/view/create.html.php | 4 ++--
 module/personnel/model.php      | 2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/module/bug/css/create.css b/module/bug/css/create.css
index 1009ffdf84..8328045519 100644
--- a/module/bug/css/create.css
+++ b/module/bug/css/create.css
@@ -45,6 +45,8 @@ html[lang='en'] #deadlineTd .input-group-addon {padding: 5px 18px;}
 #osBox .required:after {right: 1px;}
 #osBox {width: 190px;}
 #projectBox .required:after {right: 1px;}
-#assignedTo_chosen {width: 153px !important; float: left;}
-#assignedBox .load-all-user {float: left;}
-#assignedBox .load-all-user .btn {border-left: none;}
+#assignedTo_chosen, .load-all-user {float: left;;}
+.assigned-box #assignedTo_chosen {width: 81% !important;}
+.deadline-box #assignedTo_chosen {width: 153px !important;}
+.assigned-box .load-all-user {float: left;}
+.assigned-box .load-all-user .btn {border-left: none;}
diff --git a/module/bug/view/create.html.php b/module/bug/view/create.html.php
index 39b62fae8f..19c011153d 100644
--- a/module/bug/view/create.html.php
+++ b/module/bug/view/create.html.php
@@ -130,11 +130,11 @@ js::set('moduleID', $moduleID);
             <th><nobr><?php echo $lang->bug->lblAssignedTo;?></nobr></th>
             <td>
               <div class='table-row'>
-                <div class='table-col' id='assignedBox'>
+                <?php $showDeadline = strpos(",$showFields,", ',deadline,') !== false;?>
+                <div class='table-col <?php echo $showDeadline ? 'deadline-box' : 'assigned-box';?>'>
                   <?php echo html::select('assignedTo', $productMembers, $assignedTo, "class='form-control chosen'");?>
                   <span class='input-group-btn load-all-user'><?php echo html::commonButton($lang->bug->allUsers, "class='btn btn-default' onclick='loadAllUsers()' data-toggle='tooltip'");?></span>
                 </div>
-                <?php $showDeadline = strpos(",$showFields,", ',deadline,') !== false;?>
                 <?php if($showDeadline):?>
                 <div class='table-col'>
                   <div class='input-group' id='deadlineBox'>
diff --git a/module/personnel/model.php b/module/personnel/model.php
index 6f0e94e0c0..da8114ed23 100644
--- a/module/personnel/model.php
+++ b/module/personnel/model.php
@@ -607,7 +607,7 @@ class personnelModel extends model
                 if($oldWhitelist) $accounts = array_unique(array_merge($accounts, $oldWhitelist));
             }
         }
-        $whitelist = ',' . implode(',', $accounts);
+        $whitelist = !empty($accounts) ? ',' . implode(',', $accounts) : '';
         $this->dao->update($objectTable)->set('whitelist')->eq($whitelist)->where('id')->eq($objectID)->exec();
 
         $deletedAccounts = array();

From a240c9aa231d2a9aa52142d7c5358a12395b5ec0 Mon Sep 17 00:00:00 2001
From: liyuchun <563917701@qq.com>
Date: Thu, 18 Nov 2021 23:17:15 +0800
Subject: [PATCH 3/3]  * Fix bug #16426,#16393.

---
 module/product/css/view.css       |  2 +-
 module/product/view/view.html.php | 16 ++++++++--------
 module/story/config.php           | 10 ++++++++++
 module/story/model.php            |  6 ++++++
 4 files changed, 25 insertions(+), 9 deletions(-)

diff --git a/module/product/css/view.css b/module/product/css/view.css
index 537f2b58fa..10ad0d71a2 100644
--- a/module/product/css/view.css
+++ b/module/product/css/view.css
@@ -1,6 +1,6 @@
 .branch-list {padding-left: 0; margin: 0;}
 .branch-list > li {float: left; list-style: none; width: 50%; margin: 5px 0;}
-.data-basic.table-data tbody > tr > th {width: 100px;}
+.table-data tbody > tr > th {width: 110px;}
 .col-12 .cell table td {word-wrap: break-word; word-break: normal;}
 td.normal {color: #00da88;}
 td.acl {white-space: nowrap;}
diff --git a/module/product/view/view.html.php b/module/product/view/view.html.php
index 0a37f2d307..dc4add1ff5 100644
--- a/module/product/view/view.html.php
+++ b/module/product/view/view.html.php
@@ -43,7 +43,7 @@
               <table class="table table-data">
                 <tbody>
                   <tr>
-                    <th class='w-65px'><i class="icon icon-person icon-sm"></i> <?php echo $lang->productCommon;?></th>
+                    <th><i class="icon icon-person icon-sm"></i> <?php echo $lang->productCommon;?></th>
                     <td><strong><?php echo zget($users, $product->PO);?></strong></td>
                     <th><i class="icon icon-person icon-sm"></i> <?php echo $lang->product->release;?></th>
                     <td><strong><?php echo zget($users, $product->RD);?></strong></td>
@@ -74,21 +74,21 @@
                 <tbody>
                   <tr>
                     <?php if(!empty($product->code)):?>
-                    <th class="w-80px"><?php echo $lang->product->code;?></th>
+                    <th><?php echo $lang->product->code;?></th>
                     <td><strong><?php echo $product->code;?></strong></td>
                     <?php else:?>
-                    <th class="w-80px"><?php echo $lang->product->type;?></th>
+                    <th><?php echo $lang->product->type;?></th>
                     <td><strong><?php echo zget($lang->product->typeList, $product->type);?></strong></td>
                     <?php endif;?>
-                    <th class="w-80px"><?php echo $lang->story->openedBy?></th>
+                    <th><?php echo $lang->story->openedBy?></th>
                     <td colspan="2"><strong><?php echo zget($users, $product->createdBy);?></strong></td>
                   </tr>
                   <tr>
                     <?php if(!empty($product->code)):?>
-                    <th class="w-80px"><?php echo $lang->product->type;?></th>
+                    <th><?php echo $lang->product->type;?></th>
                     <td><strong><?php echo zget($lang->product->typeList, $product->type);?></strong></td>
                     <?php else:?>
-                    <th class="w-80px"><?php echo $lang->productCommon . $lang->product->status;?></th>
+                    <th><?php echo $lang->productCommon . $lang->product->status;?></th>
                     <td class="<?php echo $product->status;?>"><strong><?php echo zget($lang->product->statusList, $product->status);?></strong></td>
                     <?php endif;?>
                     <th><?php echo $lang->story->openedDate?></th>
@@ -96,7 +96,7 @@
                   </tr>
                   <tr>
                     <?php if(!empty($product->code)):?>
-                    <th class="w-80px"><?php echo $lang->productCommon . $lang->product->status;?></th>
+                    <th><?php echo $lang->productCommon . $lang->product->status;?></th>
                     <td class="<?php echo $product->status;?>"><strong><?php echo zget($lang->product->statusList, $product->status);?></strong></td>
                     <?php endif;?>
                     <th><?php echo $lang->product->acl;?></th>
@@ -130,7 +130,7 @@
                     <td><strong><?php echo $product->stories['active']?></strong></td>
                     <th><?php echo $lang->product->plans?></th>
                     <td><strong><?php echo $product->plans?></strong></td>
-                    <th class='w-80px'><?php echo $lang->product->bugs?></th>
+                    <th><?php echo $lang->product->bugs?></th>
                     <td><strong><?php echo $product->bugs?></strong></td>
                   </tr>
                   <tr>
diff --git a/module/story/config.php b/module/story/config.php
index 537d48e7a2..0269964e27 100644
--- a/module/story/config.php
+++ b/module/story/config.php
@@ -166,6 +166,16 @@ $config->story->datatable->fieldList['lastEditedDate']['fixed']    = 'no';
 $config->story->datatable->fieldList['lastEditedDate']['width']    = '90';
 $config->story->datatable->fieldList['lastEditedDate']['required'] = 'no';
 
+$config->story->datatable->fieldList['feedbackBy']['title']    = 'feedbackBy';
+$config->story->datatable->fieldList['feedbackBy']['fixed']    = 'no';
+$config->story->datatable->fieldList['feedbackBy']['width']    = '100';
+$config->story->datatable->fieldList['feedbackBy']['required'] = 'no';
+
+$config->story->datatable->fieldList['notifyEmail']['title']    = 'notifyEmail';
+$config->story->datatable->fieldList['notifyEmail']['fixed']    = 'no';
+$config->story->datatable->fieldList['notifyEmail']['width']    = '100';
+$config->story->datatable->fieldList['notifyEmail']['required'] = 'no';
+
 $config->story->datatable->fieldList['mailto']['title']    = 'mailto';
 $config->story->datatable->fieldList['mailto']['fixed']    = 'no';
 $config->story->datatable->fieldList['mailto']['width']    = '100';
diff --git a/module/story/model.php b/module/story/model.php
index 601880b177..11c96dd2dd 100644
--- a/module/story/model.php
+++ b/module/story/model.php
@@ -3749,6 +3749,12 @@ class storyModel extends model
             case 'lastEditedDate':
                 echo substr($story->lastEditedDate, 5, 11);
                 break;
+            case 'feedbackBy':
+                echo $story->feedbackBy;
+                break;
+            case 'notifyEmail':
+                echo $story->notifyEmail;
+                break;
             case 'mailto':
                 $mailto = explode(',', $story->mailto);
                 foreach($mailto as $account)