From 1eaf98a48a2b18a8347f0bc7118de97e6dfd3dda Mon Sep 17 00:00:00 2001
From: daitingting <daitingting@xirangit.com>
Date: Thu, 3 Nov 2022 07:58:17 +0000
Subject: [PATCH]  * Fix for #73988, #74180.

---
 module/custom/control.php        |  2 +-
 module/custom/js/mode.js         |  2 +-
 module/custom/view/mode.html.php |  3 ++-
 module/execution/js/edit.js      |  4 ++--
 module/project/js/edit.js        | 14 ++++----------
 5 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/module/custom/control.php b/module/custom/control.php
index 259cbf1873..d0b81f7f15 100644
--- a/module/custom/control.php
+++ b/module/custom/control.php
@@ -650,7 +650,7 @@ class custom extends control
         $this->view->position[] = $this->lang->custom->common;
         $this->view->position[] = $this->view->title;
         $this->view->mode       = $mode;
-        $this->view->program    = $this->loadModel('program')->getTopPairs('', 'noclosed', true);
+        $this->view->programs   = $this->loadModel('program')->getTopPairs('', 'noclosed', true);
         $this->view->programID  = isset($this->config->global->defaultProgram) ? $this->config->global->defaultProgram : 0;
 
         $this->display();
diff --git a/module/custom/js/mode.js b/module/custom/js/mode.js
index e27ffe602c..d62ef0bf1b 100644
--- a/module/custom/js/mode.js
+++ b/module/custom/js/mode.js
@@ -14,7 +14,7 @@ $(function()
         var selectedMode = $('[name=mode]:checked').val();
         if(mode == selectedMode) return false;
 
-        if(selectedMode == 'light')
+        if(selectedMode == 'light' && hasProgram)
         {
             $('#selectProgramModal').modal('show');
         }
diff --git a/module/custom/view/mode.html.php b/module/custom/view/mode.html.php
index 51abcf7274..53737573a6 100644
--- a/module/custom/view/mode.html.php
+++ b/module/custom/view/mode.html.php
@@ -13,6 +13,7 @@
 <?php include '../../common/view/header.html.php';?>
 <?php js::set('changeModeTips', sprintf($lang->custom->changeModeTips, $lang->custom->modeList[$mode == 'light' ? 'ALM' : 'light']));?>
 <?php js::set('mode', $mode);?>
+<?php js::set('hasProgram', !empty($programs));?>
 <div id='mainContent' class='main-content'>
   <form id='modeForm' class="load-indicator main-form form-ajax"  method='post'>
     <div class='main-header'>
@@ -134,7 +135,7 @@
         <table class='table table-form'>
           <tr>
             <th><?php echo $lang->custom->defaultProgram;?></th>
-            <td><?php echo html::select('program', $program, $programID, "class='form-control chosen'");?></td>
+            <td><?php echo html::select('program', $programs, $programID, "class='form-control chosen'");?></td>
           </tr>
         </table>
       </div>
diff --git a/module/execution/js/edit.js b/module/execution/js/edit.js
index c27b7316bb..78d040216c 100644
--- a/module/execution/js/edit.js
+++ b/module/execution/js/edit.js
@@ -41,7 +41,7 @@ $(function()
     {
         var current    = $(this).val();
         var last       = $(this).attr('data-last');
-        var lastBranch = $(this).attr('data-lastBranch');
+        var lastBranch = $(this).attr('data-lastBranch') !== undefined ? $(this).attr('data-lastBranch') : 0;
 
         $(this).attr('data-last', current);
 
@@ -58,7 +58,7 @@ $(function()
 
         if(current != last && $.inArray(last, unmodifiableProducts) != -1)
         {
-            if(lastBranch)
+            if(lastBranch != 0)
             {
                 if($.inArray(lastBranch, unmodifiableBranches) != -1)
                 {
diff --git a/module/project/js/edit.js b/module/project/js/edit.js
index ae82eacb69..4af7b3cf8e 100644
--- a/module/project/js/edit.js
+++ b/module/project/js/edit.js
@@ -43,8 +43,8 @@ $(function()
 
         $(this).attr('data-last', current);
 
-        var $branch  = $(this).closest('.has-branch').find("[name^='branch']");
-        if($branch !== undefined)
+        var $branch = $(this).closest('.has-branch').find("[name^='branch']");
+        if($branch.length)
         {
             var branchID = $branch.val();
             $(this).attr('data-lastBranch', branchID);
@@ -56,15 +56,9 @@ $(function()
 
         if(current != last && $.inArray(last, unmodifiableProducts) != -1)
         {
-            if(lastBranch)
+            if(lastBranch != 0)
             {
-                if($.inArray(lastBranch, unmodifiableBranches) != -1)
-                {
-                    if((lastBranch == 0 && unmodifiableMainBranches[last]) || lastBranch != 0)
-                    {
-                        bootbox.alert(unLinkProductTip.replace("%s", allProducts[last]));
-                    }
-                }
+                if($.inArray(lastBranch, unmodifiableBranches) != -1) bootbox.alert(unLinkProductTip.replace("%s", allProducts[last] + branchGroups[last][lastBranch]));
             }
             else
             {