From 16317913686d5a817dd1ed5354dc7e87ef28bd86 Mon Sep 17 00:00:00 2001
From: liyuchun <liyuchun@easycorp.ltd>
Date: Mon, 1 Nov 2021 16:54:02 +0800
Subject: [PATCH 1/2]  * Fix bug #15887,#15877.

---
 module/execution/js/kanban.js         | 2 +-
 module/execution/view/kanban.html.php | 7 +++++--
 module/kanban/model.php               | 1 +
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/module/execution/js/kanban.js b/module/execution/js/kanban.js
index d8ba9373f4..5673a7c980 100644
--- a/module/execution/js/kanban.js
+++ b/module/execution/js/kanban.js
@@ -547,7 +547,7 @@ function createLaneMenu(options)
     var downTargetKanban = $kanban.next('.kanban').length ? $kanban.next('.kanban').data('id') : '';
 
     var items = [];
-    if(priv.hasSetLane)  items.push({label: kanbanLang.setLane, icon: 'edit', url: $.createLink('kanban', 'setLane', 'lane=' + lane.id + '&executionID=' + executionID), className: 'iframe'});
+    if(priv.hasSetLane)  items.push({label: kanbanLang.setLane, icon: 'edit', url: $.createLink('kanban', 'setLane', 'lane=' + lane.laneID + '&executionID=' + executionID), className: 'iframe'});
     if(priv.hasLaneMove) items.push(
         {label: kanbanLang.moveUp, icon: 'arrow-up', url: $.createLink('kanban', 'laneMove', 'executionID=' + executionID + '&currentLane=' + lane.id + '&targetLane=' + upTargetKanban), className: 'iframe', disabled: !$kanban.prev('.kanban').length},
         {label: kanbanLang.moveDown, icon: 'arrow-down', url: $.createLink('kanban', 'laneMove', 'executionID=' + executionID + '&currentLane=' + lane.id + '&targetLane=' + downTargetKanban), className: 'iframe', disabled: !$kanban.next('.kanban').length}
diff --git a/module/execution/view/kanban.html.php b/module/execution/view/kanban.html.php
index 0070919378..786577be81 100644
--- a/module/execution/view/kanban.html.php
+++ b/module/execution/view/kanban.html.php
@@ -64,6 +64,9 @@
     $canBatchCreateStory = ($productID and common::hasPriv('story', 'batchCreate'));
     $canLinkStory        = ($productID and common::hasPriv('execution', 'linkStory'));
     $canLinkStoryByPlane = ($productID and common::hasPriv('execution', 'importplanstories'));
+    $hasStoryButton      = ($canCreateStory or $canBatchCreateStory or $canLinkStory or $canLinkStoryByPlane);
+    $hasTaskButton       = ($canCreateTask or $canBatchCreateTask);
+    $hasBugButton        = ($canCreateBug or $canBatchCreateBug);
     ?>
     <?php if($canCreateTask or $canBatchCreateTask or $canCreateBug or $canBatchCreateBug or $canCreateStory or $canBatchCreateStory or $canLinkStory or $canLinkStoryByPlane):?>
     <div class='dropdown' id='createDropdown'>
@@ -73,10 +76,10 @@
         <?php if($canBatchCreateStory) echo '<li>' . html::a(helper::createLink('story', 'batchCreate', "productID=$productID&branch=0&moduleID=0&story=0&execution=$execution->id", '', true), $lang->story->batchCreate, '', "class='iframe'") . '</li>';?>
         <?php if($canLinkStory) echo '<li>' . html::a(helper::createLink('execution', 'linkStory', "execution=$execution->id", '', true), $lang->execution->linkStory, '', "class='iframe'") . '</li>';?>
         <?php if($canLinkStoryByPlane) echo '<li>' . html::a('#linkStoryByPlan', $lang->execution->linkStoryByPlan, '', 'data-toggle="modal"') . '</li>';?>
-        <?php if(($canCreateStory or $canBatchCreateStory or $canLinkStory or $canLinkStoryByPlane) and ($canCreateTask or $canBatchCreateTask)) echo '<li class="divider"></li>';?>
+        <?php if($hasStoryButton and $hasTaskButton) echo '<li class="divider"></li>';?>
         <?php if($canCreateTask) echo '<li>' . html::a(helper::createLink('task', 'create', "execution=$execution->id", '', true), $lang->task->create, '', "class='iframe'") . '</li>';?>
         <?php if($canBatchCreateTask) echo '<li>' . html::a(helper::createLink('task', 'batchCreate', "execution=$execution->id", '', true), $lang->task->batchCreate, '', "class='iframe'") . '</li>';?>
-        <?php if(($canCreateTask or $canBatchCreateTask) and ($canCreateBug or $canBatchCreateBug)) echo '<li class="divider"></li>';?>
+        <?php if(($hasStoryButton or $hasTaskButton) and $hasBugButton) echo '<li class="divider"></li>';?>
         <?php if($canCreateBug) echo '<li>' . html::a(helper::createLink('bug', 'create', "productID=$productID&branch=0&extra=executionID=$execution->id", '', true), $lang->bug->create, '', "class='iframe'") . '</li>';?>
         <?php if($canBatchCreateBug) echo '<li>' . html::a(helper::createLink('bug', 'batchCreate', "productID=$productID&branch=0&executionID=$execution->id", '', true), $lang->bug->batchCreate, '', "class='iframe'") . '</li>';?>
       </ul>
diff --git a/module/kanban/model.php b/module/kanban/model.php
index 0100e7fe4d..a298ec8141 100644
--- a/module/kanban/model.php
+++ b/module/kanban/model.php
@@ -68,6 +68,7 @@ class kanbanModel extends model
             $laneType   = $groupBy == 'default' ? $lane->type : $lane->groupby;
 
             $laneData['id']              = $groupBy == 'default' ? $lane->type : $lane->groupby . '-' . $lane->extra;
+            $laneData['laneID']          = $laneID;
             $laneData['name']            = $lane->name;
             $laneData['color']           = $lane->color;
             $laneData['order']           = $lane->order;

From 38fe82e21d3d0155a487dbdce8859a65ed092745 Mon Sep 17 00:00:00 2001
From: liyuchun <liyuchun@easycorp.ltd>
Date: Mon, 1 Nov 2021 16:57:10 +0800
Subject: [PATCH 2/2]  * Fix bug #15874.

---
 module/task/view/create.html.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/module/task/view/create.html.php b/module/task/view/create.html.php
index 8803c62b25..ec518cdf50 100644
--- a/module/task/view/create.html.php
+++ b/module/task/view/create.html.php
@@ -241,10 +241,12 @@
           </td>
         </tr>
         <?php endif;?>
+        <?php if(!isonlybody()):?>
         <tr id='after-tr'>
           <th><?php echo $lang->task->afterSubmit;?></th>
           <td colspan='3'><?php echo html::radio('after', $lang->task->afterChoices, !empty($task->id) ? 'toTaskList' : 'continueAdding');?></td>
         </tr>
+        <?php endif;?>
         <tr>
           <td colspan='4' class='text-center form-actions'>
             <?php echo html::submitButton();?>