From 13b26f2119ea14383236a46aa560e5d945520597 Mon Sep 17 00:00:00 2001 From: liyuchun <563917701@qq.com> Date: Thu, 16 Jun 2022 08:55:46 +0000 Subject: [PATCH 1/2] * Add param when exec pipeline. --- module/mr/model.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/module/mr/model.php b/module/mr/model.php index d36c6e0d30..995ea43fbd 100644 --- a/module/mr/model.php +++ b/module/mr/model.php @@ -301,11 +301,9 @@ class mrModel extends model /* Exec Job */ if($MR->hasNoConflict == '0' && $MR->mergeStatus == 'can_be_merged' && $MR->jobID) { - $extraParam = array(); - if(!empty($repo->fileServerUrl)) $extraParam = array('ZENTAO_REPOPATH' => $repo->fileServerUrl); - - $pipeline = $this->loadModel('job')->exec($MR->jobID, $extraParam); - $newMR = new stdClass(); + $extraParam = array('sourceBranch' => $MR->sourceBranch, 'targetBranch' => $MR->targetBranch); + $pipeline = $this->loadModel('job')->exec($MR->jobID, $extraParam); + $newMR = new stdClass(); if(!empty($pipeline->queue)) { $compile = $this->loadModel('compile')->getByQueue($pipeline->queue); From e447ec9a1154b93992e798b5ea0b4378d14e8e09 Mon Sep 17 00:00:00 2001 From: liyuchun <563917701@qq.com> Date: Thu, 16 Jun 2022 08:57:09 +0000 Subject: [PATCH 2/2] * Remove unused code. --- module/group/lang/resource.php | 1 - module/mr/control.php | 24 ------------------------ 2 files changed, 25 deletions(-) diff --git a/module/group/lang/resource.php b/module/group/lang/resource.php index bd14be2db6..32e10087ca 100644 --- a/module/group/lang/resource.php +++ b/module/group/lang/resource.php @@ -1404,7 +1404,6 @@ $lang->sonarqube->methodOrder[50] = 'browseIssue'; /* merge request. */ $lang->resource->mr = new stdclass(); $lang->resource->mr->create = 'create'; -$lang->resource->mr->apiCreate = 'apiCreate'; $lang->resource->mr->browse = 'browse'; $lang->resource->mr->edit = 'edit'; $lang->resource->mr->delete = 'delete'; diff --git a/module/mr/control.php b/module/mr/control.php index a5a42e31e5..d36413c558 100644 --- a/module/mr/control.php +++ b/module/mr/control.php @@ -99,30 +99,6 @@ class mr extends control $this->display(); } - /** - * Create MR function by api. - * - * @access public - * @return void - */ - public function apiCreate() - { - if($_POST) - { - $this->mr->apiCreate(); - - $response['result'] = 'success'; - $response['message'] = $this->lang->saveSuccess; - if(dao::isError()) - { - $response['result'] = 'fail'; - $response['message'] = join("\n", dao::getError()); - } - - return $this->send($response); - } - } - /** * Edit MR function. *