From 1bad87c15e2510a7569e8d10c898e2f89b341429 Mon Sep 17 00:00:00 2001
From: zhujinyong <zhujinyong@easycorp.ltd>
Date: Tue, 28 Nov 2023 11:15:32 +0800
Subject: [PATCH] * Performance for execution task.

---
 module/execution/control.php        | 3 +--
 module/execution/view/task.html.php | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/module/execution/control.php b/module/execution/control.php
index 6502057d54..66fc89d060 100644
--- a/module/execution/control.php
+++ b/module/execution/control.php
@@ -202,7 +202,6 @@ class execution extends control
         $pager = new pager($recTotal, $recPerPage, $pageID);
 
         /* Get tasks. */
-        $allTasks = $this->task->getExecutionTasks($executionID);
         $tasks    = $this->execution->getTasks($productID, $executionID, $this->executions, $browseType, $queryID, $moduleID, $sort, $pager);
         if(empty($tasks) and $pageID > 1)
         {
@@ -235,7 +234,7 @@ class execution extends control
 
         /* Assign. */
         $this->view->tasks        = $tasks;
-        $this->view->allTasks     = $allTasks;
+        $this->view->hasTasks     = !empty($tasks) || !empty($this->task->getExecutionTasks($executionID));
         $this->view->summary      = $this->execution->summary($tasks);
         $this->view->tabID        = 'task';
         $this->view->pager        = $pager;
diff --git a/module/execution/view/task.html.php b/module/execution/view/task.html.php
index 4b0424c85a..06dbb8b11c 100644
--- a/module/execution/view/task.html.php
+++ b/module/execution/view/task.html.php
@@ -211,7 +211,7 @@ js::set('data', json_encode($tasks));
     <div class="table-empty-tip">
       <p>
         <span class="text-muted"><?php echo $lang->task->noTask;?></span>
-        <?php if($canBeChanged and common::hasPriv('task', 'create') and empty($allTasks)):?>
+        <?php if($canBeChanged and common::hasPriv('task', 'create') && !$hasTasks):?>
         <?php echo html::a($taskCreateLink, "<i class='icon icon-plus'></i> " . $lang->task->create, '', "class='btn btn-info'");?>
         <?php endif;?>
       </p>