From 171045fab4b16e0e13d4c41cbbcd81fde210d99d Mon Sep 17 00:00:00 2001
From: tianshujie <tianshujie@easycorp.ltd>
Date: Tue, 21 Dec 2021 13:59:03 +0800
Subject: [PATCH] * Fix bug #17756,#17755,#17754,#17752,#17747.

---
 module/common/lang/common.php            | 2 +-
 module/kanban/css/createregion.css       | 1 +
 module/kanban/model.php                  | 4 ++--
 module/kanban/view/createcolumn.html.php | 8 ++++----
 module/kanban/view/space.html.php        | 2 +-
 5 files changed, 9 insertions(+), 8 deletions(-)
 create mode 100644 module/kanban/css/createregion.css

diff --git a/module/common/lang/common.php b/module/common/lang/common.php
index 5b63e29585..63a6bbf985 100644
--- a/module/common/lang/common.php
+++ b/module/common/lang/common.php
@@ -169,7 +169,7 @@ $lang->createIcons['execution']   = 'run';
 $lang->createIcons['project']     = 'project';
 $lang->createIcons['product']     = 'product';
 $lang->createIcons['program']     = 'program';
-$lang->createIcons['kanbanspace'] = 'zone';
+$lang->createIcons['kanbanspace'] = 'cube';
 $lang->createIcons['kanban']      = 'kanban';
 
 
diff --git a/module/kanban/css/createregion.css b/module/kanban/css/createregion.css
new file mode 100644
index 0000000000..dd83c6c8eb
--- /dev/null
+++ b/module/kanban/css/createregion.css
@@ -0,0 +1 @@
+.radio-inline {margin-left: 10px !important;}
diff --git a/module/kanban/model.php b/module/kanban/model.php
index 7a25949b2a..5ed03f39fd 100644
--- a/module/kanban/model.php
+++ b/module/kanban/model.php
@@ -225,7 +225,7 @@ class kanbanModel extends model
         {
             $column = fixer::input('post')
                 ->add('region', $regionID)
-                ->add('parent', $parent)
+                ->setIF($parent > 0, 'parent', $parent)
                 ->setIF($order, 'order', $order)
                 ->setDefault('color', '#333')
                 ->trim('name')
@@ -252,7 +252,7 @@ class kanbanModel extends model
         $column->limit = (int)$column->limit;
 
         $limit = $column->limit;
-        if($column->parent > 0)
+        if(isset($column->parent) and $column->parent > 0)
         {
             /* Create a child column. */
             $parentColumn = $this->getColumnByID($column->parent);
diff --git a/module/kanban/view/createcolumn.html.php b/module/kanban/view/createcolumn.html.php
index 3079b86beb..d7585e4be2 100644
--- a/module/kanban/view/createcolumn.html.php
+++ b/module/kanban/view/createcolumn.html.php
@@ -31,11 +31,11 @@
           <td>
             <div class='required required-wrapper'></div>
             <div class='input-group'>
-              <?php echo html::input('WIPCount', $column->limit != -1 ? $column->limit : '', "class='form-control'" . ($column->limit > 0 ? '' : "disabled"));?>
-              <?php echo html::hidden('limit', $column->limit, "class='form-control'");?>
+              <?php echo html::input('WIPCount', '', "class='form-control' disabled");?>
+              <?php echo html::hidden('limit', -1, "class='form-control'");?>
               <span class='input-group-addon'>
                 <label class='checkbox-inline'>
-                  <input type='checkbox' name='noLimit' id='noLimit' value='-1' <?php if($column->limit == -1) echo "checked";?>/> <?php echo $this->lang->kanban->noLimit;?>
+                  <input type='checkbox' name='noLimit' id='noLimit' value='-1' checked/> <?php echo $this->lang->kanban->noLimit;?>
                 </label>
               </span>
             </div>
@@ -52,7 +52,7 @@
           <td colspan='2' class='form-actions text-center'>
             <?php echo html::hidden('color', '#333');?>
             <?php echo html::hidden('group', $column->group);?>
-            <?php echo html::hidden('parent', $column->parent);?>
+            <?php echo html::hidden('parent', $column->parent > 0 ? $column->parent : 0);?>
             <?php echo html::submitButton();?>
             <?php echo html::commonButton($lang->cancel, "data-dismiss='modal'", 'btn btn-wide');?>
           </td>
diff --git a/module/kanban/view/space.html.php b/module/kanban/view/space.html.php
index 22e736eae5..4d5f4b870e 100644
--- a/module/kanban/view/space.html.php
+++ b/module/kanban/view/space.html.php
@@ -36,7 +36,7 @@
     <div class='space'>
       <div class='row menu'>
         <div class='spaceTitle pull-left'>
-          <div><i class='icon-zone'></i></div>
+          <div><i class='icon-cube'></i></div>
           <div>
             <h4>
               <?php if($space->status == 'closed'):?>