From e596a80929ae48156b758807ff86da6ba7bf5346 Mon Sep 17 00:00:00 2001
From: chujilu <chujilu1991@163.com>
Date: Tue, 12 Aug 2014 10:34:02 +0800
Subject: [PATCH 1/4] * fix bug: can't edit module name

---
 module/project/view/story.html.php | 4 ++--
 module/tree/model.php              | 2 +-
 module/tree/view/edit.html.php     | 2 ++
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/module/project/view/story.html.php b/module/project/view/story.html.php
index 51cc27c42a..757fc00ace 100644
--- a/module/project/view/story.html.php
+++ b/module/project/view/story.html.php
@@ -81,13 +81,13 @@
           $param = "projectID={$project->id}&story={$story->id}&moduleID={$story->module}";
 
           $lang->task->create = $lang->project->wbs;
-          common::printIcon('task', 'create', $param, '', 'list', 'sitemap');
+          common::printIcon('task', 'create', $param, '', 'list', 'smile');
 
           $lang->task->batchCreate = $lang->project->batchWBS;
           common::printIcon('task', 'batchCreate', "projectID={$project->id}&story={$story->id}", '', 'list', 'stack');
 
           $lang->testcase->batchCreate = $lang->testcase->create;
-          if($productID) common::printIcon('testcase', 'batchCreate', "productID=$story->product&moduleID=$story->module&storyID=$story->id", '', 'list', 'smile');
+          if($productID) common::printIcon('testcase', 'batchCreate', "productID=$story->product&moduleID=$story->module&storyID=$story->id", '', 'list', 'sitemap');
 
           if(common::hasPriv('project', 'unlinkStory'))
           {
diff --git a/module/tree/model.php b/module/tree/model.php
index bc6e1c340b..11d3a78309 100644
--- a/module/tree/model.php
+++ b/module/tree/model.php
@@ -636,7 +636,7 @@ class treeModel extends model
         }
         else
         {
-            if(common::hasPriv('tree', 'edit')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'edit',   "module={$module->id}&type=$type"), $this->lang->tree->edit, '', 'data-toggle="modal" data-type="ajax" data-width="400"');
+            if(common::hasPriv('tree', 'edit')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'edit',   "module={$module->id}&type=$type"), $this->lang->tree->edit, '', 'data-toggle="modal" data-type="iframe" data-width="500"');
             if(common::hasPriv('tree', 'browse') and strpos($this->config->tree->noBrowse, ",$module->type,") === false) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'browse', "root={$module->root}&type=$type&module={$module->id}"), $this->lang->tree->child);
             if(common::hasPriv('tree', 'delete')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'delete', "root={$module->root}&module={$module->id}"), $this->lang->delete, 'hiddenwin');
             if(common::hasPriv('tree', 'updateorder')) $linkHtml .= ' ' . html::input("orders[$module->id]", $module->order, 'class="text-center w-30px form-control inline input-sm"');
diff --git a/module/tree/view/edit.html.php b/module/tree/view/edit.html.php
index d20bb96590..4f94b3bc26 100644
--- a/module/tree/view/edit.html.php
+++ b/module/tree/view/edit.html.php
@@ -10,6 +10,7 @@
  * @link        http://www.zentao.net
  */
 ?>
+<?php include '../../common/view/header.lite.html.php';?>
 <?php
 $webRoot      = $this->app->getWebRoot();
 $jsRoot       = $webRoot . "js/";
@@ -49,3 +50,4 @@ $jsRoot       = $webRoot . "js/";
     </form>
   </div>
 </div>
+<?php include '../../common/view/header.lite.html.php';?>

From e4efa79e5729c005449889d6d6a1299b4f9dba64 Mon Sep 17 00:00:00 2001
From: chujilu <chujilu1991@163.com>
Date: Tue, 12 Aug 2014 11:30:43 +0800
Subject: [PATCH 2/4] * show story spec in task view

---
 module/task/control.php        | 4 +++-
 module/task/lang/en.php        | 1 +
 module/task/lang/zh-cn.php     | 1 +
 module/task/view/view.html.php | 4 ++++
 4 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/module/task/control.php b/module/task/control.php
index c4be50db85..eada0d42c4 100644
--- a/module/task/control.php
+++ b/module/task/control.php
@@ -387,7 +387,9 @@ class task extends control
      */
     public function view($taskID)
     {
-        $task = $this->task->getById($taskID, true);
+        $task            = $this->task->getById($taskID, true);
+        $story           = $this->story->getById($task->story);
+        $task->storySpec = ($story != null) ? $story->spec : '';
         if(!$task) die(js::error($this->lang->notFound) . js::locate('back'));
 
         /* Update action. */
diff --git a/module/task/lang/en.php b/module/task/lang/en.php
index 05646974a7..a002eef3f1 100644
--- a/module/task/lang/en.php
+++ b/module/task/lang/en.php
@@ -36,6 +36,7 @@ $lang->task->id                = 'ID';
 $lang->task->project           = 'Project';
 $lang->task->module            = 'Module';
 $lang->task->story             = 'Story';
+$lang->task->storySpec         = 'Story desc';
 $lang->task->storyVersion      = 'Version';
 $lang->task->name              = 'Name';
 $lang->task->type              = 'Type';
diff --git a/module/task/lang/zh-cn.php b/module/task/lang/zh-cn.php
index f66f2d4e44..c04127ac22 100644
--- a/module/task/lang/zh-cn.php
+++ b/module/task/lang/zh-cn.php
@@ -36,6 +36,7 @@ $lang->task->id                = '编号';
 $lang->task->project           = '所属项目';
 $lang->task->module            = '所属模块';
 $lang->task->story             = '相关需求';
+$lang->task->storySpec         = '需求描述';
 $lang->task->storyVersion      = '需求版本';
 $lang->task->name              = '任务名称';
 $lang->task->type              = '任务类型';
diff --git a/module/task/view/view.html.php b/module/task/view/view.html.php
index f15ff9e7de..ac00c41d36 100644
--- a/module/task/view/view.html.php
+++ b/module/task/view/view.html.php
@@ -69,6 +69,10 @@
         <legend><?php echo $lang->task->legendDesc;?></legend>
         <div class='article-content'><?php echo $task->desc;?></div>
       </fieldset>
+      <fieldset>
+        <legend><?php echo $lang->task->storySpec;?></legend>
+        <div class='article-content'><?php echo $task->storySpec;?></div>
+      </fieldset>
       <?php echo $this->fetch('file', 'printFiles', array('files' => $task->files, 'fieldset' => 'true'));?>
       <?php include '../../common/view/action.html.php';?>
       <div class='actions'> <?php if(!$task->deleted) echo $actionLinks;?></div>

From 46f988449570ab893af35cda8bae3353efbc98b2 Mon Sep 17 00:00:00 2001
From: chujilu <chujilu1991@163.com>
Date: Tue, 12 Aug 2014 15:49:32 +0800
Subject: [PATCH 3/4] * adjust code

---
 module/story/control.php          | 1 +
 module/story/view/create.html.php | 2 +-
 module/tree/view/edit.html.php    | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/module/story/control.php b/module/story/control.php
index 11cb341123..31113029bf 100644
--- a/module/story/control.php
+++ b/module/story/control.php
@@ -157,6 +157,7 @@ class story extends control
         $this->view->source           = $source;
         $this->view->pri              = $pri;
         $this->view->productID        = $productID;
+        $this->view->projectID        = $projectID;
         $this->view->estimate         = $estimate;
         $this->view->storyTitle       = $title;
         $this->view->spec             = $spec;
diff --git a/module/story/view/create.html.php b/module/story/view/create.html.php
index 038d69e846..6ed9a92181 100644
--- a/module/story/view/create.html.php
+++ b/module/story/view/create.html.php
@@ -93,7 +93,7 @@
       <tr>
         <th><?php echo $lang->story->reviewedBy;?></th>
         <td><?php echo html::select('assignedTo', $users, '', "class='form-control chosen'");?></td>
-        <td><?php echo html::checkbox('needNotReview', $lang->story->needNotReview, '', "id='needNotReview'");?></td>
+        <td><?php echo html::checkbox('needNotReview', $lang->story->needNotReview, '', "id='needNotReview'" . ($projectID > 0 ? " checked='checked'" : ""));?></td>
       </tr>  
        <tr>
         <th><nobr><?php echo $lang->story->mailto;?></nobr></th>
diff --git a/module/tree/view/edit.html.php b/module/tree/view/edit.html.php
index 4f94b3bc26..6c2b5617df 100644
--- a/module/tree/view/edit.html.php
+++ b/module/tree/view/edit.html.php
@@ -24,7 +24,7 @@ $jsRoot       = $webRoot . "js/";
         <strong><small class='text-muted'><?php echo html::icon($lang->icons['edit']);?></small> <?php echo $lang->tree->edit;?></strong>
       </div>
     </div>
-    <form class='form-condensed' method='post' class='mt-10px' id='dataform'>
+    <form action="<?php echo inlink('edit', 'module=' . $module->id .'&type=' .$type);?>" class='form-condensed' method='post' class='mt-10px' id='dataform'>
       <table class='table table-form'> 
         <?php $hidden = ($type != 'story' and $module->type == 'story');?>
         <tr <?php if($hidden) echo "style='display:none'";?>>

From f56e7c0b14468d1b31db6b440d72666e0bb64da3 Mon Sep 17 00:00:00 2001
From: chujilu <chujilu1991@163.com>
Date: Tue, 12 Aug 2014 16:16:26 +0800
Subject: [PATCH 4/4] * adjust code

---
 module/tree/model.php          | 2 +-
 module/tree/view/edit.html.php | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/module/tree/model.php b/module/tree/model.php
index 11d3a78309..d32ec30080 100644
--- a/module/tree/model.php
+++ b/module/tree/model.php
@@ -636,7 +636,7 @@ class treeModel extends model
         }
         else
         {
-            if(common::hasPriv('tree', 'edit')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'edit',   "module={$module->id}&type=$type"), $this->lang->tree->edit, '', 'data-toggle="modal" data-type="iframe" data-width="500"');
+            if(common::hasPriv('tree', 'edit')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'edit',   "module={$module->id}&type=$type"), $this->lang->tree->edit, '', 'data-toggle="modal" data-type="ajax" data-width="500"');
             if(common::hasPriv('tree', 'browse') and strpos($this->config->tree->noBrowse, ",$module->type,") === false) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'browse', "root={$module->root}&type=$type&module={$module->id}"), $this->lang->tree->child);
             if(common::hasPriv('tree', 'delete')) $linkHtml .= ' ' . html::a(helper::createLink('tree', 'delete', "root={$module->root}&module={$module->id}"), $this->lang->delete, 'hiddenwin');
             if(common::hasPriv('tree', 'updateorder')) $linkHtml .= ' ' . html::input("orders[$module->id]", $module->order, 'class="text-center w-30px form-control inline input-sm"');
diff --git a/module/tree/view/edit.html.php b/module/tree/view/edit.html.php
index 6c2b5617df..862351aad8 100644
--- a/module/tree/view/edit.html.php
+++ b/module/tree/view/edit.html.php
@@ -10,10 +10,9 @@
  * @link        http://www.zentao.net
  */
 ?>
-<?php include '../../common/view/header.lite.html.php';?>
 <?php
-$webRoot      = $this->app->getWebRoot();
-$jsRoot       = $webRoot . "js/";
+$webRoot = $this->app->getWebRoot();
+$jsRoot  = $webRoot . "js/";
 ?>
 <?php include '../../common/view/chosen.html.php';?>
 <div class='modal-dialog w-500px'>
@@ -24,7 +23,7 @@ $jsRoot       = $webRoot . "js/";
         <strong><small class='text-muted'><?php echo html::icon($lang->icons['edit']);?></small> <?php echo $lang->tree->edit;?></strong>
       </div>
     </div>
-    <form action="<?php echo inlink('edit', 'module=' . $module->id .'&type=' .$type);?>" class='form-condensed' method='post' class='mt-10px' id='dataform'>
+    <form action="<?php echo inlink('edit', 'module=' . $module->id .'&type=' .$type);?>" target='hiddenwin' class='form-condensed' method='post' class='mt-10px' id='dataform'>
       <table class='table table-form'> 
         <?php $hidden = ($type != 'story' and $module->type == 'story');?>
         <tr <?php if($hidden) echo "style='display:none'";?>>
@@ -50,4 +49,3 @@ $jsRoot       = $webRoot . "js/";
     </form>
   </div>
 </div>
-<?php include '../../common/view/header.lite.html.php';?>