From eca1930586bbdcb01641be85abba432c911f8d42 Mon Sep 17 00:00:00 2001
From: dingguodong <dingguodong@easycorp.ltd>
Date: Mon, 5 Jul 2021 10:26:54 +0800
Subject: [PATCH 1/2] * Remove useless variables for apiGetIssues.

---
 module/gitlab/model.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/gitlab/model.php b/module/gitlab/model.php
index 41a9eb56f3..6fb3ddf0e2 100644
--- a/module/gitlab/model.php
+++ b/module/gitlab/model.php
@@ -513,7 +513,7 @@ class gitlabModel extends model
     public function apiGetIssues($gitlabID, $projectID)
     {
         // TODO(dingguodong) not pagination yet.
-        $url = sprintf($this->getApiRoot($gitlabID), "/projects/{$projectID}/issues/{$issueID}");
+        $url = sprintf($this->getApiRoot($gitlabID), "/projects/{$projectID}/issues");
         return json_decode(commonModel::http($url));
     }
 

From 388f6365c925b48fc5fe9db65977f00ad4bda236 Mon Sep 17 00:00:00 2001
From: dingguodong <dingguodong@easycorp.ltd>
Date: Mon, 5 Jul 2021 10:50:24 +0800
Subject: [PATCH 2/2] * The GET form for importIssue is completed, post not.

---
 module/gitlab/control.php               | 21 +++++++++------------
 module/gitlab/model.php                 |  2 +-
 module/gitlab/view/importissue.html.php |  8 +++++---
 3 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/module/gitlab/control.php b/module/gitlab/control.php
index 213828f266..c39a7729ce 100644
--- a/module/gitlab/control.php
+++ b/module/gitlab/control.php
@@ -253,22 +253,19 @@ class gitlab extends control
 
     public function importIssue()
     {
+        $productID  = $this->get->product;
+        $gitlabID   = $this->get->gitlab;
+        $projectID  = $this->get->project;
+        
+        $executions = $this->loadModel('product')->getAllExecutionPairsByProduct($productID);
+        
         if($_POST)
         {
             $this->post->a();
         }
 
-        $productID  = $this->get->product;
-        $gitlabID   = $this->get->gitlab;
-        $projectID  = $this->get->project;
-        // todo next: get execution from product and execution module.
-
-        $executions = array();
-        foreach($relations as $relation)
-        {
-            if($relation->execution) $executions[] = $this->loadModel("execution")->getByID($relation->execution)->name;
-        }
-
+        $gitlabIssues = $this->gitlab->apiGetIssues($gitlabID, $projectID);
+        
         $this->view->productName     = $this->loadModel("product")->getByID($productID)->name;
         $this->view->productID       = $productID;
         $this->view->gitlabID        = $gitlabID;
@@ -276,7 +273,7 @@ class gitlab extends control
         $this->view->executions      = $executions; 
         $this->view->objectTypes     = $this->config->gitlab->objectTypes;
 
-        $this->view->gitlabIssues    = $this->gitlab->apiGetIssues($gitlabID, $projectID);
+        $this->view->gitlabIssues    = $gitlabIssues;
         $this->display();
     }
 }
diff --git a/module/gitlab/model.php b/module/gitlab/model.php
index ed7ba695cb..16a3f5e1d9 100644
--- a/module/gitlab/model.php
+++ b/module/gitlab/model.php
@@ -285,7 +285,7 @@ class gitlabModel extends model
      * @access public
      * @return object
      */
-    public function apiGet($host, $api, $data = array(), $options = array())
+    public function apiPost($host, $api, $data = array(), $options = array())
     {
         if(is_numeric($host)) $host = $this->getApiRoot($host);
         if(strpos($host, 'http://') !== 0 and strpos($host, 'https://') !== 0) return false;
diff --git a/module/gitlab/view/importissue.html.php b/module/gitlab/view/importissue.html.php
index 16b8879841..e1a53be93c 100644
--- a/module/gitlab/view/importissue.html.php
+++ b/module/gitlab/view/importissue.html.php
@@ -20,22 +20,24 @@
       <table class="table table-borderless">
         <thead>
           <tr>
+            <th width='60px'><?php echo $lang->gitlab->gitlabIssue;?></th>
             <th width='30px'><?php echo $lang->product->common;?></th>
             <th width='30px'><?php echo $lang->execution->common;?></th>
-            <th width='60px'><?php echo $lang->gitlab->gitlabIssue;?></th>
             <th width='30px'><?php echo $lang->gitlab->objectType;?></th>
           </tr>
         </thead>
         <tbody>
+        <?php foreach($gitlabIssues as $issue):?>
           <tr>
+            <td><?php echo $issue->title; ?></td>
             <td><?php echo $productName; ?></td>
             <input type='hidden' name='productID' value='<?php echo $productID;?>' />
             <input type='hidden' name='gitlabID'   value='<?php echo $gitlabID;?>' />
             <input type='hidden' name='gitlabProjectID' value='<?php echo $gitlabProjectID;?>' />
-            <td><?php echo html::select("executionName", $executions, '', "class='form-control select chosen'" );?></td>
-            <td><?php echo html::select("gitlabIssueID", $gitlabIssues, '', "class='form-control select chosen'" );?></td>
+            <td><?php echo html::select("mappedIssues", $executions, '', "class='form-control select chosen'" );?></td>
             <td><?php echo html::select("objectType", $objectTypes, '', "class='form-control select chosen'" );?></td>
          </tr>
+        <?php endforeach; ?>
         </tbody>
         <tfoot>
           <tr>