From 0e0f0af55536448c7d1ce7c38d2ab9ac079191e1 Mon Sep 17 00:00:00 2001
From: Yagami <976204163@qq.com>
Date: Fri, 22 Mar 2019 11:19:44 +0800
Subject: [PATCH] * Finish child task.

---
 module/task/lang/en.php        | 1 -
 module/task/lang/zh-cn.php     | 1 -
 module/task/model.php          | 4 ++--
 module/task/view/edit.html.php | 8 +-------
 4 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/module/task/lang/en.php b/module/task/lang/en.php
index 4f9f5a52d0..da4a540524 100644
--- a/module/task/lang/en.php
+++ b/module/task/lang/en.php
@@ -106,7 +106,6 @@ $lang->task->team              = 'Team';
 $lang->task->transfer          = 'Transfer';
 $lang->task->transferTo        = 'Transfer To';
 $lang->task->children          = 'Child Task';
-$lang->task->unlinkParent      = 'Unlink Parent';
 $lang->task->childrenAB        = 'Child';
 $lang->task->parent            = 'Parent Task';
 $lang->task->parentAB          = 'Parent Task';
diff --git a/module/task/lang/zh-cn.php b/module/task/lang/zh-cn.php
index 2945efd2ff..a4ba48d715 100644
--- a/module/task/lang/zh-cn.php
+++ b/module/task/lang/zh-cn.php
@@ -106,7 +106,6 @@ $lang->task->team             = '团队';
 $lang->task->transfer         = '转交';
 $lang->task->transferTo       = '转交给';
 $lang->task->children         = '子任务';
-$lang->task->unlinkParent     = '取消子任务';
 $lang->task->childrenAB       = '子';
 $lang->task->parent           = '父任务';
 $lang->task->parentAB         = '父';
diff --git a/module/task/model.php b/module/task/model.php
index e5c00ca837..83ed72097d 100644
--- a/module/task/model.php
+++ b/module/task/model.php
@@ -655,13 +655,13 @@ class taskModel extends model
             ->setIF($this->post->assignedTo != $oldTask->assignedTo, 'assignedDate', $now)
 
             ->setIF($this->post->status == 'wait' and $this->post->left == $oldTask->left and $this->post->consumed == 0 and $this->post->estimate, 'left', $this->post->estimate)
-            ->setIF(isset($_POST['unlinkParent']), 'parent', 0)
+            ->setIF($oldTask->parent > 0 and !$this->post->parent, 'parent', 0)
 
             ->setDefault('lastEditedBy',   $this->app->user->account)
             ->add('lastEditedDate', $now)
             ->stripTags($this->config->task->editor->edit['id'], $this->config->allowedTags)
             ->join('mailto', ',')
-            ->remove('comment,files,labels,uid,multiple,team,teamEstimate,teamConsumed,teamLeft,contactListMenu,unlinkParent')
+            ->remove('comment,files,labels,uid,multiple,team,teamEstimate,teamConsumed,teamLeft,contactListMenu')
             ->get();
 
         if($task->consumed < $oldTask->consumed) die(js::error($this->lang->task->error->consumedSmall));
diff --git a/module/task/view/edit.html.php b/module/task/view/edit.html.php
index b588ea1f19..99e5eeb29c 100644
--- a/module/task/view/edit.html.php
+++ b/module/task/view/edit.html.php
@@ -103,18 +103,12 @@
                 <td><span id="storyIdBox"><?php echo html::select('story', $stories, $task->story, "class='form-control chosen'");?></span></td>
               </tr>
               <?php endif;?>
-              <?php if($task->parent == 0 and empty($task->team)):?>
+              <?php if($task->parent >= 0 and empty($task->team)):?>
               <tr>
                 <th><?php echo $lang->task->parent;?></th>
                 <td><?php echo html::select('parent', $tasks, $task->parent, "class='form-control chosen'");?></td>
               </tr>
               <?php endif;?>
-              <?php if($task->parent > 0):?>
-              <tr>
-                <th><?php echo $lang->task->unlinkParent;?></th>
-                <td><?php echo html::checkbox('unlinkParent', '');?></td>
-              </tr>
-              <?php endif;?>
               <tr>
                 <th><?php echo $lang->task->assignedTo;?></th>
                 <td><span id="assignedToIdBox"><?php echo html::select('assignedTo', $members, $task->assignedTo, "class='form-control chosen'");?></span></td>