From 0d3ed88c1db8bf38ccf0dca48226be8619d89916 Mon Sep 17 00:00:00 2001
From: liumengyi <liumengyi@easycorp.ltd>
Date: Mon, 17 Jan 2022 14:40:40 +0800
Subject: [PATCH] * Delete useless code.

---
 module/execution/js/kanban.js | 2 +-
 module/execution/model.php    | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/module/execution/js/kanban.js b/module/execution/js/kanban.js
index ad43e71d12..70f2508d49 100644
--- a/module/execution/js/kanban.js
+++ b/module/execution/js/kanban.js
@@ -1015,7 +1015,7 @@ $(function()
         $.zui.ContextMenu.hide();
     });
 
-    $('#toStoryButton').on('click', function(e)
+    $('#toStoryButton').on('click', function()
     {
         var planID = $('#plan').val();
         if(planID)
diff --git a/module/execution/model.php b/module/execution/model.php
index 3197564d89..22e5fbdf36 100644
--- a/module/execution/model.php
+++ b/module/execution/model.php
@@ -2288,14 +2288,15 @@ class executionModel extends model
         $linkedStories = $this->dao->select('*')->from(TABLE_PROJECTSTORY)->where('project')->eq($executionID)->orderBy('order_desc')->fetchPairs('story', 'order');
         $lastOrder     = reset($linkedStories);
         $storyList     = $this->dao->select('id, status, branch')->from(TABLE_STORY)->where('id')->in(array_values($stories))->fetchAll('id');
+
+        $extra = str_replace(array(',', ' '), array('&', ''), $extra);
+        parse_str($extra, $output);
         foreach($stories as $key => $storyID)
         {
             $notAllowedStatus = $this->app->rawMethod == 'batchcreate' ? 'closed' : 'draft,closed';
             if(strpos($notAllowedStatus, $storyList[$storyID]->status) !== false) continue;
             if(isset($linkedStories[$storyID])) continue;
 
-            $extra = str_replace(array(',', ' '), array('&', ''), $extra);
-            parse_str($extra, $output);
             if(isset($output['laneID']) and isset($output['columnID'])) $this->loadModel('kanban')->addKanbanCell($executionID, $output['laneID'], $output['columnID'], 'story', $storyID);
 
             $data = new stdclass();