From a431691425fce4c615b5def5499b683fcba79634 Mon Sep 17 00:00:00 2001 From: holan20180123 <56391770@qq.com> Date: Wed, 23 Dec 2020 13:43:25 +0800 Subject: [PATCH 1/2] * Remove build field from release of product. --- module/program/view/pgmproduct.html.php | 2 -- module/release/config.php | 2 +- module/release/control.php | 11 +---------- module/release/model.php | 3 --- module/release/view/create.html.php | 4 ---- module/release/view/edit.html.php | 4 ---- 6 files changed, 2 insertions(+), 24 deletions(-) diff --git a/module/program/view/pgmproduct.html.php b/module/program/view/pgmproduct.html.php index c64fc2a70d..e54e69a9c0 100644 --- a/module/program/view/pgmproduct.html.php +++ b/module/program/view/pgmproduct.html.php @@ -40,7 +40,6 @@ idAB);?> product->name);?> - product->program;?> product->activeStories;?> product->changedStories;?> product->draftStories;?> @@ -65,7 +64,6 @@ createLink('product', 'browse', 'product=' . $product->id), $product->name);?> - name;?> stories['active'];?> stories['changed'];?> stories['draft'];?> diff --git a/module/release/config.php b/module/release/config.php index 464702d309..7e52377cd7 100644 --- a/module/release/config.php +++ b/module/release/config.php @@ -3,7 +3,7 @@ $config->release = new stdclass(); $config->release->create = new stdclass(); $config->release->edit = new stdclass(); $config->release->create->requiredFields = 'name,date'; -$config->release->edit->requiredFields = 'name,date,build'; +$config->release->edit->requiredFields = 'name,date'; $config->release->editor = new stdclass(); $config->release->editor->create = array('id' => 'desc', 'tools' => 'simpleTools'); diff --git a/module/release/control.php b/module/release/control.php index e712c01d03..25907dc273 100644 --- a/module/release/control.php +++ b/module/release/control.php @@ -77,15 +77,9 @@ class release extends control $this->send(array('result' => 'success', 'message' => $this->lang->saveSuccess, 'locate' => inlink('view', "releaseID=$releaseID"))); } - $builds = $this->loadModel('build')->getProductBuildPairs($productID, $branch, 'notrunk|withbranch', false); - $releaseBuilds = $this->release->getReleaseBuilds($productID, $branch); - foreach($releaseBuilds as $build) unset($builds[$build]); - unset($builds['trunk']); - $this->commonAction($productID, $branch); $this->view->title = $this->view->product->name . $this->lang->colon . $this->lang->release->create; $this->view->position[] = $this->lang->release->create; - $this->view->builds = $builds; $this->view->productID = $productID; $this->view->lastRelease = $this->release->getLast($productID, $branch); $this->display(); @@ -119,16 +113,13 @@ class release extends control $this->loadModel('bug'); $this->loadModel('build'); - /* Get release and build. */ + /* Get release. */ $release = $this->release->getById((int)$releaseID); $this->commonAction($release->product, $release->branch); - $build = $this->build->getById($release->build); $this->view->title = $this->view->product->name . $this->lang->colon . $this->lang->release->edit; $this->view->position[] = $this->lang->release->edit; $this->view->release = $release; - $this->view->build = $build; - $this->view->builds = $this->loadModel('build')->getProductBuildPairs($release->product, $release->branch, 'notrunk|withbranch', false); $this->display(); } diff --git a/module/release/model.php b/module/release/model.php index df1549f5d5..71f3cf75ce 100644 --- a/module/release/model.php +++ b/module/release/model.php @@ -114,9 +114,6 @@ class releaseModel extends model $branch = (int)$branch; $buildID = 0; - /* Check build if build is required. */ - if(strpos($this->config->release->create->requiredFields, 'build') !== false and $this->post->build == false) return dao::$errors[] = sprintf($this->lang->error->notempty, $this->lang->release->build); - /* Check date must be not more than today. */ if($this->post->date > date('Y-m-d')) return dao::$errors[] = $this->lang->release->errorDate; diff --git a/module/release/view/create.html.php b/module/release/view/create.html.php index 8fddb38e36..6a8266e630 100644 --- a/module/release/view/create.html.php +++ b/module/release/view/create.html.php @@ -31,10 +31,6 @@ release->last . ': ' . $lastRelease->name . ')';?> - - release->build;?> - - release->date;?> diff --git a/module/release/view/edit.html.php b/module/release/view/edit.html.php index bf94003bc4..8bc5a95af1 100644 --- a/module/release/view/edit.html.php +++ b/module/release/view/edit.html.php @@ -35,10 +35,6 @@ - - release->build;?> - build, "class='form-control chosen' required"); ?> - release->date;?> date, "class='form-control form-date' required");?> From 5038567a2c9d64ced1c71bf9fd5a39de0078e147 Mon Sep 17 00:00:00 2001 From: holan20180123 <56391770@qq.com> Date: Wed, 23 Dec 2020 13:53:16 +0800 Subject: [PATCH 2/2] * Finish task #8749. --- module/program/view/pgmproduct.html.php | 1 + 1 file changed, 1 insertion(+) diff --git a/module/program/view/pgmproduct.html.php b/module/program/view/pgmproduct.html.php index e54e69a9c0..657e178cfd 100644 --- a/module/program/view/pgmproduct.html.php +++ b/module/program/view/pgmproduct.html.php @@ -15,6 +15,7 @@
product->featureBar['all'] as $key => $label):?> + {$pager->recTotal}";?> id&browseType=$key&orderBy=$orderBy"), "{$label}", '', "class='btn btn-link $active'");?>